From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id D08C95A31 for ; Mon, 20 Apr 2015 15:14:58 +0200 (CEST) Received: by wiun10 with SMTP id n10so91069221wiu.1 for ; Mon, 20 Apr 2015 06:14:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=QwAFgjuWQ+Wn8Ev7yqLgbqkSZyBppEgyVOELdg8V7No=; b=DLKHg+WPR6ULv0EISmdxe9RVgpM0Fuv2VOBg8Sfui/vGSHmxR8/0Fewg0F8TGrdLR9 WmwUh0irHtzYQEAR7QJ6Aw0vDmbd/Z2v/eNfNF1rwd7YdHoorhMNpyBYiXRDqL74qVVH l5phY9K6kqi7vKwXCrYXJU8jAlqG8rAPDM0EmCkG0M/t9v/FLSY/b2r9tZYJ1xx02eLN 8UIcdmmjBHmW2o94eg6Y+UI93eq0aFBaIaCrsNd4syoUg+kBCBC7bN++vjlMYEA1MKh8 hBsvrNkiDqB2J8NRpfWWEpqmolYi8oQtuUOTO6NhogD9MiOVEDUclBg9R2sESWYvsriG KCvg== X-Gm-Message-State: ALoCoQlS2RQRXl0wF6hA1nNMwShno8NUbNoVbVi7+5XB1OyRrnAKpcbGRBj/dGiL8ebU1eV4zJve X-Received: by 10.195.12.138 with SMTP id eq10mr29937666wjd.65.1429535698704; Mon, 20 Apr 2015 06:14:58 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dz4sm15226804wib.17.2015.04.20.06.14.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2015 06:14:57 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Mon, 20 Apr 2015 15:14:15 +0200 Message-ID: <2757566.zEsJEgcNg7@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1429284934-3261-3-git-send-email-stephen@networkplumber.org> References: <1429284934-3261-1-git-send-email-stephen@networkplumber.org> <1429284934-3261-3-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] eal: pci probe and adjust_config should be void X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 13:14:59 -0000 2015-04-17 08:35, Stephen Hemminger: > This functions always returned 0 and therefore should be void. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/common/eal_common_options.c | 3 +-- > lib/librte_eal/common/eal_common_pci.c | 7 ++----- > lib/librte_eal/common/eal_options.h | 2 +- > lib/librte_eal/common/include/rte_pci.h | 6 +----- > lib/librte_eal/linuxapp/eal/eal.c | 6 ++---- > 5 files changed, 7 insertions(+), 17 deletions(-) Why bsdapp is not changed? You posted a similar patch few days before which was modifying bsdapp: http://dpdk.org/dev/patchwork/patch/4306/