From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D966CA04DB; Mon, 16 Nov 2020 08:19:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BD98C8B0; Mon, 16 Nov 2020 08:19:49 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id AFCA4323E for ; Mon, 16 Nov 2020 08:19:46 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 20C23580415; Mon, 16 Nov 2020 02:19:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 16 Nov 2020 02:19:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= iIkdP0nNZK4+h8cDvSrL9t45buJxfAIZahFcWas345Q=; b=DzRydRYIwhAstt9Q vjBHEiqiLOsjVZLquEXM88qfbGOmAW0DJYoLgzVZq10KgzMkOZTXJ0zilLr/yHTT 2Ghj5MXjQP4xoHaKWisJVv8j4P7I6Fd1Jf804iR4uInyp0UCfL2NMAO4diyryaYI MPY6mORAicJcONwn5r1jhWOt0cwCgBmzbFpp2YbD76iBOmnlr0SKFcb+YXZSqUbi p9080hU6biaugKK2zGn+NDTuyFeWMVbNZHpjoOOQl0D6wT3fLt+5kqGRAGnQrWFE CLEq/kOdb+Xegs/Wh2J2DaRJ15mVc/49y82uANYbA/3rZVbkqof0G7q2BK1fyOAH bM/yuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=iIkdP0nNZK4+h8cDvSrL9t45buJxfAIZahFcWas34 5Q=; b=YtwREfrgj7mb5SRc7VFazqL3d1RyglayW+0hqKKB+cbOHOHxzRrMQqzJw c7ws0L8ToLjqpu0rskJCkiLLEpKMYR90Uds93ipahha8LDtN/902K3GSMx2518FM gxZYr44nB4zgmJ0JiSYRdvkl9fiN9+zhlHWq9iKD3w+a1csZ3hWBOgHQNdCjkBpx +U9Yvia+Lea9GBpMGrOHoF1SOetw+k40iNQTLz0PVRqgAOLoCLBPE4N1i+bjEgPq lENeW/W6qQTITaYLdwanv2kjGyITqIpbkk6aRnf9VRD/mXvUu5VLSNZ7ZUGzUwz1 GGs3l3e5HQG0HZU58rMvHDNJubXVQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeftddguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdev uedtjeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A8533328005A; Mon, 16 Nov 2020 02:19:42 -0500 (EST) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: "bruce.richardson@intel.com" , "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "Phil.Yang@arm.com" , "vcchunga@amazon.com" , "Dharmik.Thakkar@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ajit.khaparde@broadcom.com" , "ferruh.yigit@intel.com" , "dev@dpdk.org" Date: Mon, 16 Nov 2020 08:19:40 +0100 Message-ID: <2757615.pcuGzlY5F1@thomas> In-Reply-To: <5046086c84504de5a9c863d6cb5d8ebc@pantheon.tech> References: <1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech> <8818704.t7QGBsBHN5@thomas> <5046086c84504de5a9c863d6cb5d8ebc@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/11/2020 08:15, Juraj Linke=C5=A1: > From: Thomas Monjalon > > 13/11/2020 15:31, Juraj Linke=C5=A1: > > > Add an option to automatically discover the host's numa and cpu counts > > > and use those values for a non cross-build. > > > Give users the option to override the per-arch default values or > > > values from cross files by specifying them on the command line with > > > -Dmax_lcores and -Dmax_numa_nodes. > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > Reviewed-by: Honnappa Nagarahalli > > [...] > > > create mode 100644 buildtools/get_cpu_count.py create mode 100644 > > > buildtools/get_numa_count.py > >=20 > > These new files should be added in the file MAINTAINERS. >=20 > Should I add a new section? I just add them under Build System, > making Bruce the maintainer of these? If Bruce is OK, it looks fine. > > The recommended pattern is to use - as word separator in script filenam= es. > >=20 >=20 > Ok, I'll rename them. >=20 > > I'm also worried there is no more review on such general change, especi= ally the > > description in meson_options.txt: > >=20 > > > +option('max_lcores', type: 'integer', value: 0, > > > + description: 'maximum number of cores/threads supported by > > > +EAL. Set to positive integer to overwrite per-arch or cross-compilat= ion > > defaults. Set to -1 to detect the number of cores on the build machine.= ') > > option('max_numa_nodes', type: 'integer', value: 0, > > > + description: 'maximum number of NUMA nodes supported by EAL. = Set to > > positive integer to overwrite per-arch or cross-compilation defaults. S= et to -1 to > > detect the number of numa >=20 > Honnappa reviewed this and Bruce also provided his comments > and he's the only maintainer listed for meson_options.txt. > Who else should review this? Bruce did not ack. I want to do careful reviews myself as well.