Re: [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-02-15 13:56, Panu Matilainen:
> On 02/15/2016 12:15 PM, Thomas Monjalon wrote:
> > 2016-02-15 10:29, Panu Matilainen:
> >> On 02/14/2016 01:38 AM, Matthew Hall wrote:
> >>> Hello,
> >>>
> >>> I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you use an installed copy of DPDK to compile the examples instead of the master copy (while trying to update some outdated stuff in my build system).
> > [...]
> >>> Did anybody run into this before?
> >>
> >> Yes, the problem exists at least since DPDK 2.1 but somehow never
> >> remembered to report / do something about it.
> >>
> >> Basically either vm_power_manager example is messing with things its not
> >> supposed to, or librte_power library isn't exporting everything needed
> >> to fully use the it. Unfortunately both the library and the example are
> >> lacking a maintainer :-/
> >
> > Exact, you got the point.
> > I suggest to disable this feature in your config.
> 
> I take it you mean disabling librte_power entirely, not just the example?

Yes

> > If it's really annoying, you are allowed to request the removal of the code.
> > I believe someone would maintain it if he has an interest.
> 
> I can certainly submit a patch to disable it by default in the configs 
> (seems reasonable unmaintained code would default to off) and add a 
> deprecation note along the lines of "if no maintainer steps up, this 
> code will be removed in 16.07" if you like :)

Before sending such notice, we should wait for comments of some known
contributors to librte_power.
Alan, Pablo, what is your opinion?