From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 5096656B7 for ; Mon, 15 Feb 2016 14:22:48 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id a4so55953971wme.1 for ; Mon, 15 Feb 2016 05:22:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=g1RhINg6qlEV+zRehUoPmMAXib8mqYeEEUq/fqs8Xx0=; b=M2K1+ETftOX0MWeC3sCVEWA9GOadmuFT5H2RGm3/kphhM6yCrlOUgUy3DE61Biiz5n UdwH/fPXjAv50noZAn3y7AlA+wSJf0v3la2lsvxVs90if3Hhhi0IIdr+m8gT2yBQVFf5 Q7OK4oPim4oeXY1VApz2EjuPQKcXF5EW5/bMMbK9KsFR71r/c5HtZkzCsxpUjZk9TVbQ MCTDO/DE3y3ck121wJ9YmyWQ8RKVmdXfWYbKxXCwAE47LzT6A1+aDzZbe12lRLP8dg1C M38vbW/y229ziOD9iVgg9vrDfYph/KkCyuJOi5/RPb/UyGV+C72dE/OIlt8KzULIQMdW nBBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=g1RhINg6qlEV+zRehUoPmMAXib8mqYeEEUq/fqs8Xx0=; b=Xn+EJcY3ZlnhQ8oELh1bmU4bi8neKfVTz0muo7S/r3mB+xF53G07/DMuuJCGrI1mvf vtc+vs8cSbB5aZxkRCRNTlVX9ZCmUBax9kv3px4U2ELfB+DzZN+76QTy+bMvlf3W8NZK aZl5hY5pP7eZz8Fryx6XEOkgTTIIPZO2IX3xqigSXLDUzXhn0vgwYu45pQG6cGdOmuY/ 9p1tTfTTFzNM25vUcPrBA57wg5qctJOnplLwNfWuviLLtEgEZU+CcewgUbgEfRgyKQfv zmLFZWLkEExVEmIJ0H9A3bQ9w9j1BGXsFUcxxPYwWhwzlz61zaJ4BbvY9UlFSlTDQhfH NfTQ== X-Gm-Message-State: AG10YOQ23F3jCnYQixmoVqjbnV+/1jnKXNlx26vcYwBdXs1cyIwJ4rQl4eUtbm/x9gl5A687 X-Received: by 10.194.184.139 with SMTP id eu11mr18941416wjc.169.1455542568153; Mon, 15 Feb 2016 05:22:48 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id e14sm15724604wmi.21.2016.02.15.05.22.47 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Feb 2016 05:22:47 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen , Alan Carew , Pablo de Lara Date: Mon, 15 Feb 2016 14:21:16 +0100 Message-ID: <2759253.A73iH2ao4l@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56C1BCFA.7050506@redhat.com> References: <0863DE89-580E-4AA2-B949-25179510BD55@mhcomputing.net> <6087984.WHOrx6HCKo@xps13> <56C1BCFA.7050506@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2016 13:22:48 -0000 2016-02-15 13:56, Panu Matilainen: > On 02/15/2016 12:15 PM, Thomas Monjalon wrote: > > 2016-02-15 10:29, Panu Matilainen: > >> On 02/14/2016 01:38 AM, Matthew Hall wrote: > >>> Hello, > >>> > >>> I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you use an installed copy of DPDK to compile the examples instead of the master copy (while trying to update some outdated stuff in my build system). > > [...] > >>> Did anybody run into this before? > >> > >> Yes, the problem exists at least since DPDK 2.1 but somehow never > >> remembered to report / do something about it. > >> > >> Basically either vm_power_manager example is messing with things its not > >> supposed to, or librte_power library isn't exporting everything needed > >> to fully use the it. Unfortunately both the library and the example are > >> lacking a maintainer :-/ > > > > Exact, you got the point. > > I suggest to disable this feature in your config. > > I take it you mean disabling librte_power entirely, not just the example? Yes > > If it's really annoying, you are allowed to request the removal of the code. > > I believe someone would maintain it if he has an interest. > > I can certainly submit a patch to disable it by default in the configs > (seems reasonable unmaintained code would default to off) and add a > deprecation note along the lines of "if no maintainer steps up, this > code will be removed in 16.07" if you like :) Before sending such notice, we should wait for comments of some known contributors to librte_power. Alan, Pablo, what is your opinion?