From: Thomas Monjalon <thomas@monjalon.net>
To: "Shijith Thotton" <sthotton@marvell.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
fengchengwen <fengchengwen@huawei.com>,
david.marchand@redhat.com
Subject: Re: Building DPDK with IOVA_AS_VA
Date: Sun, 19 Feb 2023 12:05:55 +0100 [thread overview]
Message-ID: <2759826.XrmoMso0CX@thomas> (raw)
In-Reply-To: <16603912.Ash8RoxBsO@thomas>
19/02/2023 11:01, Thomas Monjalon:
> 09/12/2022 10:33, fengchengwen:
> > The hns3 and idpf both use static_library to build advanced vector (e.g. SVE for hns3 and AVX512 for idpf).
> > The static-library is still compiled even the PMD is not compiled, and this lead to the compile fail problem.
> >
> > Although the following could solve the problem, but is there a better plan?
> > +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
> > + build = false
> > + reason = 'driver does not support disabling IOVA as PA mode'
> > + subdir_done()
> > +endif
>
> Yes there is a better plan: fix drivers/meson.build.
> We must move the "continue" to skip the driver as soon as possible.
Scratch that, it's a stupid idea.
The problem is generating sub-libraries inside the driver
in order to map some specific compiler options with some files.
Looks like we must disable the build inside the driver:
+if not get_option('enable_iova_as_pa')
+ subdir_done()
+endif
No need to give reason or disable build as it will be done anyway in drivers/meson.build.
prev parent reply other threads:[~2023-02-19 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 16:58 Morten Brørup
2022-12-06 18:55 ` Morten Brørup
2022-12-07 6:51 ` Wu, Jingjing
2022-12-07 7:15 ` Shijith Thotton
2022-12-07 7:19 ` Wu, Jingjing
2022-12-09 9:33 ` fengchengwen
2023-02-19 10:01 ` Thomas Monjalon
2023-02-19 11:05 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2759826.XrmoMso0CX@thomas \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jingjing.wu@intel.com \
--cc=mb@smartsharesystems.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).