DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>, thomas.monjalon@6wind.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] eal: fix libabi macro for device generalization patches
Date: Wed, 26 Oct 2016 15:25:33 +0100	[thread overview]
Message-ID: <275ffc52-acb0-c177-da32-fb8c3fee497a@intel.com> (raw)
In-Reply-To: <8ed305c5-92aa-a169-533e-47057ea3e6fd@nxp.com>

Hi Shreyansh,

On 10/26/2016 2:12 PM, Shreyansh Jain wrote:
> On Wednesday 26 October 2016 06:30 PM, Shreyansh Jain wrote:
>> rte_device/driver generalization patches [1] were merged without a change
>> in the LIBABIVER macro. This patches bumps the macro of affected libs.
>>
>> Also, deprecation notice from 16.07 has been removed and release notes for
>> 16.11 added.
>>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> --
>> v2:
>>  - Mark bumped libraries in release_16_11.rst file
>>  - change code symbol names from text to code layout
>>
>> ---

<...>

>>  .. code-block:: diff
>>
>> -     libethdev.so.4
>> +   + libethdev.so.4
> 
> Just noticed:
> Should the '4' here reflect the current LIBABIVER number?
> If so, I will send this patch again.

Yes, as you guessed, it should be:
-     libethdev.so.4
+   + libethdev.so.5

<...>

>> diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile
>> index a15b762..122798c 100644
>> --- a/lib/librte_eal/bsdapp/eal/Makefile
>> +++ b/lib/librte_eal/bsdapp/eal/Makefile
>> @@ -48,7 +48,7 @@ LDLIBS += -lgcc_s
>>
>>  EXPORT_MAP := rte_eal_version.map
>>
>> -LIBABIVER := 3
>> +LIBABIVER := 4

eal version seems already increased for this release, 2 => 3, in:
d7e61ad3ae36 ("log: remove deprecated history dump")

So NO need to increase it again, sorry for late notice, I just
recognized it.
Only librte_ether and librte_cryptodev requires the increase.

<...>

Thanks,
ferruh

  reply	other threads:[~2016-10-26 14:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 12:38 [dpdk-dev] [PATCH] " Shreyansh Jain
2016-10-26 13:00 ` [dpdk-dev] [PATCH v2] " Shreyansh Jain
2016-10-26 13:12   ` Shreyansh Jain
2016-10-26 14:25     ` Ferruh Yigit [this message]
2016-10-26 15:23       ` Thomas Monjalon
2016-10-27  5:07         ` Shreyansh Jain
2016-10-27  5:06       ` Shreyansh Jain
2016-10-27  7:08   ` [dpdk-dev] [PATCH v3] " Shreyansh Jain
2016-10-27 10:15     ` Thomas Monjalon
2016-10-27 11:10       ` Shreyansh Jain
2016-10-27 11:29     ` [dpdk-dev] [PATCH v4] eal: fix lib version " Shreyansh Jain
2016-10-27 11:32       ` Shreyansh Jain
2016-10-27 12:16         ` Thomas Monjalon
2016-11-06 17:51       ` Thomas Monjalon
2016-10-26 13:02 ` [dpdk-dev] [PATCH] eal: fix libabi macro " Shreyansh Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=275ffc52-acb0-c177-da32-fb8c3fee497a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=shreyansh.jain@nxp.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).