From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6091843699; Thu, 7 Dec 2023 14:57:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F43F42EF9; Thu, 7 Dec 2023 14:57:55 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2085.outbound.protection.outlook.com [40.107.237.85]) by mails.dpdk.org (Postfix) with ESMTP id D0F6742EF8 for ; Thu, 7 Dec 2023 14:57:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l9L+lhD2r5zbPsbHcI0FdzGzpgevM60KxYeS37uX5xPSVdCiyD3/hFkQm5vNgAJBhl8gLpO14vP/8foXhGlBtJiCNxcct/gDdCY+Oxw1fqz4JXcnVHK64MYKBn02kemMJBjzZH66kYveP3X81Z8pYivbTpSxc/I26Y8W3IgqxahKKNH1FItLSQdHTxIbM2q5/Q3kcYHLEMPn0wHvDClsr/9Igjq4HSvLIsVKTLFz5Bt8xtJK0+ekpEvHKKY05zS9+NQhdI0OTxLQckRk0h4YBZTYRRtoxjowT+EGJtN97L2VSipEEShr53O1eBGItY/QE43VYYYo4z/Kl2/7y3j5pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=whz6w8CsDKriKiv4uBb5GGgiPo4Z4dCm4h4AdUxpYnE=; b=JPi6y3+EqMJT8FLKP2s4aoBstNfKTnCnasITzyEHQ+wpkiukK/Mg/UgAlVxQeeKFWb1tQXmL9ehDtOiO2sdT1JIzaK3A5W02jZRBtB1z63K9lypujJixVV8pNq3qZEFFMRvBVXx1zfC9mujw3OamX2Y9sl1c6s1NB03CwNcbRXyjSkgKDhzSsw7LIviJoG2hfFqqqYPtqNm8sH/S7LSXltJnDFdOsd6d8rk2z1syDORw6Sf1dlsCF9ddbTvuUqZMFuKmxVhsusCLpHig9x3oBY17sixgeIlHMry8w+6ke69fbwlJluXyyuw9prl7AMzT/6aI69Am7j8duyUuiBOGcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=whz6w8CsDKriKiv4uBb5GGgiPo4Z4dCm4h4AdUxpYnE=; b=yyl9EoIkyFu3JC6NQTDSbVOmwPLRO8qzMLYAwvAg9EwxtUmpIkkvXpDiLRLFbN26WH6QANuf2OC/yF4lEK7A6SHPE5rkYK5jXrFYeDBZ5Z71VUD7GPBuWliy7g2+/m2gPkdC6yOLOi+cde0equ1xkQx/Etkv+SvrI7P6ATMUWg0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7954.namprd12.prod.outlook.com (2603:10b6:806:344::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Thu, 7 Dec 2023 13:57:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7068.025; Thu, 7 Dec 2023 13:57:52 +0000 Message-ID: <276129aa-6317-4dd8-aa9f-0aa047fcf24a@amd.com> Date: Thu, 7 Dec 2023 13:57:49 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] net/hns3: use stdatomic API Content-Language: en-US To: Jie Hai , dev@dpdk.org, Yisen Zhuang Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com, Tyler Retzlaff , David Marchand References: <20231111015915.2776769-1-haijie1@huawei.com> <20231207014205.4002558-1-haijie1@huawei.com> <20231207014205.4002558-5-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231207014205.4002558-5-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR1P264CA0192.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:34d::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7954:EE_ X-MS-Office365-Filtering-Correlation-Id: ef932c52-4e42-470d-dce0-08dbf72c80fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CMK1e4FA1GrG+NH3iRDQ807z6vMg1x+HIeCZs+oNevc0llFFJh0xclBpUB0Kb0sRyW5W01aPi0qzYw6u/8mhaJ/OVlUGed0ovBQraLzpQVjZi9N5OtfGab6xFCyqMV9FUC4XFl7vuuCJmQFZyIlxxbl8CGf/dsluRzaVjGA/YT/AlU5CAq3Ppn4KgEf9IADEHDjMz+3d90H+NOCBpJ+C5DMxrjnB6TDflI4c+s90anwKaB1T2BcLibSGmBoMT8WCRIgI3cNssw3fvzH7lzVoa79L10auyIcTvTP4SP9KG1bLP+BYYfbY9LgQB0pRBDHwM47BaY0TcyMb39ydZ8sqVJaGGRTWXZgj53sS4O0mrGzuUzVsrmGJVvlgyjIPj7xERTXVw/krGZKgIoC6AMrdp5KIcQfHE45q/souHNTse4l5+3ApRIMZYIs0DKUMAs1zQho+C+9cU+Y6KuutlBJDZTD9+Mj0IabLEMPt7zBr/cnRHwWDGIU/4EsZ0t5TWTzL5speD+nHj9J6gsipBHYHYycT7YyQ64ZngzF84iYxKPQScDQofJ+1NhYHcLP7tfNTYZA4Qcly2udoXAKJDna3OF3z65MLIFI4qtqAghS3b7e2QQn9CYVXNCNhTEWWCW36EvcLlH3eBqVkphB7cR9fe4D3RgkYONfilk9u7O5ES+M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(346002)(396003)(39860400002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(5660300002)(4744005)(2906002)(44832011)(478600001)(4326008)(8676002)(8936002)(31686004)(316002)(66476007)(54906003)(110136005)(66556008)(66946007)(6486002)(26005)(41300700001)(6666004)(53546011)(2616005)(36756003)(6512007)(38100700002)(86362001)(31696002)(6506007)(21314003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1hYallNZXdNNGU3NU1CcC84WVFzSHY3YVBzb3lnMTdZMG1USWQ4TWM4Y2U1?= =?utf-8?B?QmYxRGJuZnU0T2NEdnAwTUtBWnZaMG9JSkNmQXdCT2k5RmlPeUFzODlVc1Fa?= =?utf-8?B?cVBaTHpoVStDVDg2S3p2Rks4R3VaaEYxV0pnSVRadk1ZNzNjQUpjRVowekNP?= =?utf-8?B?RTVzeW5ha3FnbnloNlp6WCtBMFU2c29rdFhZOEtrNnk5clRHNitHWmh3bjQ4?= =?utf-8?B?OWxxN2FxZlI5bi8ra1lBTnNScFdPWURPVzdlS0tJb3laUm8vR3ZrZnU0NldJ?= =?utf-8?B?ZzhPKzdpTWZLTm0rNk9va05NRkxSRW5wRVhaVkd3b1Z6cFBjdndmYVNLcmNx?= =?utf-8?B?RDZNZGJhTzlYRzdoaEZocmZiOUJWQzhXWGVQNkJhWkNndjFwdmRaS245aXNk?= =?utf-8?B?ZlR2MFBmVnBvUEtJa1NsaDBSbklaQXMyaHRHNHE0NEx6VlBQSDh2dlJQNVNL?= =?utf-8?B?RVBPam9LSi8yY3QyNGdLc2R2alpXVlZNWFVRcEpDZmc3cVBQb0oweUIxemZ3?= =?utf-8?B?WWVCc2xiamtpdkVpTjN4dlFUVmM2cHFpVzRsZFJqdHR2VVFtbE94bVBtanov?= =?utf-8?B?NUVNQ3A3bTB0VERSUEh4Z3BKRFMvMGNXWm9qQyt3VCtKdVY3MWd3bWlZYTU2?= =?utf-8?B?K0tYWEJHZGdYejRWS3EvL0VIZ2tLNkd2WHowcnc0MWZxdjhMU3FIbCtkNmd5?= =?utf-8?B?TzNWRzZVcDl3cHh5cmVNSWdqdmZ5TDVHMU1DY2dzKzl5bi9lcEtwdjVwUlRG?= =?utf-8?B?a0RxR2x2UERBMEQvRG0xc2VlR3lCUGtWTWhEZ1dad2RHb0JCckFJalhvam93?= =?utf-8?B?dDI1amU1SmJaVTV0Zi8veEozNlZ3LzVKRWZJVURuckI5VFJVK1RnS291RUk4?= =?utf-8?B?Mk4yMktSeXFaamJuNHlmZHpFUU1nK1VMR1FqeVljNDBlc1RScWVaMEZjWUtK?= =?utf-8?B?YlluSmlrQi9CbTFqWFZHSDA4U1NOdEh5WmxTYXBteXdkNTJvUVJsd05McWtG?= =?utf-8?B?YkRwV3MzRzNOY1I3TU53UXhHRit0NDgzRHAzZG04TUx6cUNLUzFlckNMYlY2?= =?utf-8?B?OGZyREMzRE1jYis0Vjc2S25WT2xoL3BraHUxanN4UTY2REVRbmRBRTQ1b3p6?= =?utf-8?B?Y090UWxKZkRueHpqbXAxZjF3VFNIMnpBZDRha05zRFVpb0lwazRSRlhHQUZx?= =?utf-8?B?NThNSVhmVTNHVGFmeU5BbzVQNWNmM2pYcG5Xc1pIL0ZIRS9oMnlkTTQ1TTRs?= =?utf-8?B?MXpkTVpOU1NTRGl4cy9UTWQwOG9nOXBMOE1XMXNIN0xRNCttRlBJaUFIUWZz?= =?utf-8?B?ckpPNUM2ZlAveDM4UUdGcXNCRGs3K2wrY3QweDhmWlZ4OE1qWTZuV3RBUWgy?= =?utf-8?B?dEhIaUMxL3dhN0NhZ3JSeXcyMmUxYStQVDNFdHp5RkVjVEptRlN5Vk9jQWJw?= =?utf-8?B?dXZtZ0FXN3EvYW5yVmRNZ1dUd3VJMXk3UEJYK2FNbEZWQWNZbUZlSk1Xd0E4?= =?utf-8?B?OVUzLzBlTVJTcWFkbCtwSVRWQnhDaElvYVdYbFhiUGtESHE1YXBzTUoxTm1l?= =?utf-8?B?Wkl6blNXZlNjdWdWWktvajZkT1VhdWtWVkhucG9PY096bTFlOWpFMHQweGRR?= =?utf-8?B?QWExZWZFeE9CMno5TXZLRFZUWHNoTHNFYmZDRlhtelRJdmdsdHUyMXhXeTQv?= =?utf-8?B?dzZERGx6aGltbFhYa3l6YmdxRGZLMWxJeDFDRWZmaWFjU2loUUtJakVMZHFF?= =?utf-8?B?OFMzTVgvbDk2eDRMK3duNnJGTitJSGR5VmxlaDlPUGdjZWVQOFR6UEhMSEN1?= =?utf-8?B?MU56a3AxUzg3Q2VGa2ZRamJGeFhpOUwzRGhySnFVN0ZtaEpFTXRWYUpDb3lD?= =?utf-8?B?dEhadjE0L1lqeW1XY1NHTHE4cG5xVkljcUVFRGRXbGFFU0J4UzJ6dzNLQlI0?= =?utf-8?B?VmZSV0RFRTBDR2NISm1ZSnZkT1RjNC9MTEtQVnkxVURLTEVCTnoxZVRYbHcz?= =?utf-8?B?TWF0M0JvdkMyVHNVd25mcWNITWJoeXVBTE1IRGMzQ213MDAvNXhCMVR5M3FM?= =?utf-8?B?VDJTS2k5d1lways5NlU2SlVFR1JvVURqeHZlOFdzYVJLdTZXTDdVdC9HNUpP?= =?utf-8?Q?G03iEEONPXFON2PsGwZIUsmbx?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef932c52-4e42-470d-dce0-08dbf72c80fc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 13:57:51.9743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iJufleiwMd4SsUTwP5lc050Nqlwk/4JoAfEoqXotXcsmNSAMVSo2b9iTl/gl3bDF X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7954 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/7/2023 1:42 AM, Jie Hai wrote: > Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional stdatomic API. > > Signed-off-by: Jie Hai > <...> > diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c > index b8f7e408d1e0..457247609811 100644 > --- a/drivers/net/hns3/hns3_ethdev.c > +++ b/drivers/net/hns3/hns3_ethdev.c > @@ -99,7 +99,7 @@ static const struct rte_eth_fec_capa speed_fec_capa_tbl[] = { > }; > > static enum hns3_reset_level hns3_get_reset_level(struct hns3_adapter *hns, > - uint64_t *levels); > + RTE_ATOMIC(uint64_t *)levels); > I don't know if is there a defined syntax, but I think better to use macro for pointers as "RTE_ATOMIC(uint64_t) *levels", because of same reason to use "int *a", following usage can be confusing: "RTE_ATOMIC(uint64_t *) level1, level2;"