From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 984C53989 for ; Fri, 22 Jul 2016 10:04:15 +0200 (CEST) Received: by mail-lf0-f46.google.com with SMTP id l69so79359514lfg.1 for ; Fri, 22 Jul 2016 01:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=sNqs3j0ujYM2hzasIR/WCvuq0m4DY4QxzGqcVp/WjR0=; b=ZMGL/smnqjCbhMvhB56f3Gum/EDAFnTeCu136YZzpTwnDdQlbYHYMsBgGSSXeCEu7Q qq10unNB08cE5gFFRrFueCxCHlc6ftn92UsC+FOjm7ijcbOdrlZPTFzE/SSKvUyUa1C2 nN7h5icyj+3bfJAPXft4nYQVyDXI0O3wLHAEwKzR42e4A+Ng4Cuo23aoidEVFeXLfPeV gyO2lIZ0COqlUNxJ1kxk7mFDwWpftfkptCW4FEKSI7s4RVn0xw7eTvYVDgU3+KQARsSB 5bwyGfTRQrgkSumYJTN9gXpDhuKKJJC0B67WPqEwwzxANkjWGcRXMJtGtT+3rHTIUg7j nNMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=sNqs3j0ujYM2hzasIR/WCvuq0m4DY4QxzGqcVp/WjR0=; b=NNQnDcsOlODoSlnHoSY8gWocKCyLYWYptLpvth5dLiqW+Lo6rp7KPvNM9Rox7qEYTk HKCgLWwVN09IkKffgMsH91wR6y0F75mN/45GfB8D7scP1HiRbseakyQkQVhSzHm15twn vlhx67BhKK8up3FfRZPW9nPJh/rNjm/aDjFuhC0FCkNrPQWMU/oi3hhVaG1XhiUGvuVK 3ZOhMQZxgMY3Gbwz8geJ3qxXvq0Z9EUomzhQJUJjWzIqYRS7XvgniASIwGbdWmoQ+Li+ 7piw/uwVIkYGW0sUoGUGxDHYGX7pqD32pxFvd7WXG3tOWOmEleEJzPGEZvwLyHp7dsWi PM2A== X-Gm-Message-State: AEkoouuJDBvCvO8OC/BcJMAbhyK1O6qbdiKKvIYseBC5jRhqpTA6kCh5QBdNuTGTmTClSLqF X-Received: by 10.46.32.203 with SMTP id g72mr1885858lji.30.1469174655243; Fri, 22 Jul 2016 01:04:15 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id h68sm2677875ljh.38.2016.07.22.01.04.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2016 01:04:14 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org, Christian Ehrhardt Date: Fri, 22 Jul 2016 10:04:13 +0200 Message-ID: <2761669.Unk5LuuApo@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160722014657.GM28708@yliu-dev.sh.intel.com> References: <1469024670-4638-1-git-send-email-thomas.monjalon@6wind.com> <20160722014657.GM28708@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] unify tools naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 08:04:15 -0000 2016-07-22 09:46, Yuanhan Liu: > On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote: > > The following tools may be installed system-wise. > > Yes, indeed. Following is an example from dpdk package shipped in > ubutun 16.04: > > dpdk: /etc/dpdk/dpdk.conf > dpdk: /etc/dpdk/interfaces > dpdk: /etc/init.d/dpdk > dpdk: /lib/dpdk/dpdk-init > dpdk: /lib/systemd/system/dpdk.service > dpdk: /sbin/dpdk_nic_bind > dpdk: /usr/bin/dpdk_proc_info > dpdk: /usr/bin/testpmd > dpdk: /usr/share/doc/dpdk/changelog.Debian.gz > dpdk: /usr/share/doc/dpdk/copyright > dpdk: /usr/share/dpdk/tools/cpu_layout.py > dpdk: /usr/share/dpdk/tools/dpdk_nic_bind.py > dpdk: /usr/share/dpdk/tools/setup.sh > > > It may be cleaner and more convenient to find them with the same > > dpdk- prefix (especially for autocompletion). > > Agreed. > > > Moreover, the script dpdk_nic_bind.py deserves a new name because it is > > not restricted to NICs and can be used for e.g. crypto. > > Second that. But we might need doc the name change to let user aware of > that. There is a note in API changes section. And every references in the doc are renamed. > > These files are renamed: > > pmdinfogen -> dpdk-pmdinfogen > > pmdinfo.py -> dpdk-pmdinfo.py > > dpdk_pdump -> dpdk-pdump > > dpdk_proc_info -> dpdk-procinfo > > dpdk_nic_bind.py -> dpdk-devbind.py > > setup.sh -> dpdk-setup.sh > > > > The tools pmdinfogen, pmdinfo.py and dpdk_pdump are new in 16.07. > > > > The scripts dpdk_nic_bind.py and setup.sh may have been used with > > previous releases by end users. That's why a symbolic link still > > provide the old name in the installed tools directory. > > I was about suggesting the same thing: yes, we should keep the > backward compatibility. Does it mean you ack this patch?