From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8574A2C18; Fri, 28 Apr 2017 11:21:54 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 02:21:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="254542208" Received: from dwdohert-mobl1.ger.corp.intel.com (HELO [163.33.228.249]) ([163.33.228.249]) by fmsmga004.fm.intel.com with ESMTP; 28 Apr 2017 02:21:50 -0700 To: "Trahe, Fiona" , "dev@dpdk.org" References: <1493139391-9356-1-git-send-email-fiona.trahe@intel.com> Cc: "De Lara Guarch, Pablo" , "stable@dpdk.org" From: Declan Doherty Message-ID: <2761b670-22c5-0eda-fe08-7869ba5973d2@intel.com> Date: Fri, 28 Apr 2017 10:21:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1493139391-9356-1-git-send-email-fiona.trahe@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 09:21:55 -0000 On 25/04/2017 5:56 PM, Trahe, Fiona wrote: > Fix misleading comments clarifying setting of digest length. > > Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") > > Cc: stable@dpdk.org > Signed-off-by: Fiona Trahe > --- > lib/librte_cryptodev/rte_crypto_sym.h | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h > index eb7b530..12f1583 100644 > --- a/lib/librte_cryptodev/rte_crypto_sym.h > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > @@ -310,11 +310,10 @@ struct rte_crypto_auth_xform { > * this specifies the length of the digest to be compared for the > * session. > * > + * It is the caller's responsibility to ensure that the > + * digest length is compliant with the hash algorithm being used. > * If the value is less than the maximum length allowed by the hash, > - * the result shall be truncated. If the value is greater than the > - * maximum length allowed by the hash then an error will be generated > - * by *rte_cryptodev_sym_session_create* or by the > - * *rte_cryptodev_sym_enqueue_burst* if using session-less APIs. > + * the result shall be truncated. > */ I don't think this comment change is valid, we already validate many of the parameters which are passed into session creation, such as key lengths etc, if we are not validating digest length now I think we should be, maybe this is a gap in our unit tests. > > uint32_t add_auth_data_length; > @@ -597,7 +596,9 @@ struct rte_crypto_sym_op { > phys_addr_t phys_addr; > /**< Physical address of digest */ > uint16_t length; > - /**< Length of digest */ > + /**< Length of digest. This must be the same value as > + * @ref rte_crypto_auth_xform.digest_length. > + */ > } digest; /**< Digest parameters */ > > struct { >