From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0067.outbound.protection.outlook.com [104.47.1.67]) by dpdk.org (Postfix) with ESMTP id 5747E2BE6; Thu, 2 Aug 2018 23:03:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aymiywWpTribT84qL5uRJo7KREytmPWa1uw6zT0Fs+E=; b=G7k12D3yDo6pAPBSCD00vIMlYZWwzVZujK6vKJNedyUGGq/HiIcKUmT/q7i8Q+hs8JpDauThln7arMgTqLVpkMvx7nhhWvMWGjD6y0HxGhx+LvgbfYA7jQYMTF2WJQac18c4hnbktfiUB8PM9+JfdKvqQURc+x8hOV6fEfWPa6w= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2831.eurprd05.prod.outlook.com (10.172.11.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19; Thu, 2 Aug 2018 21:03:26 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175%2]) with mapi id 15.20.1017.010; Thu, 2 Aug 2018 21:03:26 +0000 From: Yongseok Koh To: Shahaf Shuler CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] net/mlx5: preserve promisc flag for flow isolation mode Thread-Index: AQHUKqObypWNKDjHDUa2FfQCONsRhaSs8zqA Date: Thu, 2 Aug 2018 21:03:26 +0000 Message-ID: <27632A0F-3B0D-4ECD-8FAF-188ED9BBAEA4@mellanox.com> References: <20180802205834.10491-1-yskoh@mellanox.com> In-Reply-To: <20180802205834.10491-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2831; 6:OYkbcTtZxyrksUXh2dsDC072h2g9iOWVR+oCSPtytabaLD7TSeWC4JiuAcpbXvpn9KDhsmrrL37FgMB57uzXdJ4cLAQgZbaknTolsX0DB2wsLIMai/RCk3K5oi0TF9sW/auze/IzAzxFC364njvwu/TpjLrDQaf44aytd4+DvWbTpnk7Zv+1+YBPAXO6yVAMEor6iXH72vpIBP1GoQ7Stq7DPbAJHnSDKWAHrQn/TAc3z4XLyiP9nE6ZR9jsq3cLaZM+uaJOyheu45YtVILTJc/e8C+FM2G127y2QhBDEeL+CmNW0GBADgRJN83lWpG00j/RT4BrPJ8pugs4Q9dTXC3teGfYiztvLALzS3eMWPnqifrU37IEe7YdVoEfMjzL2irEXY7LwQ1HpPIPotvmMepJByXihKMvRCIz5u6tR6jyf5Sz0e51H/ffsIqgYRffyFa3P3EIrr/TvtYJW5GbjA==; 5:vecw9R3RQqx3t8mfylr8CzSN99spxMxckl/K8zyin6mqwbdWgWK52N7B/rpNdyt1QXh4whhvCyU36aOxhaHKJ/SnYY5HC20+yqJYQ1FLJ15oIG8aOIzjWPRYBSvqoQkngbLMwxMysrzhOgOzHOKxDv/Jt5y8SVXR400txwLYsGQ=; 7:4cwzAXDEPcpxOOLYukLfhb0p2VWqusLGIwHJX+fsFlafkaq42CFZGMx46tRV/wYt+7sHZchWfbwMaXTSRWbUG1V1z1F0FooWgDj3pTyI0+TmrlaRzGGH/gVJWfjj1GoaNpbgdWtTCfT1buN/03vhxW7P81VrZ4M3Q/Yv6a53tf/QWetjDuPuvmxM0M23ZQTaZr5jRBbIdaFRJ28/IZlBcCQ3Ufg4w+T5jpYxeMlZnLTzqki/OkXJoZc0dKhEsp6r x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2f7b6f2f-dc10-48c0-c157-08d5f8bb6401 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2831; x-ms-traffictypediagnostic: VI1PR0501MB2831: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2831; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2831; x-forefront-prvs: 07521929C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(396003)(376002)(366004)(39860400002)(189003)(199004)(2900100001)(4326008)(36756003)(83716003)(6436002)(486006)(5250100002)(6512007)(33656002)(450100002)(476003)(6486002)(66066001)(2616005)(99286004)(256004)(11346002)(446003)(25786009)(76176011)(478600001)(6862004)(14454004)(6116002)(7736002)(53936002)(26005)(305945005)(316002)(97736004)(37006003)(53546011)(81156014)(54906003)(8936002)(86362001)(8676002)(5660300001)(81166006)(6246003)(3846002)(106356001)(102836004)(68736007)(2906002)(229853002)(6636002)(82746002)(6506007)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2831; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: FwM/5FBPZFp1EuzT+B8x/ON1TkvYQ+3WEu5RVLjYaOwVrT2k1R7HgtDUAnHizmR/FgJbjDyoP8zPO/o4gD0Pc2bVLpQ43yuyuYf9HP8f5k76c9MofrwjYBk0yFOuRgPaJRxl6Qux5CuiIKpiaqbrJE1E9DazNZJrrskG5VF6tbU/f1qXjscbKldKztBnrOYmJzm9FiIDavgo/PYWCxO9WqcaH8D6e8DDP9h5bxsp0lUuiVoIlv9tOx7s9bd/WiN/SLMlKvqmMGrLTVmSPhJTtrrInxqHF9DrYodQBNn5d5RpUFdTjXUzHHh0RyWqlSDm4DEU68BIBq3/3i3uD9Cj2e8Y3TMSyhVBDQ8ookOFyvY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <855A19F5BFE6FD4AAB85FEBF4337C96A@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f7b6f2f-dc10-48c0-c157-08d5f8bb6401 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2018 21:03:26.1551 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2831 Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: preserve promisc flag for flow isolation mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 21:03:27 -0000 > On Aug 2, 2018, at 1:58 PM, Yongseok Koh wrote: >=20 > mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling promiscuous > mode as it can't be enabled in flow isolation mode. If the function > pointers are null, librte APIs such as rte_eth_promiscuous_enable/disable= () > fail to set the flag (dev->data->promiscuous). The flag is used when > starting traffic by mlx5_traffic_enable(). When switching out of flow > isolation mode, promiscuous mode will not be set even though it has been > enabled. >=20 > Fixes: 0887aa7f27f3 ("net/mlx5: add new operations for isolated mode") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh Please disregard this patches. I should've tagged it as v2. Sorry for the mess. Thanks, Yongseok