* [dpdk-dev] [PATCH] kni: fix missing backslash in Makefile
@ 2014-08-01 16:56 Julien Cretin
2014-08-01 19:28 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Julien Cretin @ 2014-08-01 16:56 UTC (permalink / raw)
To: dev
With GNU Make 3.81 on Ubuntu 14.04, I get:
lib/librte_eal/linuxapp/kni/Makefile:49: *** unterminated call to function `shell': missing `)'. Stop.
Signed-off-by: Julien Cretin <julien.cretin@trust-in-soft.com>
---
lib/librte_eal/linuxapp/kni/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/kni/Makefile b/lib/librte_eal/linuxapp/kni/Makefile
index 4b5d873..2799191 100644
--- a/lib/librte_eal/linuxapp/kni/Makefile
+++ b/lib/librte_eal/linuxapp/kni/Makefile
@@ -46,7 +46,7 @@ MODULE_CFLAGS += -Wall -Werror
ifeq ($(shell lsb_release -si 2>/dev/null),Ubuntu)
MODULE_CFLAGS += -DUBUNTU_RELEASE_CODE=$(shell lsb_release -sr | tr -d .)
-UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature |
+UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature | \
cut -d- -f1,2 | tr .- $(comma))
MODULE_CFLAGS += -D"UBUNTU_KERNEL_CODE=UBUNTU_KERNEL_VERSION($(UBUNTU_KERNEL_CODE))"
endif
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] kni: fix missing backslash in Makefile
2014-08-01 16:56 [dpdk-dev] [PATCH] kni: fix missing backslash in Makefile Julien Cretin
@ 2014-08-01 19:28 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2014-08-01 19:28 UTC (permalink / raw)
To: Julien Cretin; +Cc: dev
Hi Julien,
2014-08-01 18:56, Julien Cretin:
> With GNU Make 3.81 on Ubuntu 14.04, I get:
> lib/librte_eal/linuxapp/kni/Makefile:49: *** unterminated call to function `shell': missing `)'. Stop.
>
> Signed-off-by: Julien Cretin <julien.cretin@trust-in-soft.com>
> -UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature |
> +UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature | \
> cut -d- -f1,2 | tr .- $(comma))
My fault, I forgot the backslash when splitting line.
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied.
Thanks for the quick test and report.
--
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-01 19:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-01 16:56 [dpdk-dev] [PATCH] kni: fix missing backslash in Makefile Julien Cretin
2014-08-01 19:28 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).