From: Thomas Monjalon <thomas@monjalon.net>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: dev@dpdk.org, stable@dpdk.org, zaiyuwang@trustnetic.com,
'Stephen Hemminger' <stephen@networkplumber.org>
Subject: Re: [PATCH 08/19] net/txgbe: add device arguments for FDIR
Date: Tue, 11 Nov 2025 04:30:36 +0100 [thread overview]
Message-ID: <2766798.62m94kTkzf@thomas> (raw)
In-Reply-To: <006c01dc52ad$be5c92b0$3b15b810$@trustnetic.com>
11/11/2025 02:51, Jiawen Wu:
> > > > Since FDIR configuration is deprecated in generic ethdev device
> > > > configuration and move it into the device private data, there is no way
> > > > to configure the FDIR parameters.
> > > >
> > > > Two device arguments "pkt-filter-size" and "pkt-filter-drop-queue" are
> > > > added, they just continue to use the previous naming convention.
> > > >
> > > > Fixes: 5007ac13189d ("ethdev: remove deprecated Flow Director configuration")
> > > > Cc: stable@dpdk.org
> > > > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> > > > ---
> > > > drivers/net/txgbe/base/txgbe_type.h | 4 ++++
> > > > drivers/net/txgbe/txgbe_ethdev.c | 20 ++++++++++++++++++--
> > > > 2 files changed, 22 insertions(+), 2 deletions(-)
> > >
> > > You forgot to update the documentation.
> >
> > I'll add it in v2 set, thanks.
>
> Set v1 has been merged, I'll separately provide a patch for it.
conclusion for future patches: don't wait for adding doc ;)
next prev parent reply other threads:[~2025-11-11 3:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 3:15 [PATCH 00/19] Wangxun Fixes Jiawen Wu
2025-10-27 3:15 ` [PATCH 01/19] net/txgbe: fix hardware statistic rx_l3_l4_xsum_error Jiawen Wu
2025-10-27 3:15 ` [PATCH 02/19] net/ngbe: " Jiawen Wu
2025-10-27 3:15 ` [PATCH 03/19] net/txgbe: reduce memory size of ring descriptors Jiawen Wu
2025-10-27 3:15 ` [PATCH 04/19] net/ngbe: " Jiawen Wu
2025-10-27 3:15 ` [PATCH 05/19] net/txgbe: fix VF Rx buffer size in config register Jiawen Wu
2025-10-27 3:15 ` [PATCH 06/19] net/ngbe: " Jiawen Wu
2025-10-27 3:15 ` [PATCH 07/19] net/txgbe: remove duplicate txq assignment Jiawen Wu
2025-10-27 3:15 ` [PATCH 08/19] net/txgbe: add device arguments for FDIR Jiawen Wu
2025-11-10 9:29 ` Thomas Monjalon
2025-11-11 1:46 ` Jiawen Wu
2025-11-11 1:51 ` Jiawen Wu
2025-11-11 3:30 ` Thomas Monjalon [this message]
2025-10-27 3:15 ` [PATCH 09/19] net/txgbe: fix the maxinum number of FDIR filter Jiawen Wu
2025-10-27 3:15 ` [PATCH 10/19] net/txgbe: fix FDIR mode is not be cleared Jiawen Wu
2025-10-27 3:15 ` [PATCH 11/19] net/txgbe: fix FDIR drop action for L4 match packets Jiawen Wu
2025-10-27 3:15 ` [PATCH 12/19] net/txgbe: fix to create FDIR filter for tunnel SCTP packet Jiawen Wu
2025-10-27 3:15 ` [PATCH 13/19] net/txgbe: filter FDIR match flex bytes for tunnel packets Jiawen Wu
2025-10-27 3:15 ` [PATCH 14/19] net/txgbe: fix FDIR rule raw relative for L3 packets Jiawen Wu
2025-10-27 3:15 ` [PATCH 15/19] net/txgbe: fix FDIR input mask Jiawen Wu
2025-10-27 3:15 ` [PATCH 16/19] net/txgbe: switch to use FDIR when ntuple filter is full Jiawen Wu
2025-10-27 3:15 ` [PATCH 17/19] net/txgbe: fix VF-PF message for ntuple flow filter Jiawen Wu
2025-10-27 3:15 ` [PATCH 18/19] net/txgbe: switch to use FDIR on VF Jiawen Wu
2025-10-27 3:15 ` [PATCH 19/19] net/txgbe: remove unsupported flow action mark Jiawen Wu
2025-10-27 16:51 ` [PATCH 00/19] Wangxun Fixes Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2766798.62m94kTkzf@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).