From: Thomas Monjalon <thomas@monjalon.net>
To: Rongwei Liu <rongweil@nvidia.com>, rasland@nvidia.com
Cc: dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com,
orika@nvidia.com, Maayan Kashani <mkashani@nvidia.com>
Subject: Re: [PATCH v1] net/mlx5: add test for hot upgrade
Date: Mon, 26 Jun 2023 22:22:32 +0200 [thread overview]
Message-ID: <27670733.gRfpFWEtPU@thomas> (raw)
In-Reply-To: <20230516054137.1396922-1-rongweil@nvidia.com>
16/05/2023 07:41, Rongwei Liu:
> This patch adds testpmd app a runtime function to test the hot
> upgrade API.
>
> testpmd> mlx5 set flow_engine <0|1> (flag)
> 0 stands for active mode while 1 for standby mode.
>
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -2057,3 +2057,13 @@ where:
> * ``sw_queue_id``: queue index in range [64536, 65535].
> This range is the highest 1000 numbers.
> * ``hw_queue_id``: queue index given by HW in queue creation.
> +
> +Set Flow Engine Mode
> +^^^^^^^^^^^^^^^^^^^^
The title is made as a sub-section of "port map external Rx queue",
which looks wrong.
> +
> +Set the flow engine to active(0) or standby(1) mode with specific flags::
> + testpmd> mlx5 set flow_engine <0|1> (flags)
It should be said it is for testing live migration.
Also the flags are not described. Should we pass an integer?
> +
> +This command works for software steering only.
> +Default FDB jump should be disabled if switchdev is enabled.
> +The mode will propagate to all the probed ports.
For the reasons above, I prefer not pulling this patch in the main branch.
next prev parent reply other threads:[~2023-06-26 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 5:41 Rongwei Liu
2023-06-19 12:09 ` Raslan Darawsheh
2023-06-26 20:22 ` Thomas Monjalon [this message]
2023-09-18 12:17 ` Rongwei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27670733.gRfpFWEtPU@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).