From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C460E42D60; Mon, 26 Jun 2023 22:22:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45BD940223; Mon, 26 Jun 2023 22:22:40 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 7FF2F4013F for ; Mon, 26 Jun 2023 22:22:38 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id B87C4320095E; Mon, 26 Jun 2023 16:22:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 26 Jun 2023 16:22:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687810956; x=1687897356; bh=HDp3z1z7ih7NDKQ3dlcjQziGuIJd3h9DRke +csGDxgU=; b=tORFESoYea0OIoxYbE6AbJHdMMr9TCKy3jXZAPCB9CnL9Tx/16Y tY3Me/ztEZNikFGgDF2lvw6GrVU0Yxge5L9mvH3XPmQ+CGUqCKKmXZY5H0V0VDZ7 HPsjDPS1ydm/PBU96CuZ77Pp9fI4lUtzE3Ftbnb2tyl7sNXqzAYIoZ/SLvyvRg46 PJkWPPjoKkg8DpYfGA4aQ7KUgvXAeUyexQHpk4gMJTL5Ua79njQ1m61ybpw9UgnA dCWzhSw8xXvmfgnENzp+LkjlTFeemfDd3iB0K204ZnylS4mmaL34RmU4TJN3xBI1 GhdUQI+TWO48B6v+WXjmRpYCmFOOZVpB42g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687810956; x=1687897356; bh=HDp3z1z7ih7NDKQ3dlcjQziGuIJd3h9DRke +csGDxgU=; b=UaPNP9CvjUFnStAQriplAzpU2DfahfLi+tj6pxeg5fsOX9aICWN m0XYASdwVrU301idYDrNxHzJ03uqyclSQNvVolOWVO9+HmMVyGAATfYVURWFwiDD aHTCgxcbliWBEWq4fw3K9Vi50G28mGCOzZoHmBZlnG/JgmrlHRafqFdh4Q39uZ7I ksq8fJitm0inJ1FHGAqC1Cf6tGFd9wbcIC3oq/UXz0L/WHZ9eJMJ+WCbc5WXJHxk Umv/Lv9bzQE+gRV57DBN8mTVYtg4S8zHpFGjI4h3AjoYXb/3xqIoLisyhzPOPHhD SpFiwdwnIqFVJlpqBsjrgRDMR+zEVqkDHxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Jun 2023 16:22:34 -0400 (EDT) From: Thomas Monjalon To: Rongwei Liu , rasland@nvidia.com Cc: dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, Maayan Kashani Subject: Re: [PATCH v1] net/mlx5: add test for hot upgrade Date: Mon, 26 Jun 2023 22:22:32 +0200 Message-ID: <27670733.gRfpFWEtPU@thomas> In-Reply-To: <20230516054137.1396922-1-rongweil@nvidia.com> References: <20230516054137.1396922-1-rongweil@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/05/2023 07:41, Rongwei Liu: > This patch adds testpmd app a runtime function to test the hot > upgrade API. > > testpmd> mlx5 set flow_engine <0|1> (flag) > 0 stands for active mode while 1 for standby mode. > > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko > --- > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -2057,3 +2057,13 @@ where: > * ``sw_queue_id``: queue index in range [64536, 65535]. > This range is the highest 1000 numbers. > * ``hw_queue_id``: queue index given by HW in queue creation. > + > +Set Flow Engine Mode > +^^^^^^^^^^^^^^^^^^^^ The title is made as a sub-section of "port map external Rx queue", which looks wrong. > + > +Set the flow engine to active(0) or standby(1) mode with specific flags:: > + testpmd> mlx5 set flow_engine <0|1> (flags) It should be said it is for testing live migration. Also the flags are not described. Should we pass an integer? > + > +This command works for software steering only. > +Default FDB jump should be disabled if switchdev is enabled. > +The mode will propagate to all the probed ports. For the reasons above, I prefer not pulling this patch in the main branch.