From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id D60BA47CD for ; Thu, 7 Jul 2016 18:21:50 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id z126so155046993wme.0 for ; Thu, 07 Jul 2016 09:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=m3NYPkAcl4Ar+2ZQW+bh0qm6ktIG8J0FrFc9VtcjrnQ=; b=1W28ENi0UfRdxAwlm2M4o+6A+dxbn9k7jdqTXQIgE8t8wDakpxxgYx1Ny1fLYJMAuH 3DQCH96bBScOz7P2GW9+P3UtdPnb8vOEMlxrqeGvYPBxcdZvjlTuLTjPkgDhoTiG3V6Y 0+ukJ8A/ELP1F0cVxqy07zJB9boOwB5cJIJXCSeoxHtS4DjNh4a9/rvjwRd8s8+2NXZa PTPOE/HGLAAehO9dv/uj6EXiLSz+OowG3YZMXAcg28AonSIueLxuBypvYtlyGWnkTUG4 2zqC430IJeebLBTE0Z6uH6aEUZKmOaRHrTMPDA6bKHwFDNlHkOcG9T4nebyz3E6ZfGwL b2ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=m3NYPkAcl4Ar+2ZQW+bh0qm6ktIG8J0FrFc9VtcjrnQ=; b=GOUWNXoIWse8VSuP/GtgQZf2hDenV/fiYMDIphqnnQ5t5vX3Ke/aLSqLzog4V5IFaw JDd+kCzS4UWKvzaAH+3Dt2T236/TmuEjQ4YyFNwZBDXug+Vu2RwzjBH5LEcCSYv6eeKS c84t1UBxbAMZ3uWCnBSt3n3Gk4fEQGpYx2Usa/jvpWghBsIaDABz5DZGvXek+TMH9LZ/ QPgkT/Ve9lQfeUhjaYGPeeaZVcTlObR6EKMf8p7TvaY4LNQIJzywSvQsWWoLclpN1kxX +XY5cHLVE+GTwNMS2Gi+NJ02xfFWf8codVEuoIO9UewFTitjqKobdIClKVgDKjjd7j/j 4D/A== X-Gm-Message-State: ALyK8tIrKeDOl4xMlifTbi8F1DGdNvzf0IuypvqXGirXqdq5OyX6Ca+TLj+P5zVKOQ0d/qRC X-Received: by 10.194.150.167 with SMTP id uj7mr977167wjb.168.1467908510683; Thu, 07 Jul 2016 09:21:50 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id s3sm4169453wjy.44.2016.07.07.09.21.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jul 2016 09:21:50 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org Date: Thu, 07 Jul 2016 18:21:49 +0200 Message-ID: <2767602.pXmPdzu3XJ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160707155655.GD26064@hmsreliant.think-freely.org> References: <1467905790-10597-1-git-send-email-thomas.monjalon@6wind.com> <1467905790-10597-4-git-send-email-thomas.monjalon@6wind.com> <20160707155655.GD26064@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 03/11] mk: fix build dependency of drivers on pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2016 16:21:51 -0000 2016-07-07 11:56, Neil Horman: > On Thu, Jul 07, 2016 at 05:36:22PM +0200, Thomas Monjalon wrote: > > When compiling the drivers, some code is generated with pmdinfogen. > > A fresh parallel build can fail if a driver is compiled before pmdinfogen: > > build/buildtools/dpdk-pmdinfogen: Permission denied > > > > There was a dependency declared in drivers/Makefile but it cannot work > > because this file is based on mk/rte.subdir.mk which do not handle > > dependencies. > > > > It is fixed by declaring the whole buildtools as (order only) prerequisite > > of drivers. [...] > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -34,6 +34,4 @@ include $(RTE_SDK)/mk/rte.vars.mk > > DIRS-y += net > > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto > > > > -DEPDIRS-y += buildtools/pmdinfo > > - > > include $(RTE_SDK)/mk/rte.subdir.mk > > diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk > > index fb68af2..354f006 100644 > > --- a/mk/rte.sdkbuild.mk > > +++ b/mk/rte.sdkbuild.mk > > @@ -49,6 +49,7 @@ $(1): $(sort $(LOCAL_DEPDIRS-$(1))) > > endef > > > > $(foreach d,$(ROOTDIRS-y),$(eval $(call depdirs_rule,$(d)))) > > +drivers: | buildtools > > > I'm not sure i understand the reasoning here, DEPDIRS is meant to declare > prerequisites to a directory (and its children) getting built, right? A > parallel make should block any drivers getting built prior to pmdinfogen getting > built. What am I missing? DEPDIRS-y is not parsed at all in the context of rte.subdir.mk. That's why this line was ignored by the build system.