From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0059.outbound.protection.outlook.com [104.47.0.59]) by dpdk.org (Postfix) with ESMTP id 5B95E1B2BD for ; Tue, 13 Feb 2018 05:56:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AjR74Vno6dIM7hTV/gGnGWvBNZzm/0c3ep2J2PIwFuI=; b=QWQOgKiY/V8805JiXXOshgjPKg7JYvEk4I6A5XFjsC+f8pfz3B5N3OMUlBMGObj2gVfuueAkJNYVr7p/cmE/Ta3Jw3lxHEsJmOVkM61lzpYH2Alpl6x1i1Ovopb1VSK6wpDnXEy278JIpyZlQxGBNM8pgSkaESb2t4rvdWBCxic= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from [192.168.1.3] (122.180.38.90) by AM2PR04MB0756.eurprd04.prod.outlook.com (2a01:111:e400:8411::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Tue, 13 Feb 2018 04:56:33 +0000 From: Hemant Agrawal To: Pavan Nikhilesh , ferruh.yigit@intel.com, cristian.dumitrescu@intel.com, harry.van.haaren@intel.com, nhorman@tuxdriver.com, jerin.jacob@caviumnetworks.com, thomas.monjalon@6wind.com Cc: dev@dpdk.org References: <20180212142305.18557-1-pbhagavatula@caviumnetworks.com> <77d5c43b-54c1-6f66-d9c3-103d56473def@nxp.com> Message-ID: <276f24c4-aa2a-bd6e-d854-10e0e3cd89b9@nxp.com> Date: Tue, 13 Feb 2018 10:26:20 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <77d5c43b-54c1-6f66-d9c3-103d56473def@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [122.180.38.90] X-ClientProxiedBy: BM1PR0101CA0023.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::33) To AM2PR04MB0756.eurprd04.prod.outlook.com (2a01:111:e400:8411::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 185192d5-54c2-4fcd-0fbe-08d5729e28da X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0756; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756; 3:BarY1SHs40DB/HPg6nY8MK0H2IrLbELDpDglTxeDJRo23aOP2V0G8NLvYyhJL6tU3rzgXJ9wKdnJOj0GuF+IATDxDDE5ZEjOa5SkDfdIPnfvPFyJxKt7Po4XLa2/oQdnpIok+NwP0I2lsVP8e4+VPPlKvsoZzFguLcAXmErK6WwE4299O07LTiPDKkBOUpXNz59cf00w6BeCLAinTPaZOOUYgpWWTNQBySnOMaKqNzZ+KhnWgp4Lp0j9IoNwgHtK; 25:XMDVACTFXPPlpH4SPkGnJkDMEjVsjvm6QMm4dfTt5BRaSQvWkzl00fvoVeQVmRZinvb+PTNm2VxECxfde5iLq2v8BbzuXtGuaR0D85RwyrdlQFJ0Q5Qejib9EWarHtjTsdkoqepsfT6N4XJVvRZyMAJEKVQe+l6ecS/r/D5kPEPQv1TOcHU04/3e0XEu+EEjjWsRDeSCQzBg7xjpxGsERbwg2HcThoFbP0vQxNoYkcq1qezkXCzWZ8+xu7Mbqet/mlcOzIgZe474RTxlAYb4m5PcTtTxpOVutgETLLzmplkoiaFo4ie1272BGplLpYgYQOFUq5lKvDbEkXjB7fV56w==; 31:JkkAXispVCK895VdB4HoQ/VpKOQ4ucJC5/JQWvrlIzSb8iGXFCe2cXRnN7FmrohJDBLSigsnXOqac8/+2lW7YAbGG4MO5AY0Tn9JllqFxsNie2sZK+l0EZhGiJZQHCsEtueyBcXk75ctObIadCvp53ZKX+9zjtmgtCOFd6me+wID9LBtffF6hZxSfLoiiKd+B/D+V/kvkMpgdq9cCsuxh/emYF9qr6c7U1A7NODlJNY= X-MS-TrafficTypeDiagnostic: AM2PR04MB0756: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756; 20:0Ts7bRMcsSEEq3G3KYqPo33fxNbE4YR1QO+GCW7VyC++G5rafgGMVwHBSaNexIsErLacDlYpb2PA9waD5g0QSl8Ia6tnm/kHWkY9Zt/6h3Ulir6Kf3NmYqbsAwdgyj7A4RcrqJwRuUlis2gpwKmDO3Ey6kvy6hxDW8h+8uV2e6w2RFcRWXhIl4TQ8K0j0eqjBeMuUxtBt9SG7zfm6sifvMoBS5cpazjlqN8XNAfuvNnxOd+lqU5Hk/wuIC+entj0CET5HybulPEelf4Slrr0hzhm3bnoIdNyU6fj/1uzgoW88txt8j4gf8ERXceNFFi5ElmSPuo9Lbr4O7JBQs3WGRhLgSvcOlN0g3Qpzrjhj8EfSB1YFcXU8xhsAoTDsk1np/DV8FJGQg0xpIdV2DoKLPwfWYab6VxgN3HqiN/vMz13EDCFxo0U4RSTDMniGyTaLMEhcqpYje8NkW6sy/lGp8EymhRDBZKVbQaF/l54jkb/Kj2UVZxeKoIBzAhSjrc7; 4:nENffANcZpfa+EygxSaKlaDYNhA2C2jt9CGY4L5EAqgH8b3Kk8vttuApbb8ulOHxj18IdDSfSoM4r8cWTRDPErbyH2Cc96aCE6DKTkK7Me8yqM6+TZJGYox9FjsZZEUdv6/+jtUaQ8+QbSYOvUwkc+xkne7vEQ528qPhavz/Mvvn+0di2KHNQRwAdT9XsrHDZ4N5Zz8lLhdGSpQgptjJ9PWS8ersgDZHm7/UNtQHNjeZVOyauORm7Yj07wgNubChp7x2CAza+QiLGKoKoNC9e4ITM4KGTMsgoEuLX0lI2D9GZPu/tRKA5GjZt7pw+5QI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(3231101)(944501161)(10201501046)(93006095)(93001095)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:AM2PR04MB0756; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0756; X-Forefront-PRVS: 0582641F53 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(396003)(346002)(39380400002)(39860400002)(376002)(199004)(189003)(65826007)(2950100002)(68736007)(386003)(575784001)(305945005)(86362001)(7736002)(64126003)(36756003)(117156002)(5660300001)(8936002)(2870700001)(66066001)(81156014)(81166006)(65956001)(2906002)(65806001)(83506002)(47776003)(106356001)(6666003)(67846002)(26005)(58126008)(53546011)(6246003)(31686004)(186003)(76176011)(16526019)(6116002)(105586002)(8676002)(4326008)(316002)(77096007)(6486002)(3846002)(16576012)(229853002)(25786009)(50466002)(31696002)(53936002)(23676004)(52146003)(478600001)(2486003)(52116002)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0756; H:[192.168.1.3]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTJQUjA0TUIwNzU2OzIzOkJZMGhwNUo5UmpzSnI0ZDJVaitVUjFET3Nv?= =?utf-8?B?UnJGOTB1UEVlWEdILzhuckhZKy83MEdwZmVsMDBDRStrUkdUWlpHbW9odVRi?= =?utf-8?B?ZndVYzRxWUFGTzBoWi8ydjZKd2s1Z0hmUjhqWDFtYVYyTlFBWCtWdy9iMm1h?= =?utf-8?B?MTBZUTAxOWJyMWt4QW91TUJEczdrdW5EL041SkR1WmFDY1ZHSkIraERPL2hE?= =?utf-8?B?OHB2enM4UUFpVEpSeEp2Njhpam5BbmlHQ2FYQkI4U2ltZU1RZ0JuN2g5R1Ji?= =?utf-8?B?eHdEZlV5TFZFalhvTG0xV081TnRzVU8yU0JhMVdMYTIxRytDUVZtajRnZTAz?= =?utf-8?B?dUVrWTFEd3R0RndUN1FWa1BKWjNnbjA5SllZYzJKek4wMGpiZkJVM0EvRHZp?= =?utf-8?B?UEtHd1hmb05sZ0E3QmNEYkQzL1YzUVhzUkxDaHlObnpkUlBwQzZ1K1J6SWVp?= =?utf-8?B?SThZeFFhRDdTNlNYYXVmeTlJc1RDV3JpZktJazk4WEtWbUNqMHdUWUs1SGky?= =?utf-8?B?aFd1Y0VWd2JqS3EyMldPNlp0ZHFpSjJlRlB4N3VzMDBFNjZJUUdLeTdZbTQ5?= =?utf-8?B?KzF1QVBnVjVTYk5RUXdkU2V2RGpWUkVPRUJwYW8xclMvMXNSbFJKbHdCcnlX?= =?utf-8?B?SEwrQ2dORGxCMnFQYWYvbFFUdHV2MW5Nc2RXTFF0RmNMVm9jU1VqeUlYcWdD?= =?utf-8?B?cnlYbVE5SXBoaWJvaEVOaFdQdlVjYzRrcmhWcUh4SG1KdGNTS3o4dlpSOVRS?= =?utf-8?B?V1UrYmR3VnR2R1ZuNEREblNNRkpFSGdEdWlEekZQNUtWVGZKRGQvM2NmdUpY?= =?utf-8?B?dVJSZExra2l3T21zVDBqR1dTenJlaHdaY2hjL3NGdjlTWlB2LzIxTHdZTjIr?= =?utf-8?B?Q0VTdmpDcGlJZ1k1UFg5ams4M2VuTFdRUE9qUkRhV2tJU3RyRERNYTVKUUVz?= =?utf-8?B?V2Z4Yi9JLzl6MkUrVDJERTNoUWQ1ekNMMVQ1aU9HR2tTUmF2Ujk2ck9tR29q?= =?utf-8?B?ajgzQTdTdmRPZ3JIUXppeERXa1diSDhFYXFrS3VHaEFJNmFnUmRHcW5mTUZr?= =?utf-8?B?VFZQZExoQTJrTFJFbFRJY3hXMUlGaFErQ0pHbXJ4VVhDTUc4eGx6RXdtZFgv?= =?utf-8?B?R05CTEkvZHBQeGErc0FBRFRVTDZrNG1OTm9rMGRObVJLaStkRHFjZHlPZmgz?= =?utf-8?B?cENneURSQngzamwvVzRSN2syd21NbTUwNm1LUVB5cU1LTDFoWmRDWEVFU0JW?= =?utf-8?B?N1AwQjlldi9nQnJETFRNSEpaMlJjZUlpbXp2TEYyYndXdlc4Ty9MaVhUQnE5?= =?utf-8?B?YVVBdE1PQ0RwMWZmYkxSaWd5dHBsN1JVU29vMTl4QWdreG1oT3hIUXRGeEF1?= =?utf-8?B?a0luUWFZbkhySDZqV2pjbytvOHlUK2hDUWxnSTdXYzBSY2NsSkNMTjhHQ2xP?= =?utf-8?B?ejNKb1hxYTZ2WFpDcUVQSk5ZMitid0lLYTR3c1RwMEpaSlV3YjIxcEliZGYz?= =?utf-8?B?OXpMUGMweFJMcUdUQklnMFI1VUZKcGhNb2EweEdZNG5zbEZEUi93MFB6eWxG?= =?utf-8?B?c2JrL2tnRFQwcEtZUmErTjBxaW5TdDVCOFBraFdKTm5QUFIrRjhRaXVXQ2s5?= =?utf-8?B?OTlDZGdBdmNqUlVWWkVDdHRZRzBCUDVRMENEblNtYVRqb2llYmVJRE1ydG1Z?= =?utf-8?B?eno0MHRwQ04xMk1YNkFCaS9xN3d1TTh5czBreXRkQWphdmdCaWdQb3AyWFhk?= =?utf-8?B?ZDlyMEpYYWNwUG16NDFyK1U2VzhkVUdnSTZFaDBKMEtDQ2Z1bVU1SFYvc1Vk?= =?utf-8?B?NTZwMGpXQUg2U2VhSW4vQ2hpbFVUTVRjeVdTaUhCbS85cGpqelpTUGU2djNq?= =?utf-8?Q?KBGtsfZfaBR8y0om7YKClGXoHhwGFDxb?= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756; 6:R8J92gRyGAOMKWa/ogbBP9vkPS1KsoiJ2IFtMsma+Vo2Tocc6M5nlQ7++ORwriLGnW5HFHIzfROa8UlyppNPEe2NuXa2nrmSMv6KDJ6mLMNbD6E5+jEkXTETihF98vtcvZXkrvOxIaGutD+kMBYJbH0DdAnTJsWMB/MVS7e0zXMqbAtqRqc0v/mIKinOptlALq+WJ593tj1NwB8OXgTgoz/trtl25hJMDSOkxYHQfwnsDF6hS804Y00eV73guW+yAt6gtFXuW1XvuNpBe13RkJ0zxuD8gG/vR+wH6+ElQVEDceYNhRqlBRShp1wv/WWKexYI0CS10FCf+de9y4UdOHd4a7yXFAWBV8X5rdltb2g=; 5:HMmKqx4HuRl6SX3IneEiEfu4PmFtaCVrF2h8K2TjWq8Rpn7CzzkDnOLS04ENH1MOtjIwkIrMG0omP1ZatehKOPZSwTrQZa8UjoMEIejyHpi9BLcIAO8fETa6IYeuStffRnoQe9Rm0yc40ME7Im5CYWugg949DNiIQB1aJx+D+3M=; 24:fZhc4WPp2QN+TUeQKC4PnNc3Hjif9WaPXzB9peyJ2cl3X061Y4ZIqSat/cjcn14fzahTL0ewaK693/3YpPynA9leKjseTC6XH2f2c72bMqo=; 7:qPVopQn04O1bRIkxLzagHC+YLLcUB7/HnfEE/Z+6YIkodtCsIav36tgLvDuKF0MJvUgwJtt9hMy5gAh+ODaPv+5sM6fBNFYwpsRiWMc6m6iurhNAH1ysKFVChXdoT+UoP5IAW/dTjgJW9elKPe2A9RkDWP1w11X+ntWQV06aQp88lhwQDG26REFz9LUt+6VQVNKNcvH7PFwksPX7xiWWRBIc1fQQOQHN030tE2AxRXNSX4q6iIgtlSPIMMCbiEp5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2018 04:56:33.7790 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 185192d5-54c2-4fcd-0fbe-08d5729e28da X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0756 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: remove unused map symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 04:56:39 -0000 On 2/13/2018 9:16 AM, Hemant Agrawal wrote: > HI Pavan, > > On 2/12/2018 7:53 PM, Pavan Nikhilesh wrote: >> Remove some unused map symbol. >> >> Signed-off-by: Pavan Nikhilesh >> --- > >> diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map >> b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map >> index cc635c736..d05f274d0 100644 >> --- a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map >> +++ b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map >> @@ -2,7 +2,6 @@ DPDK_17.11 { >>       global: >>       rte_dpaa_bpid_info; >> -    rte_dpaa_pool_table; >>       local: *; >>   }; > > DPAA(x) related changes LGTM > >> diff --git a/lib/librte_eal/rte_eal_version.map >> b/lib/librte_eal/rte_eal_version.map >> index 2e6cbe96e..d12360235 100644 >> --- a/lib/librte_eal/rte_eal_version.map >> +++ b/lib/librte_eal/rte_eal_version.map >> @@ -248,7 +248,6 @@ EXPERIMENTAL { >>       rte_service_map_lcore_get; >>       rte_service_map_lcore_set; >>       rte_service_probe_capability; >> -    rte_service_reset; > > It is not a good idea to remove these APIs form MAP > Some of these are external APIs. The existing examples may not be using > them in DPDK, but a real app may use that. The same comment apply to > other removal for external APIs. > Please ignore my comments. I was too quick in reviewing it. Acked-by: Hemant Agrawal > Cristian, what is your opinion. > >>       rte_service_run_iter_on_app_lcore; >>       rte_service_runstate_get; >>       rte_service_runstate_set; >> diff --git a/lib/librte_ether/rte_ethdev_version.map >> b/lib/librte_ether/rte_ethdev_version.map >> index a5cb372b1..87f02fb74 100644 >> --- a/lib/librte_ether/rte_ethdev_version.map >> +++ b/lib/librte_ether/rte_ethdev_version.map >> @@ -156,7 +156,6 @@ DPDK_17.08 { >>       rte_flow_copy; >>       rte_flow_isolate; >>       rte_tm_capabilities_get; >> -    rte_tm_get_leaf_nodes; >>       rte_tm_hierarchy_commit; >>       rte_tm_level_capabilities_get; >>       rte_tm_mark_ip_dscp; >> diff --git a/lib/librte_ring/rte_ring_version.map >> b/lib/librte_ring/rte_ring_version.map >> index 5474b985e..d935efd0d 100644 >> --- a/lib/librte_ring/rte_ring_version.map >> +++ b/lib/librte_ring/rte_ring_version.map >> @@ -7,7 +7,6 @@ DPDK_2.0 { >>       rte_ring_init; >>       rte_ring_list_dump; >>       rte_ring_lookup; >> -    rte_ring_set_water_mark; >>       local: *; >>   }; >> > >