From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0060.outbound.protection.outlook.com [104.47.36.60]) by dpdk.org (Postfix) with ESMTP id 456C537B1; Thu, 5 Oct 2017 14:25:57 +0200 (CEST) Received: from CY4PR03CA0019.namprd03.prod.outlook.com (10.168.162.29) by CO2PR03MB2359.namprd03.prod.outlook.com (10.166.93.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 5 Oct 2017 12:25:56 +0000 Received: from BN1AFFO11FD026.protection.gbl (2a01:111:f400:7c10::152) by CY4PR03CA0019.outlook.office365.com (2603:10b6:903:33::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11 via Frontend Transport; Thu, 5 Oct 2017 12:25:55 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD026.mail.protection.outlook.com (10.58.52.86) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Thu, 5 Oct 2017 12:25:55 +0000 Received: from [10.232.134.49] ([10.232.134.49]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v95CPpeb006999; Thu, 5 Oct 2017 05:25:52 -0700 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Doherty, Declan" , "hemant.agrawal@nxp.com" , "stable@dpdk.org" References: <20171003092911.32447-1-akhil.goyal@nxp.com> From: Akhil Goyal Message-ID: <2771f09c-b502-6f35-74b4-d6b0829b91fd@nxp.com> Date: Thu, 5 Oct 2017 17:55:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131516799557138891; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(346002)(39860400002)(376002)(39380400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(13464003)(189002)(377454003)(199003)(24454002)(110136005)(8936002)(31686004)(50466002)(68736007)(316002)(229853002)(105606002)(189998001)(6246003)(54356999)(53936002)(2950100002)(33646002)(106466001)(64126003)(50986999)(5660300001)(58126008)(4326008)(65826007)(23676002)(76176999)(2501003)(69596002)(77096006)(97736004)(65806001)(498600001)(104016004)(2906002)(53546010)(36756003)(31696002)(230700001)(8676002)(81166006)(47776003)(356003)(85426001)(83506001)(65956001)(8656003)(54906003)(81156014)(305945005)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2359; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD026; 1:hjU9XTIQw7ytfl39KhTZ0/7d1o/FTDkWz3J7QDg/nNnhzaJTjL7S4Txwnka8WjM0wnctkm2RMIa7LDhBsdNICY18ztKOS8JQw6sev2NDSEG29SWB7kwXr6EWKShco3Wo X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2377ba7-2981-4f8a-b709-08d50bec3a0b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CO2PR03MB2359; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2359; 3:9E/KGoMtf4alMB7aENVX2OCku43dsIUJ+xZnB5nOSnEEDUZgflLI+m836SGe//TuDEBhMdiZbf6+pqJjd8cr0vUYC574VWSgxsCJ4+Fk3WC/7aiGJwrIn/BUGbANLZRkc67pSaYKpgvzAS9EfTGtcb8RenxgoWr31AAhrMl6YKNrFWh9j09q8e35s7LuVsu0ToAZiGpzgxHbcSKUdDFF5Qx171+yMgWAkq5vUfFN88Y2Bodk15F6DqiQ/8PtJsPgr5wTy0jcabzSn8ACPNVkBKdui0ripV+ZgeX2trR6/fw0GMPTuUSZT9emMuLzVNBs6/jlz5xX+PiwwncexQPrlA==; 25:aUYBoW6/1KoCrI6oHfWncJYFQGpELZAAED+ODL5atbFtRWjkxKepap3vmbswzvpFSNnJFVHf+Nlz0FJcNtLm7Cpe5RIyB8EpM5ovnY+2fQHDdoX6TkceqbMOZUAngZfd6PmzlYwweAErlG14IsU3VDyQ1FVAorzS7jeON3A+eOLtk9uu0DSrKbhllf2WdOosvmL9LCsJ3diJzn0Dw26Tq/h3eD+kPFVgCPYI1WN14k1XMo/rgvpW5/qRd8/TAlC33H9+ef2iWMphrp/4a8dJmVZfgz8nheXmU+ArjdiSpTxg9/NlxJtsdSVyDMq2MVF/V6/0bVbfD2a6t1da78UVIQ==; 31:QqMW+hBCtGSBYV3hu99xBrsvwTfZJQTQ+AoKLTx+PMXQfTwepkzhkPi5vwRhfds6OZQBLraUTdv4n+d9B48MajODnbAhTwe34YfAJNLWMI2Du3L/FBNAycA+qltN54dN0/iCH402eQScaBYCoCTzE+IbMHEGYfDjX8CmvFe2o/YWqevAsVgp/CijqipQ7rHZHAgXxVBy5VUR15UaLH+64xldWmQCAvDhEppTyx1R6w8= X-MS-TrafficTypeDiagnostic: CO2PR03MB2359: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123556025)(20161123561025)(20161123559100)(20161123565025)(20161123563025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2359; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2359; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2359; 4:tcZNqBW7JpSVVHred4Rs02CJbnnLmu4bjhuV7Cloj4kYnpevahcYHEMwnvp5KlXQODrjIAYBvsB4zlGJKQDQOlehUgxVRDt1ALBtPf1ucEjafkAkP804AjJV4tHPUJskLKEL18iIUJ5+z76HmmBiSsz1NGFTl1E2Ihf43ZZQZ0ykxM1f8hFGXBFvUYAAuXtBN3mfj0EODPNWdIjVPwvTWySSEuZg+zEeZj58rETBq+BBuvPp00YjqiYtHqzJlek/TZHmTM2jIZH0LuFKBu12pL3kZQiRv1YRHl+7Zby+GigQ3J+kqoNNNQS24+z+cz3mmMFAnb38PGY1DeFVAiA8og== X-Forefront-PRVS: 04519BA941 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMzU5OzIzOklUNkhhUEMyTUszT0tuT1FnNGVrRWdjSHFa?= =?utf-8?B?azFwaVFoeXlWcDZJTXVnT0ZQdmhSMFhnYS92dTVDNmhWYjVXaVVoWitGbmcv?= =?utf-8?B?S1hqYjhDS1NQOVF2MGZzMGhndzY0RCtrcE9TaXlYVkM1UVpkYllReHcxTGNM?= =?utf-8?B?aVMwMG1XSmxGQWkrdkl5RG96WXkwc1RqTDFSeW9Iell3dkZCREVLN1hlZWF0?= =?utf-8?B?Si93bGo4MERkRWF5cXZmSlYyc3oyZGlpUnlrZEYwZGhFenBiZW5DcGdUbmQr?= =?utf-8?B?RmZseFh5VVZvQ1F3bTFCTXpiWFIxYS92TDZMZXhYbTZOa3ZnUSt5TFRmR3U1?= =?utf-8?B?VVpOc3VYV0VqdzRUZ0RKT2ZQNkNZMjZRbmM4SGJoRDZQei9KTkNLZXhwSThX?= =?utf-8?B?aGVadnYza0drTjZvbUdNczZaNm94Tkx4ajlrbFpuZGNIekVJbG55am1nWXVE?= =?utf-8?B?ZEZXVE1STE41dlFXd0gwMUhMRlNiQkhXM1ovZ3JGYkpPaUt1cnJKRGhTYkxk?= =?utf-8?B?dW5HM1BxaFNuVWRpc08yblptVTdKRm1LVEJMcnJZb1VsT041QzJ0Y3JrVW1n?= =?utf-8?B?R0Vua2U3dGorWjYrcERFTTlaakpaZVZodnRJc1ppWE1sQlF2MnFRUDdjVUE5?= =?utf-8?B?REQ5RDhFeGRNRnBJcjVQdzVTOGtCR1lmeG96UVlmU1h1V3Q3THNnWE4wbUJC?= =?utf-8?B?LzhvNy9vNzB3VWFLKzZMSWtNVXMyZVc1OEw4Wi8zeTc0d0U0SThBeXBOSWdt?= =?utf-8?B?MVlmd2lDVElUVFQwUkU3K0MwclFmWTNpSVRKOXM3UHplVU5hK1dEUUswcVRX?= =?utf-8?B?amdmZG1valVpWjJVcWIxaWthUGFXYU9mMktJZEVtbjBmY0FkemtTSllRSjhw?= =?utf-8?B?NEFISjQrRUx3eHdxbFF6V08ybjB5bWFzQ3hmby9USS9HQzhlQmxkNUNkUURy?= =?utf-8?B?TXdUaEkwNjFXRGVlNzNIYjdUYy90U1FMa2pNOVhEdVBYUXBCaGt3cFgxWnhs?= =?utf-8?B?THZLbklWMHhkNTUzYVRMOGF4c0ZSZmR2aFc0M3o2NEk3QnN0bG16WjNrNHA0?= =?utf-8?B?M1poS2tobVlEMXZnZUZZUElXOFoycDlVOWtaSEw5NU5oa1dEM0VvU2YxU0Rq?= =?utf-8?B?SHpGMmhzNldTcFFZTlJrb1JhaHgrNmF0NzJiazVEWUJGOWRjcEJRRFJTNjVj?= =?utf-8?B?WFpQZXc1L3orb3FWKzBva3o4eXlaSENFYlU4RE00SjludHRvVDZMQlBpZXZX?= =?utf-8?B?emJSN044YlJXY01CNlFqa3FQekEzRmZIK1NTVjB6SG15eFNSVkRYT3N0emI3?= =?utf-8?B?R0h1T1lucEQyVll6WHhtamwrNlAvbWZqLzhOUFp1TTd0ZzM5dEQ2NXAvbzN1?= =?utf-8?B?c3dRczVSZHNJZXE3S29qV3kvQ2xZRkxrdUtyK2VSMnNPQ2Y1RXE0cjUxREZN?= =?utf-8?B?c0FyeWZ4R0hIY0wwODc3ai9aOHVYcDRjVi9hbmwvTDRoNWVRdGJFaW1HS0RM?= =?utf-8?B?RG5UUnEwZjZKd3R5YVdkR3U4Q1R3QjRmOS8reUljYnJmNDZzc0pTYzFCYVNm?= =?utf-8?B?QkxwUTZCa09QUUZMQmFIRkpxSkV3djkxLzMvSklqOXBzeE9sVm9mL2Zmdk1X?= =?utf-8?B?K3FUWW0zQm5ZeFVEZkd4ZTZIU1U1TnVLNDY5dk9HTGVwNlVRRlBrMEEwMUxl?= =?utf-8?B?ZjJUVHcvMG4yZXZjbmQzRm10UElUTEx5ZjlFQ0U4aXRYbzcrUUROVHhGbkcv?= =?utf-8?B?dnl2dy96ZklmeEo2bGc2R1liOVl0bE1HRlgzaTNDaHhUcTlVSjZIVmV6WFB6?= =?utf-8?B?WVpvSmY0dmFyNmorOFdvYlM1OC8wUm1hK3JTbFZhVmc0aG1CeFBZeExoUytD?= =?utf-8?B?MGs0QzdaMDBRTGgzeEJnaTRvRVZqdU9lb01TeGlTWnBuSkhySG9LNEpLdjQ3?= =?utf-8?B?NW1LN2FKNnFHcXVhNTRmWm9uN1l4a0kxNTYzRGNBMzY3R09sZGZxbzJONVIz?= =?utf-8?B?TytCMlpSVWJkcjRWMk1hM1JCbTQ1MGN0TThzdz09?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2359; 6:QF21vz0vf+S5KeHperi2T5hiIBL5cJTdw0c0dWnpg8z8F3cJHZLHq2xdkotNecQ1jLdGMfHJtrf8FqVA77ScvtKWl2M2v8KmUU/iz2BUTmYiag/9zaVwWWDhAXScEqk/zSKppLT+zWibqhvS0YHvHPxIID/CxwYgj9JTW+98c2uwkI5g3VzE1/2Dz9oSP04JPJumPSdjK9pevZeyl/vVu9XkhV9OW7OuKqGttAjsLRYBnj1vH2crbyGiSSwfhlj2o+bhElvv/6NPLfYEerqZHBQ7Is0Bxvn8AtTuaRFhnls8NyIQW89GMxldIG+cX8aclgXhTqIvVZREhkVehUHa7g==; 5:XFRRqtrpL/62sEMOY8/h47NxrWtsg8mcuTLq/rLWUEPVSVEWvisHxj6LRRMr+sozrqkmN+M5O7qeTl4QL0mSBiVLAOe++HJkc7rUvgq3/9zM429HzHJBiwKkwJCz0azbyXuRFVuaFhEXWSW5oKW8MQ==; 24:YzDVnNV19pyJzkYUsqgogPLR0Tv3SCBP3NoYmJwaj4QUqwGaekwQdZSDm10bSOowvdXtGb865KwjmuQ69OCHmOhLGW37YICuHfP6Ep3B578=; 7:aj3ru/kS7t9+5BPwtOu4LgH8r7jNZpYDHw2Tt9jkniMSc8wf8uxxnRLu4opFdBUJ9pZ9EFaOer/V/T7VUdWyzN8q1eGuPkyjLDPOhGYoNbMFBjLaSeQIBlIhLpQ8mq7kcojQ8nnUbhCLnArBVD/ngn9Pz7NA/CO15mPnnwamA5OIdHqYtwOx6pjf2ap7maCxqVemYQYo+vvZ9ACKdq3OXpbJs9y6OnO8AFSWwStfck8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2017 12:25:55.4018 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2359 Subject: Re: [dpdk-dev] [PATCH] test/crypto: fix dpaa2_sec macros and definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 12:25:57 -0000 Hi Pablo, On 10/5/2017 1:49 PM, De Lara Guarch, Pablo wrote: > Hi Akhil, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal >> Sent: Tuesday, October 3, 2017 10:29 AM >> To: dev@dpdk.org >> Cc: Doherty, Declan ; De Lara Guarch, Pablo >> ; hemant.agrawal@nxp.com; >> stable@dpdk.org; Akhil Goyal >> Subject: [dpdk-dev] [PATCH] test/crypto: fix dpaa2_sec macros and >> definitions >> >> Fixes: 7a364faef185 ("cryptodev: remove crypto device type enumeration") >> >> Cc: stable@dpdk.org >> >> Signed-off-by: Akhil Goyal >> --- >> test/test/test_cryptodev.c | 2 +- >> test/test/test_cryptodev_perf.c | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index >> a4116c6..132f99c 100644 >> --- a/test/test/test_cryptodev.c >> +++ b/test/test/test_cryptodev.c >> @@ -1816,7 +1816,7 @@ test_authonly_dpaa2_sec_all(void) >> ts_params->session_mpool, >> ts_params->valid_devs[0], >> rte_cryptodev_driver_id_get( >> - RTE_STR(RTE_CRYPTODEV_DPAA2_SEC_PMD)), >> + RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD)), >> BLKCIPHER_AUTHONLY_TYPE); >> >> TEST_ASSERT_EQUAL(status, 0, "Test failed"); diff --git >> a/test/test/test_cryptodev_perf.c b/test/test/test_cryptodev_perf.c index >> 3b57e6d..5df2e6e 100644 >> --- a/test/test/test_cryptodev_perf.c >> +++ b/test/test/test_cryptodev_perf.c >> @@ -211,7 +211,7 @@ static const char *pmd_name(uint8_t driver_id) { >> uint8_t null_pmd = rte_cryptodev_driver_id_get( >> RTE_STR(CRYPTODEV_NAME_NULL_PMD)); >> - uint8_t dpaa2_pmd = rte_cryptodev_driver_id_get( >> + uint8_t dpaa2_sec_pmd = rte_cryptodev_driver_id_get( > > I think, in order to keep consistency, you should make this change also in test_cryptodev.c: > > test/test/test_cryptodev_blockcipher.c > 580: int dpaa2_pmd = rte_cryptodev_driver_id_get( > 646: else if (driver_id == dpaa2_pmd) > > Also, I submitted a patch to remove test_cryptodev_perf.c. > I will apply this patch first, so it is easier to integrate in the stable version, > but could you ack my patch if you are OK with it? > > The sooner we remove it, the better, as we are investing a lot of time > in the crypto-perf app, and there is no need to maintain a duplicate, in my opinion. > thanks for pointing this out. I would send a v2. I have a question regarding test_cryptodev_perf.c for dpaa_sec patches. The patchset for dpaa_sec includes changes in test_cryptodev_perf.c. Do you plan to add those patches on the tree as well before removing this file or I need to send another version? In test/test/test_cryptodev_blockcipher.c, I missed out this change for dpaa_sec also. So, I was sending another version for dpaa_sec patches to include this change. Should I remove the changes in the test_cryptodev_perf.c from the dpaa_sec patchset also? Thanks, Akhil