From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A6D8B7D06 for ; Fri, 3 Nov 2017 14:52:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 230E8210C3; Fri, 3 Nov 2017 09:52:28 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 03 Nov 2017 09:52:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=zPWQeKJHpVFX14t6oDPDnfWRJt udVPo3ms5pPb+IqfY=; b=TqM3oUBDSQV5oDK5QtEZQxZnElVnnnNr2bWhXhlYTq iR/Hr31OcyZ7oNTlG1j7wVHgsXEyKtj5Qe6s5X9Sf7+3RjWerfQwCIDUoTIbwXT+ 56OiaxrsSWX09gSi3OIDwlrlLtpsiimlrb4AJ/xMTX6YX/egTmn2/gjF2r7Vn19V o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zPWQeK JHpVFX14t6oDPDnfWRJtudVPo3ms5pPb+IqfY=; b=Ij/jIYJ6376qBt56NhaIni Jl8/AAwiKZlvs+hMKmydwA61sghDkkGBX6zMtb5mUfCcBAqcpbrTToD/TXn7l68h 7C/On+s2W3fIjGZQ0FeFSAoPnO8QmvxOCaUlhQaZ/0T+x9NsrdNpGhlqnV4peNtH t/PWCU8HZT38HnRt++FnmLoCze0MF4SOGP/LkgA3mazfHD5pfbe8H4TcSlHWPwWN G0cNe39duhsviGX3VCW6367p5IZXmSCmf8nxQ0dcrUnFxwrY+cQ+iIOMH7UevYne w2WjzFZtekIuXTxt/RE8NAIdBzy3lAiOctfTQc2XBDY+yVm8/Xsb/H1ODUOlc0uw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BA915248D1; Fri, 3 Nov 2017 09:52:27 -0400 (EDT) From: Thomas Monjalon To: "Gonzalez Monroy, Sergio" Cc: jianfeng.tan@intel.com, dev@dpdk.org, bluca@debian.org Date: Fri, 03 Nov 2017 14:52:26 +0100 Message-ID: <2774584.OjYm9LEu22@xps> In-Reply-To: <173a41cb-53b7-b986-bdaa-d36676c4d740@intel.com> References: <20171103112455.18406-1-thomas@monjalon.net> <173a41cb-53b7-b986-bdaa-d36676c4d740@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mem: remove old function from symbol list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 13:52:28 -0000 03/11/2017 12:34, Gonzalez Monroy, Sergio: > Hi Thomas, > > I reckon you need to bump ABI version when you remove public symbol from > .map file. Yes, of course, unless it has already been dumped: http://dpdk.org/commit/f26ab687a74 > On 03/11/2017 11:24, Thomas Monjalon wrote: > > The function rte_mem_phy2mch() was removed with the support > > of Xen dom0. > > > > Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0") > > > > Signed-off-by: Thomas Monjalon > > --- > > lib/librte_eal/rte_eal_version.map | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > > index d2a4ff974..7c9bdc2ae 100644 > > --- a/lib/librte_eal/rte_eal_version.map > > +++ b/lib/librte_eal/rte_eal_version.map > > @@ -62,7 +62,6 @@ DPDK_2.0 { > > rte_malloc_validate; > > rte_malloc_virt2phy; > > rte_mem_lock_page; > > - rte_mem_phy2mch; > > rte_mem_virt2phy; > > rte_memdump; > > rte_memory_get_nchannel; > >