From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 26B348E58 for ; Mon, 21 May 2018 00:18:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A7F9A220C7; Sun, 20 May 2018 18:18:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 20 May 2018 18:18:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=B7UvZeBsoQ4IGBu0tzib2BqVbN KXFarZVYUKhDW7beQ=; b=NWgphNuFjKCniCR0rrQqyOZgCBOqQnUckpvp0hMeRA 8dsP6LHzM5QcLXfqpRpHRIO6YICPQ0WGdoJUsVKzmTfe9Hin3RLiMZU3Dn9P+YOS UDQjn0vYBcxYrSTPpup6uR9Y0lmnREYobe1THZjmRKiKlCEo3RxtUAAypXzbGxnx k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=B7UvZe BsoQ4IGBu0tzib2BqVbNKXFarZVYUKhDW7beQ=; b=nrxKOepTnds5EbFVE5mSYG 08IPCb4COQNodsK/pKpYFDZw/5I5URc6mCGfyowk1kPvAj2ssIXNTkgYpIu1ANyT 6yZvhnv1v5VEpwKWMrxJT0KzBY8mNy0YTRZj4p6YbRTZ6XzSW3O0jJlNI+xdKYi0 Ld9jzOemkTvgnEX9beDScJXwYtKx+1GiyXQ1ffmFpsC0DMojJ4HQaT1dWfN+vyZf OPH1x/mIc2Ry4WzbxyXE8+fEUCt+3TZkAhCMveoqRzCjfznJaGAGkef5bA4/5LTJ ULO1x1eouzyW7gV/SFGboBD7D4nqyofZqSMQVg/QX4UhSOSf35mHluLAkl5HXFVg == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 16FE010260; Sun, 20 May 2018 18:18:58 -0400 (EDT) From: Thomas Monjalon To: Andy Green Cc: dev@dpdk.org Date: Mon, 21 May 2018 00:18:56 +0200 Message-ID: <2776412.uDdhf0LMkq@xps> In-Reply-To: <152656480225.46638.3271983577765861155.stgit@localhost.localdomain> References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain> <152656480225.46638.3271983577765861155.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 00/21] Fixes for GCC8 against lagopus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 22:18:59 -0000 > Andy Green (21): > lib/librte_ethdev: change eth-dev-ops API to return int > rte_string_fns.h: fix gcc8.1 sign conv warning in lstrcpy > lib/librte_eal: explicit tmp cast > /lib/librte_eal: stage cast from uint64 to long > rte_ring_generic.h: stack declarations before code > rte_ring.h: remove signed type flipflopping > rte_mbuf.h: avoid warnings from inadvertant promotion > rte_mbuf.h: explicit casts for int16 to uint16 > rte_mbuf.h: make sure RTE-MIN compares same types > rte_mbuf.h: explicit cast restricting ptrdiff to uint16 > rte_ether.h: explicit cast avoiding truncation warning > rte_rwlock.h: gcc8 sign conversion warnings > rte_ip.h: cast input to bswap16 to be uint16 > rte_ip.h: cast around promotion to int > rte_ip.h: cast type decided by sizeof to uint32 > rte_ip.h: cast return checksum size to uint16 > rte_ip.h: cast away gcc8 warning on rte_ipv6_phdr_cksum > rte_mbuf.h: explicit cast for size type to uint32 > rte_mbuf.h: explicit casts to uint16 to avoid warnings > rte_ethdev.h: align sign and scope of temp var > rte_byteorder.h: explicit cast for return promotion 16 patches have been applied. The tags Fixes and Cc:stable have been added, so they can be backported. 5 patches are missing: lib/librte_eal: explicit tmp cast rte_rwlock.h: gcc8 sign conversion warnings rte_ip.h: cast type decided by sizeof to uint32 rte_mbuf.h: explicit casts to uint16 to avoid warnings rte_ethdev.h: align sign and scope of temp var Those patches are either not reviewed, or not safe enough at this release stage. Please, feel free to send them again in a v6 to make clear they need more review. I think the mbuf one (for uint16_t) may deserve to be split. Thanks