From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91043A0C41; Thu, 16 Sep 2021 12:39:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2132840151; Thu, 16 Sep 2021 12:39:24 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 92B574003F for <dev@dpdk.org>; Thu, 16 Sep 2021 12:39:23 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 123F55C01D6; Thu, 16 Sep 2021 06:39:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 16 Sep 2021 06:39:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= CMeesqSzB+u2ayz7HRDP45aFn8MMbBDqvJUI2BP42cc=; b=lK7ugdQcj0y3Urkf BHp5RsgxgjHMkr30fKLpYYyOgFOZMcHpaI2NCACmefYkkEz8YZo7qyUBaqD8S7y9 PPiq2tsEfv4v6uItbyp4kRkZcXjK22NyK33Q5nG/fuA2ukD43DtwGpXBqU5Hn8a+ pYzPl0EsLF2vNsY4KoVVJBUDgeKMXU5e6qgg6LN/vpuwSv+QRAHMZZlOZH5ro/Ta fm+g8CGDk/zreHUWfeEv0e37bkZyGUtEcVrM4D7uZN/V51eK6AfgWhIBdsczZbsS YkxUhEgieiNthBL9I07NaWdnnNjbyMmrKRb9e9WazbqC89dyDFKmh9GISy69dgks RIqR/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=CMeesqSzB+u2ayz7HRDP45aFn8MMbBDqvJUI2BP42 cc=; b=bHLEgE46WIEqxzir3vMlWwDI3PC/66wVi3jZyZ0WF5nFvGgD/7Cfd6jw1 AuN+IUkFow6sWcDGVIvFdr6aMpo1dSHjFnUq0gIcFQXaWXc9RvQkUubQPOM02lVs rCtP3TNEmm7KcDFO5pFW27gtrzBAbZiZyAV/PG2eiHseGnTrEJplmC4jB/GrRTcM sPWW0ES1jCLSLSXzb5T9axrjPMIEcZHUOTMCgB59Q98urM9sM8VYuQrVdkBFpPBM fVaOzGYVx62hf75zJqBj2Vq/Z6HMjv6PKpiiLTFAfJFRZo6rG4HeKaMifzf1TUE9 3wVlMPMl3Ey8lowC1MI82vs9+p3Ww== X-ME-Sender: <xms:2h5DYZsrgTvM5HdcyNtG9exKvzntz_JKZLYIJVHyiXNEU-me_oB6MQ> <xme:2h5DYSfvBki0qLKYR8Wh5VNBrr_4lmxm5bXt-I96TcYU0W_PG_3sKvuLK-WH--hGR hgaq5Wlcc_R22FRoQ> X-ME-Received: <xmr:2h5DYcw1JSf4iK11tl8D3uBYSX5aQPsBaESyM97kE1NfTBFcdCmchT9fDBlY2QkrZ57kbkHr0AHJ2uSen48Dc7M0cA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehgedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: <xmx:2h5DYQOcIN52gOoBdcsP4_tz8Y-YqhRemWsgsT_F4gt_n60NIprCAQ> <xmx:2h5DYZ_jFIk-P60WwgZsTcgBw5jjikfGl_qBtrCHBIlPa8wY6_B2AA> <xmx:2h5DYQVh4Ft-vsS323rlNIempsT1x9VIXHXNolPz8hv1AeO4AgNwsQ> <xmx:2x5DYbIl1wh3BtwIlRwG-0kl5XvpxquWgNiPA8NLRHfX5DOefo9qxg> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Sep 2021 06:39:21 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: david.marchand@redhat.com, ferruh.yigit@intel.com, bruce.richardson@intel.com Date: Thu, 16 Sep 2021 12:39:20 +0200 Message-ID: <2777321.BUEC3fTb5M@thomas> In-Reply-To: <20210916103209.3710442-1-thomas@monjalon.net> References: <20210915143232.2994872-1-thomas@monjalon.net> <20210916103209.3710442-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: reword logs for CPU and NUMA counts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 16/09/2021 12:32, Thomas Monjalon: > Some logs about cores and nodes were using hypotetic plural (s) form. > A fixed plural form with value at the end is preferred. > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- > v2: keep plural form as suggested by Bruce > --- > lib/eal/common/eal_common_lcore.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c > index 66d6bad1a7..b38bb46d44 100644 > --- a/lib/eal/common/eal_common_lcore.c > +++ b/lib/eal/common/eal_common_lcore.c > @@ -191,9 +191,9 @@ rte_eal_cpu_init(void) > /* Set the count of enabled logical cores of the EAL configuration */ > config->lcore_count = count; > RTE_LOG(DEBUG, EAL, > - "Support maximum %u logical core(s) by configuration.\n", > - RTE_MAX_LCORE); > - RTE_LOG(INFO, EAL, "Detected %u lcore(s)\n", config->lcore_count); > + "Maximum logical cores by configuration: %u\n", > + RTE_MAX_LCORE); > + RTE_LOG(INFO, EAL, "Detected CPU lcores: %u\n",config->lcore_count); space missing above, consider it as fixed ;) > > /* sort all socket id's in ascending order */ > qsort(lcore_to_socket_id, RTE_DIM(lcore_to_socket_id), > @@ -208,7 +208,7 @@ rte_eal_cpu_init(void) > socket_id; > prev_socket_id = socket_id; > } > - RTE_LOG(INFO, EAL, "Detected %u NUMA nodes\n", config->numa_node_count); > + RTE_LOG(INFO, EAL, "Detected NUMA nodes: %u\n", config->numa_node_count); > > return 0; > } >