From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09F2AA0093; Wed, 20 May 2020 16:14:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28C1F1C295; Wed, 20 May 2020 16:14:17 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A98B61C24A for ; Wed, 20 May 2020 16:14:15 +0200 (CEST) IronPort-SDR: 7QqS2fWkVL5IGWw6qa3ImUSjKQdH2AWy3rKSMqaJd6+lhAdVMldwnKj8R057ytIBXPiAnS5JUX SImXLyWbG8Ig== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 07:14:13 -0700 IronPort-SDR: 4/468U5A0lq4emS6mkkvz0EOzwtW8DgeivW0MNm7T0JKvy1c7lX2bV5cuhZ/YbIPdNE4W4G3bz nE3cRDkBHOwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,414,1583222400"; d="scan'208";a="412028973" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.227.49]) ([10.213.227.49]) by orsmga004.jf.intel.com with ESMTP; 20 May 2020 07:14:12 -0700 To: Shy Shyman , "dev@dpdk.org" Cc: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , "xavier.huwei@huawei.com" References: <20200518092704.188832-1-shys@mellanox.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <2779a381-5b5c-9e41-cedd-6bbd55263f5a@intel.com> Date: Wed, 20 May 2020 15:14:11 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix error detection in MTU command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/19/2020 5:40 PM, Shy Shyman wrote: > Hi > Thank you for the feedback. > While I'm ok with the fix you suggested, the warning was placed in order to let the user understand that his/her MTU settings may not impact DPDK. After all in this case(no JUMBO) we are not doing anything besides changing the dev->data->mtu. Does anything needs to changed in the no jumbo case? I think no, but if there is why no change it instead of warning message. I think warning can be confusing here. > > I think there is some confusion with MTU in DPDK and I'd like to take the opportunity the raise some questions related to MTU: > > 1. only the test-pmd application attempts to correlate MTU to other variables like max_ptk_len and JUMBO offload. should rte_ethdev do that? > 2. even in test-pmd case only RX settings are adjusted. Maybe TX should be regarded as well? > 3. in general what should be the relation between MTU,max_pkt_let and JUMBO offload for both RX and TX? > 4. currently the MTU is set upon initialization to 1500 by default. The MTU on the device itself could be different but DPDK doesn't check for that. Maybe it should be updated based on the device settings? On a similar note, let's say the user changed MTU in test-pmd. What is the desired behavior when existing the application? Today the MTU will remain changed even outside DPDK. > > Thoughts? +1 on the confusion. I don't have answers to all above question, but it would be great if you tackle this clarification task. > > > Shy > > -----Original Message----- > From: Ferruh Yigit > Sent: Tuesday, May 19, 2020 5:58 PM > To: Shy Shyman ; dev@dpdk.org > Cc: Wenzhuo Lu ; Beilei Xing ; Bernard Iremonger ; xavier.huwei@huawei.com > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix error detection in MTU command > > On 5/18/2020 10:27 AM, Shy Shyman wrote: >> MTU is used in testpmd to set the maximum payload size for packets. >> According to testpmd, the setting influnce RX only. >> In rte_ethdev there's no relation between MTU setting and JUMBO >> offload or rx_max_pkt_len. >> >> The previous fix in patch referenced below was meant to update the >> correlated variables of max_pkt_len and JUMBO offload, but by doing so >> it assumes that MTU setting can only exist when JUMBO offload >> supported in the device. > > +1 and this is wrong, as far as I understand this is not the intention > +of the > previous fix. > > >> For example fail-safe device does supports set MTU and doesn't support >> JUMBO offload, and in this case, though set MTU succeed an error >> mesage still printed since the JUMBO packet offload is disabled. >> >> The fix separates the two conditions to make sure the error triggers >> only in case the set_mtu action actually failed. >> A warning message is provided in this special case to alert the user. > > Not sure if this warning is required at all. > As you said above intention is to based on MTU value to correlate testpmd > (application) max_pkt_len and JUMBO offload values. > > What about following change: > > ..... > diag = rte_eth_dev_set_mtu(port_id, mtu); > if (diag) { > printf("Set MTU failed. diag=%d\n", diag); > return; > } > > if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_JUMBO_FRAME) { > .... > .... > .... > } > } > > >> >> Fixes: 150c9ac2df13 ("app/testpmd: update Rx offload after setting >> MTU") >> Cc: xavier.huwei@huawei.com >> >> Signed-off-by: Shy Shyman >> --- >> app/test-pmd/config.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >> 5381207cc..73b53c50b 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -1277,8 +1277,9 @@ port_mtu_set(portid_t port_id, uint16_t mtu) >> return; >> } >> diag = rte_eth_dev_set_mtu(port_id, mtu); >> - if (diag == 0 && >> - dev_info.rx_offload_capa & DEV_RX_OFFLOAD_JUMBO_FRAME) { >> + if (diag) >> + printf("Set MTU failed. diag=%d\n", diag); >> + else if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_JUMBO_FRAME) { >> /* >> * Ether overhead in driver is equal to the difference of >> * max_rx_pktlen and max_mtu in rte_eth_dev_info when the @@ >> -1293,10 +1294,9 @@ port_mtu_set(portid_t port_id, uint16_t mtu) >> } else >> rte_port->dev_conf.rxmode.offloads &= >> ~DEV_RX_OFFLOAD_JUMBO_FRAME; >> - >> - return; >> - } >> - printf("Set MTU failed. diag=%d\n", diag); >> + } else >> + printf("WARNING: MTU was set while jumbo frame offload is" >> + " not supported by the device\n"); >> } >> >> /* Generic flow management functions. */ >> >