From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id C6BB1475E for ; Sat, 8 Oct 2016 00:44:21 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id f193so56691959wmg.0 for ; Fri, 07 Oct 2016 15:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=cZ93I8OKTiXlpZu/kdhCyR1oetu/vjflxVwBh2nd21U=; b=UB/JXEO1u8Sl1hw5aDoXtH5jX8Q6ldYHNn9iN1fWHB0sqrNzIQ+obkAzcFVncxEg48 LtRrAraAuptZxwudpNCX6MAPRW/qpYhxSXp7odbR5L6L4pAX7ZIM6bLSXOV4NpRwIAJM YHFVzmXB5XGXgIVX/A7LDoDQxFzp3/icBEVbOUIfNyv5EbWkYZlAALDt5Pd2IXGM4nu1 9Zp3dysarLSpcJHqR/wtKd/qoUe3iG47rWSUZ9lm43YnWID9JhvQux++WyibRpDN1iXw Vd/d+Sal2qnApY3+8tDMWR9b+AfabN5zjs871UQsjiVbxQOK6q5+6DFtsPaWNg1I0LXF iBRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=cZ93I8OKTiXlpZu/kdhCyR1oetu/vjflxVwBh2nd21U=; b=QkeCv+3NOmq9ykjK9tnC1aHqMzyr+d2CS9vWiKOUNnykfgoJJJ0fZmLEjnYS1h5b51 CZozESSXZBVBujIl8GEXMMqGf9UCTcDPeX8VTV6ZFD6pyu4NseFCEq4pEVwpujtcLJ8f 7EpBB489xqAwLCQzd4QOT8xujEy1P8y5C/argWPF8/THptkvYwOvzRy/GGh/9mRvMojY F3dzisd1ds15SjOEdnKb+JWig0fYbYLwBDz+cvqloY15zSlqAVLnaWG1dGEDEcB8rr8k tHWF+s6kKYrZ1N1zlaRpnYRzeOHKh1tddQEiJ1EWVfUEry+GEPJC/7zZBOh4c26bpndz jufA== X-Gm-Message-State: AA6/9Rlqpl2/7PyW2aqUsr0mlpTXENMTRQkHfzkC2vnXW8357z1W6e1MCyIP0xdg8xqfYsWJ X-Received: by 10.28.126.73 with SMTP id z70mr636620wmc.7.1475880261603; Fri, 07 Oct 2016 15:44:21 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id rk14sm21740761wjb.6.2016.10.07.15.44.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2016 15:44:20 -0700 (PDT) From: Thomas Monjalon To: Bernard Iremonger Cc: dev@dpdk.org, rahul.r.shah@intel.com, wenzhuo.lu@intel.com, az5157@att.com Date: Sat, 08 Oct 2016 00:44:19 +0200 Message-ID: <2780407.hr2q20cLcS@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1475858784-5303-3-git-send-email-bernard.iremonger@intel.com> References: <1475772490-10491-1-git-send-email-bernard.iremonger@intel.com> <1475858784-5303-3-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 22:44:22 -0000 2016-10-07 17:46, Bernard Iremonger: > +struct rte_pmd_ixgbe_mb_event_param { > + uint16_t vfid; /**< Virtual Function number */ > + uint16_t msg_type; /**< message type */ > + uint16_t retval; /**< return value */ > + void *userdata; /**< pointer to user data */ Generally speaking, the user data is a pointer passed by the application when registering the callback and must be untouched. It should be the name of the parameter that you are overriding with this structure. So this "userdata" pointer could probably be better defined. By the way, it is far from trivial to understand how to write the callback. I think it deserves more explanations.