From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 59A7A7F6D for ; Wed, 5 Nov 2014 22:57:37 +0100 (CET) Received: by mail-wi0-f182.google.com with SMTP id d1so3358095wiv.15 for ; Wed, 05 Nov 2014 14:07:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3Ekj0tmAHeFyF9YICKVGDF04yIQbguGeqiUdCf5t/Mg=; b=FZ76CbcDLGJf1E+RPf/K4FHmOlc9XpgFMBFxQIsiNObW4kaXw6DeKG3vWzgJfaosey sVywwex3HfKYz1PPG97/NzwAh5qKVqWdmBmvEYwNU6SIifi2ZtSvMJ+ybaW7T9tCMc+e bBCCyYqJKBbezOlhk4pKRehprkEKUwc8mF2/JyIN7tpm9637Btz8uOA+Rq9HPAfdN7ID qqkNsQ5LWDr+CxtXOzViBRpNgDoBpQVJuXFp9YulT5Tm6oO4YNz96bLnN8iW8DzvSRSh buHn6nXB8R0HGswWjJOoVdAbruJ/9VgTzP2LpvTficT0qKDAY3cwcDYcywmwvefJvnxB cPWQ== X-Gm-Message-State: ALoCoQkdpfDzek3OpPfhwdfsHM2A5ri5WxpUTJF5rbW7EbTBYDcl//xfBszuGKs0KvOkgN0HLNax X-Received: by 10.180.36.205 with SMTP id s13mr34910402wij.11.1415225221978; Wed, 05 Nov 2014 14:07:01 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dr5sm6043447wib.4.2014.11.05.14.07.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Nov 2014 14:07:01 -0800 (PST) From: Thomas Monjalon To: "Xie, Huawei" Date: Wed, 05 Nov 2014 23:06:42 +0100 Message-ID: <2781109.5j1Vc3hjvo@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1415206995-1086-1-git-send-email-huawei.xie@intel.com> <2088055.shkfIhmk6J@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2014 21:57:37 -0000 2014-11-05 21:55, Xie, Huawei: > > 2014-11-05 21:21, Xie, Huawei: > Btw, for alignment in structure, I see different projects use different way, > some use tab, and some use space(between type and var), do we have rules for this? > { > Type var1 > Type var2 > } I prefer using spaces for such alignments. But Linux style is to use a mix of tab and space with tab being equivalent to 8 spaces. We have to write clear rules about such things and have our own checkpatch. For release 1.8, we still don't care about this level of details. Please let's re-open this topic after the release. -- Thomas