From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 300B2A04B9; Mon, 7 Sep 2020 10:12:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE1F61C0BE; Mon, 7 Sep 2020 10:12:27 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 0DF571DB8 for ; Mon, 7 Sep 2020 10:12:27 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.137]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id A34A220064; Mon, 7 Sep 2020 08:12:26 +0000 (UTC) Received: from us4-mdac16-19.at1.mdlocal (unknown [10.110.49.201]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 9FC2D6009B; Mon, 7 Sep 2020 08:12:26 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.108]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id C631F22004D; Mon, 7 Sep 2020 08:12:25 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 2472B140055; Mon, 7 Sep 2020 08:12:25 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Sep 2020 09:12:07 +0100 To: Ferruh Yigit , Kiran Kumar Kokkilagadda , Ajit Khaparde CC: Thomas Monjalon , Andrew Rybchenko , "dev@dpdk.org" , "Jerin Jacob Kollanukkaran" , "orika@mellanox.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "rosen.xu@intel.com" , "beilei.xing@intel.com" , "jia.guo@intel.com" , Rasesh Mody , Shahed Shaikh , Nithin Kumar Dabilpuram , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , "keith.wiles@intel.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@nxp.com" , "wei.zhao1@intel.com" , "johndale@cisco.com" , "hyonkim@cisco.com" , "chas3@att.com" , "matan@mellanox.com" , "shahafs@mellanox.com" , "viacheslavo@mellanox.com" , "rahul.lakkireddy@chelsio.com" , "grive@u256.net" , Liron Himi , "jingjing.wu@intel.com" , "xavier.huwei@huawei.com" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "somnath.kotur@broadcom.com" , "jasvinder.singh@intel.com" , "cristian.dumitrescu@intel.com" References: <20200821110330.214931-1-kirankumark@marvell.com> <20200901032708.58247-1-kirankumark@marvell.com> <6fc71450-ffae-1ddb-e0bb-c0c8864f6a28@intel.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: <27823143-3cec-073a-385a-2e5b0485f078@solarflare.com> Date: Mon, 7 Sep 2020 11:12:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <6fc71450-ffae-1ddb-e0bb-c0c8864f6a28@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25650.003 X-TM-AS-Result: No-17.966000-8.000000-10 X-TMASE-MatchedRID: 0+daXaNUWRXmLzc6AOD8DfHkpkyUphL9Tmb4S36qG99G7aLtT3oj+2dC uMvHMJPkH/e0ZU9w3j4Mlgm9q2XnHEKV/yVJ77BX1D5A16CR3zNCVyBhQf6pRrV5fSMRD1zqhgw zevey5J4F0dGWSflivqrbiyJcRE9x52/pxZx2tzSprpImTnz4tqDzzrtsjCZTaHvr9sOkYSv/iO OUPB/h/ul7LCIq4BUY3vZQpJ4cg3siTMmg/YMPl04eFUkH5CFcoae+ev6zOlIHZBaLwEXlKGb6P phVtfZgm+cP2QHSFAdCRcUvq6BHEzw+HfGa1AwzM71h0SMVl8KrJvy6SUAf1VIxScKXZnK0u5UM MuDqN60oO+BZoIO8qkAFcnpD9mZeXcRIPohGlerAX2KHbjm+i3N3sLsG0mhuqPGqHIPGZiMF3Vh 9D4v36V+F5Xt2kyMFA1zasN/Z/D8oVt6wlS47HJMIKPXbrloXekMgTOQbVFuPpeH2TUh47vIGO+ HJkWIULDhEWDXgyu5tOiZ3CUNAjOJVhWVfaXeSfjUCBXbhed8bQ57RP6lOURlLPW+8b7SaI6o3R brH6CQuTeMNXLAFc5euFNMWQpxEpqx8yws4sTg14ETxvAKbsjLKL6f4fTnRZ9uMaIUDtOXsF6H3 FgszHtl1sUfiKm393PtN8qoaBA9KIVgWeEFfuvX8TPl9LyNbfS0Ip2eEHnzUHQeTVDUrItRnEQC UU+jzjoczmuoPCq3PRAZvKqN5sE0YMyaoJPJohsV1PeQzhaCF9whRvLLkdyfoyPpkW6h8 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--17.966000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25650.003 X-MDID: 1599466346-Bn0BgMMmlNfI Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v7 1/3] ethdev: add level support for RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: On 9/3/20 4:14 PM, Ferruh Yigit wrote: > On 9/3/2020 11:11 AM, Kiran Kumar Kokkilagadda wrote: >> *From:* Ajit Khaparde >> *Sent:* Tuesday, September 1, 2020 10:42 PM >> *To:* Kiran Kumar Kokkilagadda >> *Cc:* Ferruh Yigit ; Thomas Monjalon >> ; Andrew Rybchenko ; >> dev@dpdk.org; Jerin Jacob Kollanukkaran ; >> orika@mellanox.com; xuanziyang2@huawei.com; >> cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; >> rosen.xu@intel.com; beilei.xing@intel.com; jia.guo@intel.com; Rasesh >> Mody ; Shahed Shaikh ; Nithin >> Kumar Dabilpuram ; qiming.yang@intel.com; >> qi.z.zhang@intel.com; keith.wiles@intel.com; hemant.agrawal@nxp.com; >> sachin.saxena@nxp.com; wei.zhao1@intel.com; johndale@cisco.com; >> hyonkim@cisco.com; chas3@att.com; matan@mellanox.com; >> shahafs@mellanox.com; viacheslavo@mellanox.com; >> rahul.lakkireddy@chelsio.com; grive@u256.net; Liron Himi >> ; jingjing.wu@intel.com; xavier.huwei@huawei.com; >> humin29@huawei.com; yisen.zhuang@huawei.com; >> somnath.kotur@broadcom.com; jasvinder.singh@intel.com; >> cristian.dumitrescu@intel.com >> *Subject:* Re: [EXT] Re: [dpdk-dev][PATCH v7 1/3] ethdev: add level >> support for RSS offload types >> >> On Tue, Sep 1, 2020 at 7:27 AM Kiran Kumar Kokkilagadda >> > wrote: >> >> >> >>      > -----Original Message----- >>      > From: Ferruh Yigit > > >>      > Sent: Tuesday, September 1, 2020 7:08 PM >>      > To: Kiran Kumar Kokkilagadda >     >; Thomas Monjalon >>      > >; Andrew >> Rybchenko >>     > >>      > Cc: dev@dpdk.org ; Jerin Jacob Kollanukkaran >>     >; >>      > orika@mellanox.com ; >> xuanziyang2@huawei.com >>     ; >>      > cloud.wangxiaoyun@huawei.com >> ; >>     zhouguoyang@huawei.com ; >>      > rosen.xu@intel.com ; >> beilei.xing@intel.com >>     ; jia.guo@intel.com >>     ; Rasesh Mody >>      > >; Shahed Shaikh >>     >; Nithin Kumar >>      > Dabilpuram > >; >>     qiming.yang@intel.com ; >>      > qi.z.zhang@intel.com ; >> keith.wiles@intel.com >>     ; hemant.agrawal@nxp.com >>     ; >>      > sachin.saxena@nxp.com ; >> wei.zhao1@intel.com >>     ; johndale@cisco.com >> ; >>      > hyonkim@cisco.com ; chas3@att.com >>     ; matan@mellanox.com >> ; >>      > shahafs@mellanox.com ; >>     viacheslavo@mellanox.com ; >>      > rahul.lakkireddy@chelsio.com >> ; >>     grive@u256.net ; Liron Himi >>      > >; >> jingjing.wu@intel.com >>     ; xavier.huwei@huawei.com >>     ; >>      > humin29@huawei.com ; >> yisen.zhuang@huawei.com >>     ; >>      > ajit.khaparde@broadcom.com ; >>     somnath.kotur@broadcom.com ; >>      > jasvinder.singh@intel.com ; >>     cristian.dumitrescu@intel.com >>      > Subject: [EXT] Re: [dpdk-dev][PATCH v7 1/3] ethdev: add level >> support for RSS >>      > offload types >>      > >>      > External Email >>      > >>      > >> ---------------------------------------------------------------------- >>      > On 9/1/2020 4:27 AM, kirankumark@marvell.com >>     wrote: >>      > > From: Kiran Kumar K >     > >>      > > >>      > > This patch reserves 2 bits as input selection to select Inner >> and >>      > > outer encapsulation level for RSS computation. It is combined >> with >>      > > existing >>      > > ETH_RSS_* to choose Inner or outer layers. >>      > > This functionality already exists in rte_flow through level >> parameter >>      > > in RSS action configuration rte_flow_action_rss. >>      > > >>      > > Signed-off-by: Kiran Kumar K >     > >>      > > --- >>      > > V7 Changes: >>      > > * Re-worked to keep it in sync with rte_flow_action_rss and >> support >>      > > upto >>      > > 3 levels. >>      > > * Addressed testpmd review comments. >>      > > >>      > >   lib/librte_ethdev/rte_ethdev.h | 27 >> +++++++++++++++++++++++++++ >>      > >   1 file changed, 27 insertions(+) >>      > > >>      > > diff --git a/lib/librte_ethdev/rte_ethdev.h >>      > > b/lib/librte_ethdev/rte_ethdev.h index 70295d7ab..13e49bbd7 >> 100644 >>      > > --- a/lib/librte_ethdev/rte_ethdev.h >>      > > +++ b/lib/librte_ethdev/rte_ethdev.h >>      > > @@ -552,6 +552,33 @@ struct rte_eth_rss_conf { >>      > >   #define RTE_ETH_RSS_L3_PRE64         (1ULL << 53) >>      > >   #define RTE_ETH_RSS_L3_PRE96         (1ULL << 52) >>      > > >>      > > +/* >>      > > + * We use the following macros to combine with the above >> layers to >>      > > +choose >>      > > + * inner and outer layers or both for RSS computation. >>      > > + * bit 50 and 51 are reserved for this. >>      > > + */ >>      > > + >>      > > +/** level 0, requests the default behavior. Depending on the >> packet >>      > > + * type, it can mean outermost, innermost, anything in >> between or even no >>      > RSS. >>      > > + * It basically stands for the innermost encapsulation level >> RSS >>      > > + * can be performed on according to PMD and device >> capabilities. >>      > > + */ >>      > > +#define ETH_RSS_LEVEL_0         (0ULL << 50) >>      > >>      > I can see from history how this is involved, but the >> 'ETH_RSS_LEVEL_0' >>     naming is >>      > not really clear what it is, the naming in v6 is more clear. >>      > >>      > What about following one: >>      > 0 -> LEVEL_PMD_DEFAULT >>      > 1 -> LEVEL_OUTER >>      > 2 -> LEVEL_INNER >>      > 3 -> LEVEL_INNER_OUTER >>      > >>      > This doesn't exactly match to rte_flow one, but closer than v6 >> one. This ends >>      > with max level 2. And defines a way to say both inner and outer. >> >>     This one looks good to me. If everyone is ok with the proposed >> changes, I >>     will send V8. >> >> How about following one: >> 0 -> LEVEL_PMD_DEFAULT >> 1 -> LEVEL_OUTERMOST >> 2 -> LEVEL_INNERMOST >> >> This way we can avoid any ambiguity especially if stacked tunnel >> headersbecome real. >> >> >> 3 -> LEVEL_INNER_OUTER >> >> But I am not sure if INNER_OUTER has a use case. >> >> Alternatively, >> >> why not just add uint32_t level; >> >> just like in case of rte_flow_action_rss? >> >> It will break ABI but its 20.11. >> >> Thanks >> >> -Ajit >> >> Can I send V8 with this proposal? >> >> 0 -> LEVEL_PMD_DEFAULT >> 1 -> LEVEL_OUTERMOST >> 2 -> LEVEL_INNERMOST >> >> If anyone want INNER_OUTER, they can specify LEVEL_OUTERMOST| >> LEVEL_INNERMOST > > +1 to INNERMOST & OUTERMOST, and use "LEVEL_OUTERMOST| LEVEL_INNERMOST" > for INNER_OUTER. Frankly speaking I'd drop OUTERMOST | INNERMOST for now in requested RSS hash config and defined OUTERMOST | INNERMOST in capabilities as possibility to hash by either INNERMOST or OUTERMOST headers correspondingly. > > But the capability reporting is still problematic. > If @Andrew has no objection, I think it is ok to have a v8 and we can > continue discussion on it. See above. Number of recognized tunnel levels could be reported in dev_info, but looks insufficient, since it is interesting which tunnels are supported (may be even on which level). >> >> >>      > >>      > > + >>      > > +/** level 1,  requests RSS to be performed on the outermost >> packet >>      > > + * encapsulation level. >>      > > + */ >>      > > +#define ETH_RSS_LEVEL_1         (1ULL << 50) >>      > > + >>      > > +/** level 2,  requests RSS to be performed on the >>      > > + * specified inner packet encapsulation level, from >> outermost to >>      > > + * innermost (lower to higher values). >>      > > + */ >>      > > +#define ETH_RSS_LEVEL_2            (2ULL << 50) >>      > >>      > I can see you are trying to copy rte_flow usage, but this >> doesn't really >>     makes >>      > sense here. Where the value of the level is defined in this >> case? If not >>     defined >>      > how the PMD knows which level to use? >>      > >>      > > +#define ETH_RSS_LEVEL_MASK (3ULL << 50) >>      > > + >>      > > +#define ETH_RSS_LEVEL(rss_hf) ((rss_hf & ETH_RSS_LEVEL_MASK) >> >> 50) >>      > > + >>      > >   /** >>      > >    * For input set change of hash filter, if SRC_ONLY and >> DST_ONLY of >>      > >    * the same level are used simultaneously, it is the same >> case as >>      > > -- >>      > > 2.25.1 >>      > > >>