From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 83C043237 for ; Wed, 3 Jun 2015 16:08:10 +0200 (CEST) Received: by wiwd19 with SMTP id d19so54062928wiw.0 for ; Wed, 03 Jun 2015 07:08:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=6OatOOcxKLGrV810rxi+rVENbYPswbE13EClB9XZZxs=; b=eaO8vtaDM08pDQY+HnEPGNJPf0ygn0sJ5Z4jZcqpRb6wvqCirMpKq6vQDjE9atM2qp YEx9RbdY5MgQff2Dfpkq/H8REU6s1K1tyKe5e0uKRQgO2wju/9FGu9JCsdXjmtuCDsGc sbjgzWArW9q/3Qby1ZTWnNhO5jzTxZ4VOK6IHZiRczMaiXpU9640Jlx+cdoWOxghZJ7Z VHkU8QLd2Yk3E31R+cMpvQLDs5e3Bt6WhhvHbqYVyPoN/tRXGnDb4Ulxci80iD9JJkw6 jmjqh+Pzf8F7PMqE2rcrphDWXYMcHAErqFtf/lMzVLHueAAwqnyZlM9SFe4KWZkcgFOC RvAw== X-Gm-Message-State: ALoCoQmHcvuAedoylCwqVo+x+inIzHUv8Z0b6DTNpkuskFBobKUyN+a9NaOaYvDtrTRRw9JFGeBK X-Received: by 10.195.13.1 with SMTP id eu1mr62238242wjd.131.1433340490383; Wed, 03 Jun 2015 07:08:10 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id di7sm1849844wib.23.2015.06.03.07.08.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2015 07:08:09 -0700 (PDT) From: Thomas Monjalon To: Vladimir Medvedkin Date: Wed, 03 Jun 2015 16:07:18 +0200 Message-ID: <2783732.C59rBDiv7h@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1431097092-19790-1-git-send-email-medvedkinv@gmail.com> References: <1430832011-17764-1-git-send-email-medvedkinv@gmail.com> <1431097092-19790-1-git-send-email-medvedkinv@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] Add toeplitz hash algorithm used by RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2015 14:08:10 -0000 2015-05-08 10:58, Vladimir Medvedkin: > Software implementation of the Toeplitz hash function used by RSS. > Can be used either for packet distribution on single queue NIC > or for simulating of RSS computation on specific NIC (for example > after GRE header decapsulating). > > v3 changes > - Rework API to be more generic > - Add sctp_tag into tuple > > v2 changes > - Add ipv6 support > - Various style fixes > > Signed-off-by: Vladimir Medvedkin > --- > lib/librte_hash/Makefile | 1 + > lib/librte_hash/rte_thash.h | 207 ++++++++++++++++++++++++++++++++++++++++++++ Without any comment, it seems this v3 is approved. Maybe that this patch would be even better by implementing some unit tests. I wonder if the hash chapter of the prog guide could list the different algorithms and why/when use them? Thanks