From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60DFCA04B1; Wed, 23 Sep 2020 22:54:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AFDBB1DB3D; Wed, 23 Sep 2020 22:54:00 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 738601DB3C for ; Wed, 23 Sep 2020 22:53:58 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 3B01158015D; Wed, 23 Sep 2020 16:53:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 23 Sep 2020 16:53:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= YQDSp+R4WoznkJqX7vp8jHNELrZRmQL4TXVQc3wubOg=; b=jc2xGiP1lTlGlqrY aH136ZxUreSerr/04wB4hY7nDyjLSn7i9rXpylRrUVMG2i+43PyfJ6xy6OxNabwH 6wTHEFVSmY1R2+B11eMRav7Pk/w3bAi6tRRymN+aBXFPSe6DmmUI6s0C861S+vDE WvQTfNJR/qEHpmFDJ9Wq7Sol9Xg8sRmnUl55+PDYt/9y9RsVZJSqXVmpqzsvbIXP 0uyARVCHuif/pH92awDV2eSlbvoHu+TOkSTRm7NDSpshDuWitHx9ymsmTnLQswsO zvC0emfNn015JLznt7j4MDmP7i9srYYObqHuLOVNhn1dUZ9ayj/SLeIhypciFbIQ OWzS6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=YQDSp+R4WoznkJqX7vp8jHNELrZRmQL4TXVQc3wub Og=; b=asQ/I/yk/JtRgxdBQd3v6fZFNP0KGEY5tH/rcNYZNFJUzTSJhh5A0/kwl 3zw5Bgna1n8/cec0Ka2NBGlRDjzeDvnE6QtC6xxOxV1gtQmZs49heDDnqKzRBzFS GkyyhXQcReClLBoTHWgm/iMOCtjvQNiiJuOxg+h2CEGZxrSjOZQlt7XwHKBo0KjY hijZKU8OLa3F+rtuiWrZJWKUAly29pWBh1uvir4aB/V725YQZiGgY/qPEDJY1ric 4WsCQ7gCg2fWPVn0cYdVMS1wTGi4QRpVK1ZAthxz2e33e0qc+NoMrpnK1t6joWcy nrYb/h9+4qAqxo/s2bOjVPScaqFDg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigdduheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 154DF3280059; Wed, 23 Sep 2020 16:53:46 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, arybchenko@solarflare.com, "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wei Zhao , Jeff Guo , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang Date: Wed, 23 Sep 2020 22:53:46 +0200 Message-ID: <2789130.svnmZjVqCQ@thomas> In-Reply-To: <3cec8608-ff68-5749-7d6d-b97a3d5f3fcf@intel.com> References: <20200913220711.3768597-1-thomas@monjalon.net> <20200913220711.3768597-3-thomas@monjalon.net> <3cec8608-ff68-5749-7d6d-b97a3d5f3fcf@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/09/2020 18:41, Ferruh Yigit: > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > The device operation .dev_close was returning void. > > This driver interface is changed to return an int. > > > > Note that the API rte_eth_dev_close() is still returning void, > > although a deprecation notice is pending to change it as well. > > Why not update the 'rte_eth_dev_close()' in this patch? After the > updates below it should be easier. Yes it is a step in the right direction. Changing the API means adding some error checks in every apps. The reason for not doing is that I did not commit for this task, and I am not the author of the deprecation notice. We can discuss how to follow up once this series is merged.