From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id 7855737AC for ; Wed, 12 Oct 2016 17:36:43 +0200 (CEST) Received: by mail-lf0-f52.google.com with SMTP id b81so80397435lfe.1 for ; Wed, 12 Oct 2016 08:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=UR29duspdL6N6c7FbCAcPiBIstwgjDh5RrNzXxtVr5w=; b=QFbopB5Y08ogd2051BMvD7HGjFoyOJxx32k6pVkc38kLFomazeYGG+oARai26ZNzE2 aFpca3yjgGXIoP4NR+HaqfvdTCDziesNfhbWgbMkgbbGZvVg4d/1NXRJ7lOvY+jNwoZJ N8yd59vj4hVlZJAGD1fE6VS3/9Dl+yWb0AqyAHKrfOFUUZKCqeHUCrDiiEkRkczLzIwT NSgB429TzFhnUGmm29RIi7tcZqAmV3e5DgVqO0diN4ar/SmDIYjaIJFdWaUaMidLFnnr 31iec+NU/2gIQla/HOA6wi6VxnQZVb3IRhc6OCvgQD1LSANdxmVOs8k2iq7kQE74pNEc LRog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=UR29duspdL6N6c7FbCAcPiBIstwgjDh5RrNzXxtVr5w=; b=ETXMs794wNKZXWpoElCgHshZIK3f5tkEmyqml5NQ5Gdnh5U8L5c2cyMd04Oe4DzjEi rig3UNSvJEihTPAnWNxOEeoBNTdf3o3ysJi2SJyl5VdteLUuJp9tGWKtKs1OaHQ5o33+ oCyV4pfJtE8Gim/4z5CkhuPDnpsr9OUicBaLhKELAlu/6rKjMCI1LUTxnKXOwyaUwJde kHz+GuAQDaWY70P+590uNkusB3PtSqAuA5xhmjeCOZ5GivxQ1rEgXDcPu9M4kMryJOor l//us05/VrkyYEf5Hp5awX7wtr9AnI0a805PYPiHUnNXaUgEk07gfi2lpAOQu99iLgar JxmA== X-Gm-Message-State: AA6/9Rnyv/tOWZMF/F+WqVTBTcbU7ZjTkv1u2dpsHj7URCSEQIamexN660aMnGFdxDybzZYu X-Received: by 10.25.152.130 with SMTP id a124mr2154865lfe.33.1476286603051; Wed, 12 Oct 2016 08:36:43 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u68sm2384146lfg.31.2016.10.12.08.36.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Oct 2016 08:36:42 -0700 (PDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: dev@dpdk.org, "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , "De Lara Guarch, Pablo" Date: Wed, 12 Oct 2016 17:36:41 +0200 Message-ID: <2791430.Y8ncTCNxt5@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A092012@IRSMSX108.ger.corp.intel.com> References: <1475858784-5303-1-git-send-email-bernard.iremonger@intel.com> <2251153.ZmgGxBf8Fs@xps13> <8CEF83825BEC744B83065625E567D7C21A092012@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 15:36:43 -0000 2016-10-12 15:27, Iremonger, Bernard: > Hi Thomas, > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new > > API's > > > > 2016-10-12 16:03, Bernard Iremonger: > > > --- a/app/test-pmd/Makefile > > > +++ b/app/test-pmd/Makefile > > > @@ -58,6 +58,17 @@ SRCS-y += csumonly.c SRCS-y += icmpecho.c > > > SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c > > > > > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) > > > +LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe endif > > > + > > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > > > +LDLIBS += -lrte_pmd_ixgbe > > > +endif > > > +endif > > > > Sorry if I miss something, but I thought it was enough to do: > > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > No unfortunately not, the above line does not work for all scenarios . > > There are 4 scenarios as follows: > > CONFIG_RTE_LIBRTE_IXGBE_PMD=y with CONFIG_RTE_BUILD_SHARED_LIB=n > > CONFIG_RTE_LIBRTE_IXGBE_PMD=y with CONFIG_RTE_BUILD_SHARED_LIB=y > > CONFIG_RTE_LIBRTE_IXGBE_PMD=n with CONFIG_RTE_BUILD_SHARED_LIB=y > > CONFIG_RTE_LIBRTE_IXGBE_PMD=n with CONFIG_RTE_BUILD_SHARED_LIB=n > > I have been doing quite a bit of building today to get it to work in all 4 scenarios. I have a doubt about the tests because LDLIBS-y does not exist. There is _LDLIBS-y and LDLIBS. But in the static case, you wrote: LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe endif Please could you check?