From: Thomas Monjalon <thomas@monjalon.net>
To: Phil Yang <phil.yang@arm.com>
Cc: erik.g.carrillo@intel.com, dev@dpdk.org,
david.marchand@redhat.com, rsanford@akamai.com,
Honnappa.Nagarahalli@arm.com, Gavin.Hu@arm.com, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH v4] lib/timer: relax barrier for status update
Date: Sun, 26 Apr 2020 22:06:49 +0200 [thread overview]
Message-ID: <2791852.BQQF58Tnoo@thomas> (raw)
In-Reply-To: <1587912315-1819-1-git-send-email-phil.yang@arm.com>
26/04/2020 16:45, Phil Yang:
> Volatile has no ordering semantics. The rte_timer structure defines
> timer status as a volatile variable and uses the rte_r/wmb barrier
> to guarantee inter-thread visibility.
>
> This patch optimized the volatile operation with c11 atomic operations
> and one-way barrier to save the performance penalty. According to the
> timer_perf_autotest benchmarking results, this patch can uplift 10%~16%
> timer appending performance, 3%~20% timer resetting performance and 45%
> timer callbacks scheduling performance on aarch64 and no loss in
> performance for x86.
>
> Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Applied, thanks
next prev parent reply other threads:[~2020-04-26 20:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 6:42 [dpdk-dev] [PATCH 1/2] lib/timer: protect timer subsystem initialized with lock Phil Yang
2020-02-24 6:42 ` [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update Phil Yang
2020-04-08 10:23 ` Phil Yang
2020-04-08 21:10 ` Carrillo, Erik G
2020-04-08 21:16 ` Honnappa Nagarahalli
2020-04-08 21:26 ` Carrillo, Erik G
2020-04-08 21:56 ` Honnappa Nagarahalli
2020-04-09 19:29 ` Carrillo, Erik G
2020-04-10 4:39 ` Phil Yang
2020-04-20 16:05 ` [dpdk-dev] [PATCH v2] " Phil Yang
2020-04-23 20:06 ` Honnappa Nagarahalli
2020-04-24 1:26 ` Carrillo, Erik G
2020-04-24 7:27 ` Phil Yang
2020-04-24 7:24 ` [dpdk-dev] [PATCH v3] " Phil Yang
2020-04-25 17:17 ` Thomas Monjalon
2020-04-26 7:36 ` Phil Yang
2020-04-26 12:18 ` Carrillo, Erik G
2020-04-26 14:20 ` Phil Yang
2020-04-26 19:30 ` Carrillo, Erik G
2020-04-26 14:45 ` [dpdk-dev] [PATCH v4] " Phil Yang
2020-04-26 20:06 ` Thomas Monjalon [this message]
2020-04-25 14:36 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-04-25 15:51 ` Phil Yang
2020-04-25 16:07 ` Thomas Monjalon
2020-02-25 22:26 ` [dpdk-dev] [PATCH 1/2] lib/timer: protect timer subsystem initialized with lock Carrillo, Erik G
2020-04-25 17:21 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2791852.BQQF58Tnoo@thomas \
--to=thomas@monjalon.net \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=nd@arm.com \
--cc=phil.yang@arm.com \
--cc=rsanford@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).