From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D306CA00BE; Sun, 26 Apr 2020 22:06:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB91A1C1AD; Sun, 26 Apr 2020 22:06:53 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C62221C1A1 for <dev@dpdk.org>; Sun, 26 Apr 2020 22:06:52 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 3F13A5C00E3; Sun, 26 Apr 2020 16:06:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 26 Apr 2020 16:06:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= lfOcZm47APC8sBEmXonykPTZ6hv1ytu60UmlXW4JWxU=; b=jN60S8AJlohswaQJ FowZu+Zvdp2HCcwz/QfR9J1IUMxHQHTx3ijyMJ5bE7TeUltQEGEztbZ+yarW/i2w Xr8j6Hw4zylqEWQZPcQzFOlCcNDMJ6l0CK5oC3Z4NMHgLck9TIZNOVtJzErTirZG dUaJh1AF/VRwFHUdOj/B8/WfzxVKtxjLqxaEjSoLsLB11pOcvsXk9iRrC7ZzrCe5 ZG00jCpQB9OYH63c/02heyuxSfLGIwQFKqitpEM3MjlyDZ8FZvs3uo8VjJIb5ExG tGIw7zH09+qAgLRSMbKHoY3ka8X5EVISDujxDetvfKfqmtfyB3ntyJ07d37yZ/gF NpHYLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=lfOcZm47APC8sBEmXonykPTZ6hv1ytu60UmlXW4JW xU=; b=CsWJjBYKGpqL/Eat3SY8rGJsGW6990Axesxn97NDaxt44QtrHUS9fUUOp i42iHnrUI/fBPZRNKBnK6rEKWak+T11ek77PhRAFlOIjyBftpO6LLETs5ST0Ewp1 tv4eFS9guYnkef0arfJUBTm8uVB7uTp5dGFZsntkzOltMj0/XSnFo8I1UyC6CHiV ylBJa1T0lp4sEcjMP56jhLzWGmXblm+Nj6VQZ58lM07C9Ld7zOsoqm0QhFtOsg3o aElQouhy6EtiTImGjoU1F8oyFaTbNMOLXKStg3ZBejTRmkrDJJ+96vG/scB8TnXl jR7hzELK9fslfqa9X6ap5zJEXk75g== X-ME-Sender: <xms:2-mlXlHHblIRFmCXJ_pGA2iHgKZ5DPm9E0j1PVHoNraOkcUh4eBDpA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehhuhgrrhhmrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomh grshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:2-mlXlzxf-uCN7QQhN8AlbnxIynXcpooUT1OI1w8-4tVHOofBZOSHQ> <xmx:2-mlXqp_DQlmOSxp8RsWXyyQFgqD1oyPTnBg_Rvnkk5J02GbKSka3g> <xmx:2-mlXvj9VjNa-FOhdfx2kpdeHZ0HMuJWF5G5HlQvsBB9eYLCLJjA5A> <xmx:3OmlXmhYbzFJfk82hayYLrg6UZ6_N-muW1xVTym3H66Ey4z1X-pA2A> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E02973280059; Sun, 26 Apr 2020 16:06:50 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Phil Yang <phil.yang@arm.com> Cc: erik.g.carrillo@intel.com, dev@dpdk.org, david.marchand@redhat.com, rsanford@akamai.com, Honnappa.Nagarahalli@arm.com, Gavin.Hu@arm.com, nd@arm.com Date: Sun, 26 Apr 2020 22:06:49 +0200 Message-ID: <2791852.BQQF58Tnoo@thomas> In-Reply-To: <1587912315-1819-1-git-send-email-phil.yang@arm.com> References: <1587713042-527-1-git-send-email-phil.yang@arm.com> <1587912315-1819-1-git-send-email-phil.yang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] lib/timer: relax barrier for status update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 26/04/2020 16:45, Phil Yang: > Volatile has no ordering semantics. The rte_timer structure defines > timer status as a volatile variable and uses the rte_r/wmb barrier > to guarantee inter-thread visibility. > > This patch optimized the volatile operation with c11 atomic operations > and one-way barrier to save the performance penalty. According to the > timer_perf_autotest benchmarking results, this patch can uplift 10%~16% > timer appending performance, 3%~20% timer resetting performance and 45% > timer callbacks scheduling performance on aarch64 and no loss in > performance for x86. > > Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > Signed-off-by: Phil Yang <phil.yang@arm.com> > Reviewed-by: Gavin Hu <gavin.hu@arm.com> > Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com> Applied, thanks