From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A2860A0C43;
	Tue, 19 Oct 2021 10:59:44 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6A0E840142;
	Tue, 19 Oct 2021 10:59:44 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id DCD3A4003E
 for <dev@dpdk.org>; Tue, 19 Oct 2021 10:59:43 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 5B8D67F56B;
 Tue, 19 Oct 2021 11:59:43 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 5B8D67F56B
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634633983;
 bh=BmYD5rmxZWTloOuVF5Pgsq88HFn2TDUf5bm1YLMjM4k=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=fUWLjYbGs6eC6hy/8lCHhnEiHVNi6qAEJGRrnukH95Gr5bioFQemldNtH2wDlKuIC
 mcGycgzYvcGu50as6mtDwGRFHPLo+axFWHireK4D2+rg/TNVvTYPb0IT0EpEO6Aj6z
 CM3EGppqI9HDOiM10jHCD/30zTqwgBhzkO6jNvKs=
To: David Marchand <david.marchand@redhat.com>
Cc: Olivier Matz <olivier.matz@6wind.com>, Ray Kinsella <mdr@ashroe.eu>,
 dev <dev@dpdk.org>
References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru>
 <20211018144907.1145028-5-andrew.rybchenko@oktetlabs.ru>
 <CAJFAV8zMGfGOOv_XYLojgB7eP0DgK0auNXsqY=f0RPPwn96EnQ@mail.gmail.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <279308f9-7b6f-2254-4e26-69ecb17f153f@oktetlabs.ru>
Date: Tue, 19 Oct 2021 11:59:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJFAV8zMGfGOOv_XYLojgB7eP0DgK0auNXsqY=f0RPPwn96EnQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 4/6] mempool: make header size calculation
 internal
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/19/21 11:48 AM, David Marchand wrote:
> On Mon, Oct 18, 2021 at 4:49 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> Add RTE_ prefix to helper macro to calculate mempool header size and
>> make it internal. Old macro is still available, but deprecated.
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> No reference to this macro out there:
> $ git grep-all -w MEMPOOL_HEADER_SIZE
> 
> 
> The change looks fine to me.
> I just wonder if we really need to expose this helper, is it
> performance sensitive?
> 

As far as I can see it is used by rte_mempool_get_priv()
which is inline and could be used on datapath.