From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id BEFF16CCD for ; Mon, 29 Feb 2016 16:58:20 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id p65so74991413wmp.1 for ; Mon, 29 Feb 2016 07:58:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=6F8G9tcYfZKQz2KEL2OT8Dq5prw4OA7hgR6W+F952hE=; b=FK6UAJfFdDkEhB6HXLK7OcGAQcC3IM8z+1hm7LIuiR2TzXK6eUoVBsBuZVd0hdX4yQ 6K2BST5tnPOXpxHpgLF+/QVO3yVa/wHlnGj4iG4tTIDmimmVmugN/UxMZjVT+S5JgSSY Sco8JYZoaAleJW5JUS8H+DGwH4BwNg6z3RAK0nBZLl+gbMVNQgB3+N6LwzW5xzJYW6KO XmfuxRE2LUuT8+y0ranSLEeg5nPKQOxgejcK352CqV1O2TjyQd4J9boMuj5n+1TqelF/ wv+W9tEqj7sKs7zkhkAlp5tVEJTWvhwqqxAfER+yBqim22fshpSMd54I74KgCAuLcloQ Sipg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=6F8G9tcYfZKQz2KEL2OT8Dq5prw4OA7hgR6W+F952hE=; b=bAsSQTQIMhOYCAv4XSzANooJbU9vvAZpbvry3Qf2Vr9rFRJWG+eoXTkxtXfHIC3Qke MQL70z5q6zqwKq9KdzhzMeayc4vptba1HVMAsA7DKDWQ3/qCl2Yjpw5OM9ystoEjUCmE v1L+jq928zfNUkWvmJ3LvKu00Mk0rpV88pcQPPW0LgmJW+p1bzGSJRFGkaZBPnXAMkL2 CrnwFalwPTqJBdGnqcRNrworj5dhtSVvYLl+iuo6o7QkQ9gwj1uPX2aMcQeS6/OPrTRl j8Z8h50cM3iAv/pMEktgXtxtwCGoa32fdzGRNPUaoqr8VuMzxUX1sRbb7wmXCCpdjsC5 rZ9w== X-Gm-Message-State: AD7BkJIflOAvCd/h7wAKG158YQJdAiTQWbPq0q2ihdge15oZtu7SydhVeFmqI1Jf0Z9aDaIc X-Received: by 10.194.78.37 with SMTP id y5mr15374044wjw.78.1456761500579; Mon, 29 Feb 2016 07:58:20 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id w144sm16944639wmd.8.2016.02.29.07.58.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 29 Feb 2016 07:58:19 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Date: Mon, 29 Feb 2016 16:56:45 +0100 Message-ID: <2798431.Y7FIAzYVRH@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1456151771-15382-1-git-send-email-yuanhan.liu@linux.intel.com> References: <20160219070326.GR21426@yliu-dev.sh.intel.com> <1456151771-15382-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: "Michael S. Tsirkin" , dev@dpdk.org, Victor Kaplansky Subject: Re: [dpdk-dev] [PATCH] vhost: broadcast RARP pkt by injecting it to receiving mbuf array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 15:58:20 -0000 2016-02-22 22:36, Yuanhan Liu: > The wrong mac table lead all the packets to the VM go to the "ovsbr0" > in the end, which ends up with all packets being lost, until the guest > send a ARP quest (or reply) to refresh the mac learning table. > > Jianfeng then came up with a solution I have thought of firstly but NAKed > by myself, concerning it has potential issues [0]. The solution is as title > stated: broadcast the RARP packet by injecting it to the receiving mbuf > arrays at rte_vhost_dequeue_burst(). The re-bring of that idea made me > think it twice; it looked like a false concern to me then. And I had done > a rough verification: it worked as expected. > > [0]: http://dpdk.org/ml/archives/dev/2016-February/033527.html > > Another note is that while preparing this version, I found that DPDK has > some ARP related structures and macros defined. So, use them instead of > the one from standard header files here. > > Cc: Thibaut Collet > Suggested-by: Jianfeng Tan > Signed-off-by: Yuanhan Liu Applied, thanks