Re: [dpdk-dev] [PATCH] doc: add virtio GUEST ANNOUNCE to release notes

Re: [dpdk-dev] [PATCH] doc: add virtio GUEST ANNOUNCE to release notes

[Mcnamara, John]

> -----Original Message-----
> From: Wang, Xiao W
> Sent: Friday, February 9, 2018 2:28 PM
> To: dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>; thomas@monjalon.net; Wang,
> Xiao W <xiao.w.wang@intel.com>
> Subject: [PATCH] doc: add virtio GUEST ANNOUNCE to release notes
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>  doc/guides/rel_notes/release_18_02.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_18_02.rst
> b/doc/guides/rel_notes/release_18_02.rst
> index c42a1d64b..d9718c174 100644
> --- a/doc/guides/rel_notes/release_18_02.rst
> +++ b/doc/guides/rel_notes/release_18_02.rst
> @@ -230,6 +230,12 @@ New Features
>    current build system using ``make``. For instructions on how to do a
> DPDK build
>    using the new system, see the instructions in ``doc/build-sdk-
> meson.txt``.
> 
> +* **Added VIRTIO_NET_F_GUEST_ANNOUNCE feature support in virtio pmd.**
> +
> +  In scenario where the vhost backend doesn't have the ability to
> + generate RARP  packet, the VM running virtio pmd can still be live
> + migrated if  VIRTIO_NET_F_GUEST_ANNOUNCE feature is negotiated.
> +
>  .. note::
> 
>      This new build system support is incomplete at this point and is
> added

The text has been added between the previous section and a note belonging
to the previous section.

However, we can fix this in the final revision of the release notes, so:

Acked-by: John McNamara <john.mcnamara@intel.com>

[dpdk-dev] [PATCH] doc: add virtio GUEST ANNOUNCE to release notes

[Xiao Wang]

Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
 doc/guides/rel_notes/release_18_02.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
index c42a1d64b..d9718c174 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -230,6 +230,12 @@ New Features
   current build system using ``make``. For instructions on how to do a DPDK build
   using the new system, see the instructions in ``doc/build-sdk-meson.txt``.
 
+* **Added VIRTIO_NET_F_GUEST_ANNOUNCE feature support in virtio pmd.**
+
+  In scenario where the vhost backend doesn't have the ability to generate RARP
+  packet, the VM running virtio pmd can still be live migrated if
+  VIRTIO_NET_F_GUEST_ANNOUNCE feature is negotiated.
+
 .. note::
 
     This new build system support is incomplete at this point and is added
-- 
2.15.1

Re: [dpdk-dev] [PATCH] doc: add virtio GUEST ANNOUNCE to release notes

[Thomas Monjalon]

09/02/2018 10:56, Mcnamara, John:
> From: Wang, Xiao W
> > +* **Added VIRTIO_NET_F_GUEST_ANNOUNCE feature support in virtio pmd.**
> > +
> > +  In scenario where the vhost backend doesn't have the ability to
> > + generate RARP  packet, the VM running virtio pmd can still be live
> > + migrated if  VIRTIO_NET_F_GUEST_ANNOUNCE feature is negotiated.
> > +
> >  .. note::
> > 
> >      This new build system support is incomplete at this point and is
> > added
> 
> The text has been added between the previous section and a note belonging
> to the previous section.

Please, can you merge this text with the item added by Jiayu about migration?

Re: [dpdk-dev] [PATCH] doc: add virtio GUEST ANNOUNCE to release notes

[Thomas Monjalon]

14/02/2018 00:31, Thomas Monjalon:
> 09/02/2018 10:56, Mcnamara, John:
> > From: Wang, Xiao W
> > > +* **Added VIRTIO_NET_F_GUEST_ANNOUNCE feature support in virtio pmd.**
> > > +
> > > +  In scenario where the vhost backend doesn't have the ability to
> > > + generate RARP  packet, the VM running virtio pmd can still be live
> > > + migrated if  VIRTIO_NET_F_GUEST_ANNOUNCE feature is negotiated.
> > > +
> > >  .. note::
> > > 
> > >      This new build system support is incomplete at this point and is
> > > added
> > 
> > The text has been added between the previous section and a note belonging
> > to the previous section.
> 
> Please, can you merge this text with the item added by Jiayu about migration?

Applied as it is reworded in the final release notes patch by John.