From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E88C34F91; Fri, 1 Jun 2018 17:07:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2018 08:07:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,467,1520924400"; d="scan'208";a="60460660" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.101]) ([10.237.220.101]) by fmsmga001.fm.intel.com with ESMTP; 01 Jun 2018 08:07:29 -0700 To: Dariusz Stojaczyk , dev@dpdk.org Cc: stable@dpdk.org References: <1527860361-162114-1-git-send-email-dariuszx.stojaczyk@intel.com> <1527857960-109306-1-git-send-email-dariuszx.stojaczyk@intel.com> <1527857960-109306-2-git-send-email-dariuszx.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: <279b09b4-6425-ccac-e512-003d8a6b3e2a@intel.com> Date: Fri, 1 Jun 2018 16:07:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1527857960-109306-2-git-send-email-dariuszx.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/2] memalloc: keep in mind a failed MAP_FIXED mmap may still perform an unmap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 15:07:32 -0000 On 01-Jun-18 1:59 PM, Dariusz Stojaczyk wrote: > This isn't documented in the manuals, but a failed > mmap(..., MAP_FIXED) may still unmap overlapping > regions. In such case, we need to remap these regions > back into our address space to ensure mem contiguity. > We do it unconditionally now on mmap failure just to > be safe. > > Verified on Linux 4.9.0-4-amd64. I was getting > ENOMEM when trying to map hugetlbfs with no space > left, and the previous anonymous mapping was still > being removed. > > Changes from v2: > * added "git fixline" tags > > Changes from v1: > * checkpatch fixes > * remapping is now done regardless of the mmap errno > > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Dariusz Stojaczyk > --- Acked-by: Anatoly Burakov Version changes should not be part of commit message. Thomas, could you please fix this on apply? -- Thanks, Anatoly