From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68FC6A034F; Mon, 22 Feb 2021 16:28:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5787F1CC502; Mon, 22 Feb 2021 16:28:56 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 877C04003C; Mon, 22 Feb 2021 16:28:55 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 0AEFB5814C0; Mon, 22 Feb 2021 10:28:54 -0500 (EST) Received: from imap22 ([10.202.2.72]) by compute1.internal (MEProxy); Mon, 22 Feb 2021 10:28:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=+7y0TgA1DC9hD+QSEeJTSATd5HhMifs dUkG0O+R6g3o=; b=YqhX935g7Z7U2JqghC7QuTxZrTOeh5ec0oA9GJrRNnc+kh9 OqluGussd9RN5cPWDrmthBwze3MfkYWcaSOSwBWqUTpfoHiIIgDRpmW5+c3fUxhu AzWsfkmnJx8tqk01AKXl9fB1vKDpeh+bKdJe4XEdPA45kWYNwGKOPEnu57lT7QAx he0XFs7TdZMEXMFaLIsdaTz+VF5yfBkIfUgYtz7q86rGy4tc4x+RY0ScUagAQtPy 90pZkeU1HGm3qKJZ34ojb0h9jX9fnH0Yfc1G+BpJ1p9nedUScQkLPtckzyEE9jyT nh6VleAQyP0nuE6OWbDVUPW9ZYceJoxpm1VLznw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+7y0Tg A1DC9hD+QSEeJTSATd5HhMifsdUkG0O+R6g3o=; b=Hln+TgrLplN5XNigwM2Cdz kFxaMIkxWvLKrnCW2dRTO4W0NjmFH5Sb5GjEdKNm2c2zaUSHptbCOlAm/gukUVjw 5BAqcH5nHPwnSY2mp1GgheWxVijeBDWaZj5SCTMPmJgo+Px+q5Ty1VW+Ivus0k13 yjDO6ZrKgTfs3cgG9aaqR3WKCdy8hMc/9M8cYQIHTvnAvBMJrHHrb1reTYA/KXkK FIaT+e0GZma0DSJDPJ96ARidDDHosNx8I0j6MUc9kFVKOh83O7JlgTu5ISBLIXX9 6UBvztz6eRUrid7Zd9tX7sOL1F9GZZJi+1dZWe85lf4/hMRPFL9yRNKjNa8fqLaw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrkeefgdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpefirgotthgr nhgptfhivhgvthcuoehgrhhivhgvsehuvdehiedrnhgvtheqnecuggftrfgrthhtvghrnh epgfeuhfffleeludeuheeuteeufeegtdeiveduudfhgeevteeutdelueffueehkeefnecu vehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepghhrihhvvg esuhdvheeirdhnvght X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6779662C006A; Mon, 22 Feb 2021 10:28:52 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-141-gf094924a34-fm-20210210.001-gf094924a Mime-Version: 1.0 Message-Id: <27c32461-7795-47a4-8178-c11e292ec6c4@www.fastmail.com> In-Reply-To: <20201222085149.848142-1-andrew.rybchenko@oktetlabs.ru> References: <20201222085149.848142-1-andrew.rybchenko@oktetlabs.ru> Date: Mon, 22 Feb 2021 15:28:02 +0000 From: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= To: "Andrew Rybchenko" , dev@dpdk.org Cc: stable@dpdk.org, "Andrew Rybchenko" , "Ian Stokes" , "Stephen Hemminger" , "Ferruh Yigit" Content-Type: text/plain Subject: Re: [dpdk-dev] =?utf-8?q?=5BPATCH=5D_net/failsafe=3A_report_minimum_?= =?utf-8?q?and_maximum_MTU_in_device_info?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Dec 22, 2020, at 08:51, Andrew Rybchenko wrote: > Take minimum and maximum MTU values for subdevices and > report maximum of minimums and minimum of maximums. > > Fixes: ad97ceece12c ("ethdev: add min/max MTU to device info") > Cc: stable@dpdk.org > > Signed-off-by: Andrew Rybchenko > --- > drivers/net/failsafe/failsafe_ops.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/failsafe/failsafe_ops.c > b/drivers/net/failsafe/failsafe_ops.c > index 76d64871b4..5e6fb369e1 100644 > --- a/drivers/net/failsafe/failsafe_ops.c > +++ b/drivers/net/failsafe/failsafe_ops.c > @@ -1095,6 +1095,8 @@ static void > fs_dev_merge_info(struct rte_eth_dev_info *info, > const struct rte_eth_dev_info *sinfo) > { > + info->min_mtu = RTE_MAX(info->min_mtu, sinfo->min_mtu); > + info->max_mtu = RTE_MIN(info->max_mtu, sinfo->max_mtu); > info->max_rx_pktlen = RTE_MIN(info->max_rx_pktlen, > sinfo->max_rx_pktlen); > info->max_rx_queues = RTE_MIN(info->max_rx_queues, > sinfo->max_rx_queues); > info->max_tx_queues = RTE_MIN(info->max_tx_queues, > sinfo->max_tx_queues); > @@ -1172,6 +1174,8 @@ fs_dev_infos_get(struct rte_eth_dev *dev, > int ret; > > /* Use maximum upper bounds by default */ > + infos->min_mtu = RTE_ETHER_MIN_MTU; > + infos->max_mtu = UINT16_MAX; > infos->max_rx_pktlen = UINT32_MAX; > infos->max_rx_queues = RTE_MAX_QUEUES_PER_PORT; > infos->max_tx_queues = RTE_MAX_QUEUES_PER_PORT; > -- > 2.29.2 > > Hi Andrew, Sorry, I missed this patch before. It looks ok to me: Acked-by: Gaetan Rivet