From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BDC5423FF; Tue, 17 Jan 2023 18:01:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6896C40151; Tue, 17 Jan 2023 18:01:48 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2054.outbound.protection.outlook.com [40.107.96.54]) by mails.dpdk.org (Postfix) with ESMTP id 4BC70400D4 for ; Tue, 17 Jan 2023 18:01:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PllzQJzz1T72AQTF/YJZpLxOjzW8crgyqGnwrbvWFAQv0Y4EweV7fpkI1dROgd5mzp1twvi1pxJsgy7+Ft02UaAyXz6Wde5tMGxzkJG9ic+3r4HVxCD/K0S0yoZq6GjBlhsfV13v6v9FDHEdqOw1QS08V3cF8MeUBfGzIrpSu8SKWtjXAolwzSf0iLGwp/7UXb/6B7BhuS8dfjRlDdrrO+aGzJ68EQPumMSQwqomB7JIQIzx+CadYxPWW6oWsnFzHnbNPQwbDi06uMKeq12NV4JgcPv73JeeFAoy1GdBh5coyULznYS/2Q95U8XB+pcI5US7OM8fjySKXgqiftNraw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GbEVUH027n1mwHCmFGHVteWbHuJwqsCYUFkyMVHqqOs=; b=cST13DQSRqY9ZXH+76dURFjEkJyWzWiljkXxndwxBbLGCRY7hPumDTVR6wyZO30qiCaXYytb5SjljgPb+WGC6fkt2tml/BY0QgLv3sRYSmGVhtebN6HnDyRNsumWS+QmaH9WJKU1cMESVwW4/ehE2CvqtdvHxyniDvOP6ll8VPo1np/m3QlkjOomR5B+6xC3/JXLwaxP3RUC0Gv2P8xJ8dDMRAR7JbMTHYusp+WS2KyBk50MJctx5qdiSMEFq7rRmFDiYtetccxBYG6fWpmNZcsMsEoxhByjsVEA5nOVx0qtQuy5trlBzX0Wv0NM4T8mJmurM1WNN3jiAH/dTWtr2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GbEVUH027n1mwHCmFGHVteWbHuJwqsCYUFkyMVHqqOs=; b=HwsL52Dfr/BPiRL/5xs9cfjpXD5jzEj9L7ZgutqhwMPpVDNLpE7xp/YW2xqbjxN2AHiBiFcMiDltBsDZwIRVIaqCFGHJF6d+KYWTvkADm6OIeNU1fy6O0Vd+xEv/MJk00DOaRkajbRRMpWdWcUD/l7TOtn8T8aGCjC1LpYYzSfI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB7740.namprd12.prod.outlook.com (2603:10b6:610:145::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Tue, 17 Jan 2023 17:01:44 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%7]) with mapi id 15.20.5986.023; Tue, 17 Jan 2023 17:01:44 +0000 Message-ID: <27c6183d-1fa5-a4d3-9d5a-081592e9ef5f@amd.com> Date: Tue, 17 Jan 2023 17:01:37 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US From: Ferruh Yigit To: Rongwei Liu , matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, Aman Singh , Yuying Zhang , Andrew Rybchenko , Ivan Malov , thomas@monjalon.net Cc: dev@dpdk.org, rasland@nvidia.com References: <51e583ea-4446-fea5-af74-dfe75d37f05c@oktetlabs.ru> <20221114115946.1074787-1-rongweil@nvidia.com> Subject: Re: [PATCH v7] ethdev: add special flags when creating async transfer table In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0427.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB7740:EE_ X-MS-Office365-Filtering-Correlation-Id: 5db76a91-da32-4002-8d48-08daf8ac82e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m9f1Nl/UqtJzWpxJTDZ9wrZYyaMBPfOELIz3hc+6Fd9XtNDu2HBUoZt1SU20XKBQjLR3hWlFpuINrv8FAdYHy9eZCGcCPZ79Yr4t1cg5797YN2nEz8D6Y/k82LypE+HybqWqZec95aytDeRPeNeiS+ZELYHMkZL4bMI48pXinfd12kYnDlxLg18lTVBlc51p/k/yQEoOUxEgWTUY6tyE6kSYUOQgOHEKvlPHM/dppfm6NyENuTSJKANnKXbz5JarYimx4xtqSYihtxoswAu0vLs/NABWITmKrnCMftF+1u1ij//QQF5ipvCrWQKY2dXGe8shp5vCgSX4/TplyQlHwIm1dmQ3umMUJ/bEYfoecmDQ8wgbcJiaZl8t4gTTzFOZImF7qBUOtiUrMicCow9/Hcl1yBjbjLyvqZcGVwxlD99N5DRZMNmEpzgqwco3i56VdKiIUuKJOTV7KywoC6jfTWNMQwuSDG0sSuc9LxHIHtS3UzkKPiHtT4FdxBlIn2Kq5JERpToMb2yv4IkDbqxOGKrsVXWxhev2jbxXjhM4sJmv7ahc6kqBlhBjMV3MmQvBIv0KVBFo0LaURievUi4ib0wgoav35YcpkOt6csFWlRnTw2RzNplnplD01zNsBpJ8WTddErMK6aWP4mm8q7b2DKhHJg3F5f2IvpYMLcoz5xN5qENPc0s25F1cM4z6vmprCsFow/dIj5uYzb6k16XZ6FlaUxaotADGfbLWUI6jrIQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199015)(31686004)(110136005)(2616005)(316002)(41300700001)(83380400001)(6506007)(66556008)(8676002)(8936002)(4326008)(6666004)(66476007)(44832011)(5660300002)(7416002)(53546011)(2906002)(66946007)(36756003)(38100700002)(6486002)(31696002)(26005)(186003)(478600001)(86362001)(6512007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2FyUDZWb0VhWnFEckpiWlRoL2psNkNDemZqKyszMFhOMjFSSWZhUWNkWnJ0?= =?utf-8?B?MG9zUGdZS1Bmb2RUVFdwR0lPamp3SHdoSHpyRUdlcGhwVUVGNWt5WWZlb1Bp?= =?utf-8?B?eWlQT2ltTjVtU1Z0aVhzNGxIeUpqQklneWRmbjd4QndDUERRaDkrNHpBN1Qr?= =?utf-8?B?dEhDQXJIUDlwN1R6S3Vtd3BZaTZaenFWeU1TemNySjhaeEJ4VTJBQmFJMFl6?= =?utf-8?B?eEo5RmxseWxKMUVJRUlxaXNyOEhnTm9vYzRLN2dwUFVGNHQvVDVTZEF0NU5y?= =?utf-8?B?WW9QdmhKWms0bzFjK2ZrVllqMmhSYTh0eUdQaUVNN01vT1dFM3hjMVhvN0tv?= =?utf-8?B?bk5nZFF2SEN1UGowM1Q1NHVINGZGSk9WeVlIa3Q4Ny9NTXFiYjl2K3FzMHR1?= =?utf-8?B?eVZMdFFjeWZlclFDcjFvRUQ0NS90KzZGbitNSUNvZWJkckpxYnlhNmZEU1Zs?= =?utf-8?B?eWxVSWJXdEUwUVRYZUdjc2VSZXU0N2tpWGVRMlBnOS9laFVqS05KM2NSYXBp?= =?utf-8?B?MFYvYVVNTXhxZkdnZGQ4UTJOcko5UHY5RFNEeEkvV2d1djF5emI5cVo2WVRx?= =?utf-8?B?TGV5N1Q0aVNTK3hwY3dja2FGdEJCRGx5OVhaWHoySzI0TktoVEtRK29ZVGJm?= =?utf-8?B?Q2dSZ3V4aGlnTDVsenhYaGlLNWRGNVNUVUplZ3d0M2FsU2dKRDdDa2pNSkFM?= =?utf-8?B?RHB2MENGcDRtUzJVTlpNMDgxcmNtWHBXTXQ3bHNHTU9BSWtHYmJEWURHWkkz?= =?utf-8?B?Wm1QOXJzRUE1V0JCYjdyUnZQVENmRGoyNFF5aXBOVWVOV3czR0FScEFSVXhS?= =?utf-8?B?cm5OUU0zTUVxeUEvajlISjFIM05BVmkwMGxYaE9ra0tDdURjN2xPeFBoc2VU?= =?utf-8?B?b0cwS0JudnoycXdZRTRTMndpSUpTSHRhZ0dlck5YY3BoMFNRTUd2czMwY3la?= =?utf-8?B?ckdFSUVvS0NVb0ZMSERRTTEvRXc4M2xFcWIybW5KMWJjL25VdjFsTldNbDhQ?= =?utf-8?B?b1dheFVXK2t2NkNXTXp2MEp3b3lkV2hYRUUwTWlVUnlVdlh0OVJmQTZaY2pq?= =?utf-8?B?c1Z4TEFKOERLV2FSQ1YvTXdCc0NtNmh6czlsQ0txU2NPaXVUc3U1UVZkOWRR?= =?utf-8?B?bTZGRnh3Sk9HN2JJSENrZS81WjFOL1NuSjlTYUx0NVd5bm9SRHBBQk9kN2sr?= =?utf-8?B?VThhWlVmbXJyOUpqUk1wRy9ZQmxxOTNhSkZvZTY0YlloK0k0YUZJbXR6YThx?= =?utf-8?B?TjZZT0NseWhyRmVZVEJNREcvRmY5d3VhcmpkZlcwNmlmYjd4NWVRSktJV3Zo?= =?utf-8?B?dDVIYjViUVY0ems4T0FnOEt5V1k2MTRDTUc5QzNaT2g3dXViVDBoVWZjdkho?= =?utf-8?B?T09VN2RGNHM4MWlmYmVHU0UvSUo1SEVibkNzVThCK2NFRW51eFMzNDVDMm1Z?= =?utf-8?B?M1VCMTdRVFA5dllDR3JmcU05T0pxOHJNMEVORUk0OWYveEtGb2ZUQXJBSjQ4?= =?utf-8?B?bXhvTEozTkdXTnJ1eHg3YkdGM1hBKzJuNWxiT3ZvODFrWDM4QlhkakdpWDFh?= =?utf-8?B?YnZ0ZmtQOVYvZUlWU3g3MWRmalVSSnFGY3RlOXVudDB2eWFmZS9ia1RneG04?= =?utf-8?B?ckVJemNlWVpnNnh6KzVpTm9tZEhlYlVFOEIwcHdjNGtYbkx4UU9sUVQzbmlu?= =?utf-8?B?eExWMWZqQjQxTy9BYUdGYStWOC9WMktKRjc1ejVTa1VKbXN0S09tYXRKbGhJ?= =?utf-8?B?eUdvR1I5Qmd6ajl0MTkrdlkxMU5HRXNXM1pNaTd2YVVITmw2VXBrWld5VlQ0?= =?utf-8?B?aWRydE1HeC9qWmZZR05jbDJrL0pFSmpVSFJYeGg4Z29YS3JNNk9SZURJTVdm?= =?utf-8?B?UFBRaVhRYWlFNi9jbit2YVpqTUF3RmM4TjhIT0hYSVRzVkpwdXFwTHlHRzNB?= =?utf-8?B?b1k2MC83TkxaZ0FXb1R6SVAxOGZncWcrS2F0QUdQVUNTQVd4V0xBaVdTcGhi?= =?utf-8?B?UTRkN1R0T3U0OW45VzF4WVZRc3h3VUFsei8rK2lFSWFvb1hscTVuTFlYVG1r?= =?utf-8?B?TzFYZHp3MkdmY0dYSmd6S2txRW45b3VNcVNuUEEvWGtLVWhJb0Mxa29hckRV?= =?utf-8?Q?gaPS+LsVw5+fKxZJlnnvSogva?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5db76a91-da32-4002-8d48-08daf8ac82e3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 17:01:44.3172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 37TNtQpoh+LH/cLLidl4Id8bEJstdggAFFXdasC33qPgq9+r2QMKih7iCnUPMdM0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7740 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/17/2023 3:13 PM, Ferruh Yigit wrote: > On 11/14/2022 11:59 AM, Rongwei Liu wrote: >> In case flow rules match only one kind of traffic in a flow table, >> then optimization can be done via allocation of this table. >> Such optimization is possible only if the application gives a hint >> about its usage of the table during initial configuration. >> >> The transfer domain rules may process traffic from wire or vport, >> which may correspond to two kinds of underlayer resources. >> That's why the first two hints introduced in this patch are about >> wire and vport traffic specialization. >> Wire means traffic arrives from the uplink port while vport means >> traffic initiated from VF/SF. >> >> There are two possible approaches for providing the hints. >> Using IPv4 as an example: >> 1. Use pattern item in both template table and flow rules. >> >> pattern_template: pattern ANY_VPORT / eth / ipv4 is 1.1.1.1 / end >> async flow create: pattern ANY_VPORT / eth / ipv4 is 1.1.1.2 / end >> >> "ANY_VPORT" needs to be present in each flow rule even if it's >> just a hint. No value to match because matching is already done by >> IPv4 item. >> >> 2. Add special flags into table_attr. >> >> template_table 0 create table_id 0 group 1 transfer vport_orig >> >> Approach 1 needs to specify the pattern in each flow rule which wastes >> memory and is not user friendly. >> This patch takes the 2nd approach and introduces one new member >> "specialize" into rte_flow_table_attr to indicate possible flow table >> optimization. >> >> By default, there is no hint, so the behavior of the transfer domain >> doesn't change. >> There is no guarantee that the hint will be used by the PMD. >> >> Signed-off-by: Rongwei Liu >> Acked-by: Ori Kam > > Hi Andrew, Ivan, > > Do you have objection/comment to latest version, if not I will proceed > with patch? > BTW, there is an implementation of this flag in some driver, right?