From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Gaetan Rivet <grive@u256.net>
Cc: dev@dpdk.org, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/ring: fix eth_dev device pointer on allocation
Date: Fri, 8 May 2020 12:00:58 +0100 [thread overview]
Message-ID: <27de27ce-6518-1e6f-e7cd-48b167386dab@intel.com> (raw)
In-Reply-To: <61746fd5771ae6d359a02638ee6b5d027b43a981.1588788335.git.grive@u256.net>
On 5/6/2020 7:09 PM, Gaetan Rivet wrote:
> When a net_ring device is allocated, its device pointer is not set
> before calling rte_eth_dev_probing_finish, which is incorrect.
>
> The following:
> commit: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")
> commit: a6992e961050 ("net/ring: set ethernet device field")
>
> already fixed the same issue in 17.08, which was fine at the time.
> Adding the hook rte_eth_dev_probing_finish() however created this bug,
> as the eth_dev exposed when this hook is executed is expected to be
> complete.
>
> Remove the prior attempts to fix the issue in rte_pmd_ring_probe() and
> write the pointer properly in do_eth_dev_ring_create().
>
> Cc: stable@dpdk.org
> Fixes: fbe90cdd776c ("ethdev: add probing finish function")
> Signed-off-by: Gaetan Rivet <grive@u256.net>
I would prefer moving the assignment up in the stack where 'device' is
available, instead of moving the variable down in the stack to assign it, but
both does the work ...
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2020-05-08 11:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 10:44 [dpdk-dev] [PATCH] net/failsafe: fix fd leak wangyunjian
2020-04-27 11:12 ` Gaëtan Rivet
2020-04-27 16:55 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-05-03 11:33 ` Ali Alnubani
2020-05-04 16:22 ` Gaëtan Rivet
2020-05-04 16:28 ` Stephen Hemminger
2020-05-05 9:47 ` Ali Alnubani
2020-05-05 9:14 ` Ali Alnubani
2020-05-05 18:35 ` Gaëtan Rivet
2020-05-05 19:10 ` [dpdk-dev] [PATCH v1 0/3] failsafe & ring fixes Gaetan Rivet
2020-05-05 19:10 ` [dpdk-dev] [PATCH v1 1/3] net/failsafe: avoid crash on malformed eth_dev Gaetan Rivet
2020-05-06 17:16 ` Ferruh Yigit
2020-05-05 19:10 ` [dpdk-dev] [PATCH v1 2/3] net/ring: fix eth_dev device pointer on allocation Gaetan Rivet
2020-05-06 11:48 ` Ferruh Yigit
2020-05-06 12:33 ` Gaëtan Rivet
2020-05-06 13:43 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-05-06 17:32 ` Gaëtan Rivet
2020-05-06 18:09 ` [dpdk-dev] [PATCH v2] " Gaetan Rivet
2020-05-08 11:00 ` Ferruh Yigit [this message]
2020-05-11 16:54 ` Ferruh Yigit
2020-05-05 19:10 ` [dpdk-dev] [PATCH v1 3/3] net/failsafe: fix default service proxy state Gaetan Rivet
2020-05-06 8:58 ` Ali Alnubani
2020-05-06 17:16 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27de27ce-6518-1e6f-e7cd-48b167386dab@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).