From: Jeff Guo <jia.guo@intel.com>
To: Guinan Sun <guinanx.sun@intel.com>, dev@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>,
Dawid Lukwinski <dawid.lukwinski@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/8] net/i40e/base: enable FEC on/off flag setting for X722
Date: Mon, 27 Jul 2020 11:38:42 +0800 [thread overview]
Message-ID: <27f4ae53-2d3c-7462-acdd-9229028e6e52@intel.com> (raw)
In-Reply-To: <20200721074000.30449-2-guinanx.sun@intel.com>
Acked-by: Jeff Guo <jia.guo@intel.com>
On 7/21/2020 3:39 PM, Guinan Sun wrote:
> Starting with API version 1.10 firmware for X722 devices has ability
> to change FEC settings in PHY. Code added in this patch
> checks API version and sets appropriate capability flag.
>
> Signed-off-by: Dawid Lukwinski <dawid.lukwinski@intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> drivers/net/i40e/base/i40e_adminq.c | 6 ++++++
> drivers/net/i40e/base/i40e_adminq_cmd.h | 2 ++
> drivers/net/i40e/base/i40e_type.h | 1 +
> 3 files changed, 9 insertions(+)
>
> diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c
> index c89e1fb3f..0da45f03e 100644
> --- a/drivers/net/i40e/base/i40e_adminq.c
> +++ b/drivers/net/i40e/base/i40e_adminq.c
> @@ -603,6 +603,12 @@ STATIC void i40e_set_hw_flags(struct i40e_hw *hw)
> (aq->api_maj_ver == 1 &&
> aq->api_min_ver >= I40E_MINOR_VER_GET_LINK_INFO_X722))
> hw->flags |= I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE;
> +
> + if (aq->api_maj_ver > 1 ||
> + (aq->api_maj_ver == 1 &&
> + aq->api_min_ver >= I40E_MINOR_VER_FW_REQUEST_FEC_X722))
> + hw->flags |= I40E_HW_FLAG_X722_FEC_REQUEST_CAPABLE;
> +
> /* fall through */
> default:
> break;
> diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h
> index 1905167f5..f790183be 100644
> --- a/drivers/net/i40e/base/i40e_adminq_cmd.h
> +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h
> @@ -25,6 +25,8 @@
> #define I40E_MINOR_VER_GET_LINK_INFO_X722 0x0009
> /* API version 1.6 for X722 devices adds ability to stop FW LLDP agent */
> #define I40E_MINOR_VER_FW_LLDP_STOPPABLE_X722 0x0006
> +/* API version 1.10 for X722 devices adds ability to request FEC encoding */
> +#define I40E_MINOR_VER_FW_REQUEST_FEC_X722 0x000A
>
> struct i40e_aq_desc {
> __le16 flags;
> diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h
> index 014a4c132..b5b5b928d 100644
> --- a/drivers/net/i40e/base/i40e_type.h
> +++ b/drivers/net/i40e/base/i40e_type.h
> @@ -745,6 +745,7 @@ struct i40e_hw {
> #define I40E_HW_FLAG_FW_LLDP_PERSISTENT BIT_ULL(5)
> #define I40E_HW_FLAG_AQ_PHY_ACCESS_EXTENDED BIT_ULL(6)
> #define I40E_HW_FLAG_DROP_MODE BIT_ULL(7)
> +#define I40E_HW_FLAG_X722_FEC_REQUEST_CAPABLE BIT_ULL(8)
> u64 flags;
>
> /* Used in set switch config AQ command */
next prev parent reply other threads:[~2020-07-27 3:38 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 7:39 [dpdk-dev] [PATCH 0/8] update i40e base code Guinan Sun
2020-07-21 7:39 ` [dpdk-dev] [PATCH 1/8] net/i40e/base: enable FEC on/off flag setting for X722 Guinan Sun
2020-07-27 3:38 ` Jeff Guo [this message]
2020-07-21 7:39 ` [dpdk-dev] [PATCH 2/8] net/i40e/base: add PTYPE definition Guinan Sun
2020-07-27 3:43 ` Jeff Guo
2020-07-21 7:39 ` [dpdk-dev] [PATCH 3/8] net/i40e/base: enable new custom cloud filters Guinan Sun
2020-07-27 3:53 ` Jeff Guo
2020-07-27 4:55 ` Sun, GuinanX
2020-07-21 7:39 ` [dpdk-dev] [PATCH 4/8] net/i40e/base: update FVL FW API version to 1.11 Guinan Sun
2020-07-21 7:39 ` [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL admin command Guinan Sun
2020-07-27 4:07 ` Jeff Guo
2020-07-27 4:53 ` Sun, GuinanX
2020-07-27 5:19 ` Sun, GuinanX
2020-07-21 7:39 ` [dpdk-dev] [PATCH 6/8] net/i40e/base: add disable unused ports capability Guinan Sun
2020-07-27 4:24 ` Jeff Guo
2020-07-27 5:01 ` Sun, GuinanX
2020-07-21 7:39 ` [dpdk-dev] [PATCH 7/8] net/i40e/base: replace AQ command for NVM update Guinan Sun
2020-07-27 4:32 ` Jeff Guo
2020-07-21 7:40 ` [dpdk-dev] [PATCH 8/8] net/i40e/base: update version Guinan Sun
2020-07-27 4:32 ` Jeff Guo
2020-07-27 5:34 ` [dpdk-dev] [PATCH v2 0/8] update i40e base code Guinan Sun
2020-07-27 5:34 ` [dpdk-dev] [PATCH v2 1/8] net/i40e/base: enable FEC on/off flag setting for X722 Guinan Sun
2020-07-27 5:34 ` [dpdk-dev] [PATCH v2 2/8] net/i40e/base: add PTYPE definition Guinan Sun
2020-07-27 5:34 ` [dpdk-dev] [PATCH v2 3/8] net/i40e/base: add new custom cloud filter types Guinan Sun
2020-07-27 6:43 ` Jeff Guo
2020-07-27 5:34 ` [dpdk-dev] [PATCH v2 4/8] net/i40e/base: update FW API version to 1.11 Guinan Sun
2020-07-27 6:44 ` Jeff Guo
2020-07-27 5:34 ` [dpdk-dev] [PATCH v2 5/8] net/i40e/base: fix possible uninitialized variable Guinan Sun
2020-07-27 6:45 ` Jeff Guo
2020-07-27 5:34 ` [dpdk-dev] [PATCH v2 6/8] net/i40e/base: support unused ports disabling Guinan Sun
2020-07-28 1:31 ` Jeff Guo
2020-07-27 5:34 ` [dpdk-dev] [PATCH v2 7/8] net/i40e/base: replace AQ command for NVM update Guinan Sun
2020-07-27 5:34 ` [dpdk-dev] [PATCH v2 8/8] net/i40e/base: update version Guinan Sun
2020-07-28 1:32 ` [dpdk-dev] [PATCH v2 0/8] update i40e base code Jeff Guo
2020-08-31 3:58 ` Zhang, Qi Z
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 00/15] " Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 01/15] net/i40e/base: enable FEC on/off flag setting for X722 Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 02/15] net/i40e/base: add PTYPE definition Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 03/15] net/i40e/base: add new custom cloud filter types Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 04/15] net/i40e/base: update FW API version to 1.12 Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 05/15] net/i40e/base: fix possible uninitialized variable Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 06/15] net/i40e/base: support unused ports disabling Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 07/15] net/i40e/base: replace AQ command for NVM update Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 08/15] net/i40e/base: add VLAN field for input set Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 09/15] net/i40e/base: enable pipe monitor thresholds Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 10/15] net/i40e/base: fix missing function header arguments Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 11/15] net/i40e/base: add support for Minimum Rollback Revision Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 12/15] net/i40e/base: fix Rx only mode for unicast promisc on VLAN Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 13/15] net/i40e/base: add EEE LPI status check for X722 adapters Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 14/15] net/i40e/base: fix PHY config param when enabling EEE Guinan Sun
2020-09-03 4:48 ` [dpdk-dev] [PATCH v3 15/15] net/i40e/base: update version Guinan Sun
2020-09-03 14:31 ` [dpdk-dev] [PATCH v3 00/15] update i40e base code Ferruh Yigit
2020-09-04 1:24 ` Sun, GuinanX
-- strict thread matches above, loose matches on Subject: below --
2020-07-21 6:31 [dpdk-dev] [PATCH 0/8] " Guinan Sun
2020-07-21 6:31 ` [dpdk-dev] [PATCH 1/8] net/i40e/base: enable FEC on/off flag setting for X722 Guinan Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27f4ae53-2d3c-7462-acdd-9229028e6e52@intel.com \
--to=jia.guo@intel.com \
--cc=beilei.xing@intel.com \
--cc=dawid.lukwinski@intel.com \
--cc=dev@dpdk.org \
--cc=guinanx.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).