* [PATCH] gpudev: export header file for external drivers
@ 2023-03-16 8:59 Thomas Monjalon
2023-03-16 9:23 ` David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2023-03-16 8:59 UTC (permalink / raw)
To: dev; +Cc: stable, David Marchand, Elena Agostini
In DPDK 21.05, the option driver_sdk_headers was introduced
to export required headers to allow building out-of-tree drivers.
In DPDK 21.11, the gpudev driver class was introduced,
without this out-of-tree compatibility.
It is fixed by exporting gpudev_driver.h as part of the driver SDK.
Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library")
Cc: stable@dpdk.org
Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/gpudev/meson.build | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/gpudev/meson.build b/lib/gpudev/meson.build
index 89a118f357..40dd6c0ffc 100644
--- a/lib/gpudev/meson.build
+++ b/lib/gpudev/meson.build
@@ -5,6 +5,10 @@ headers = files(
'rte_gpudev.h',
)
+driver_sdk_headers = files(
+ 'gpudev_driver.h'
+)
+
sources = files(
'gpudev.c',
)
--
2.39.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpudev: export header file for external drivers
2023-03-16 8:59 [PATCH] gpudev: export header file for external drivers Thomas Monjalon
@ 2023-03-16 9:23 ` David Marchand
2023-03-19 22:28 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2023-03-16 9:23 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, stable, Elena Agostini
On Thu, Mar 16, 2023 at 9:59 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> In DPDK 21.05, the option driver_sdk_headers was introduced
> to export required headers to allow building out-of-tree drivers.
>
> In DPDK 21.11, the gpudev driver class was introduced,
> without this out-of-tree compatibility.
>
> It is fixed by exporting gpudev_driver.h as part of the driver SDK.
>
> Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library")
> Cc: stable@dpdk.org
>
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
LGTM, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpudev: export header file for external drivers
2023-03-16 9:23 ` David Marchand
@ 2023-03-19 22:28 ` Thomas Monjalon
2023-03-19 22:43 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2023-03-19 22:28 UTC (permalink / raw)
To: Elena Agostini; +Cc: dev, stable, David Marchand
16/03/2023 10:23, David Marchand:
> On Thu, Mar 16, 2023 at 9:59 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > In DPDK 21.05, the option driver_sdk_headers was introduced
> > to export required headers to allow building out-of-tree drivers.
> >
> > In DPDK 21.11, the gpudev driver class was introduced,
> > without this out-of-tree compatibility.
> >
> > It is fixed by exporting gpudev_driver.h as part of the driver SDK.
> >
> > Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library")
> > Cc: stable@dpdk.org
> >
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> LGTM, thanks.
Applied
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpudev: export header file for external drivers
2023-03-19 22:28 ` Thomas Monjalon
@ 2023-03-19 22:43 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2023-03-19 22:43 UTC (permalink / raw)
To: Elena Agostini; +Cc: dev, stable, David Marchand
19/03/2023 23:28, Thomas Monjalon:
> 16/03/2023 10:23, David Marchand:
> > On Thu, Mar 16, 2023 at 9:59 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > In DPDK 21.05, the option driver_sdk_headers was introduced
> > > to export required headers to allow building out-of-tree drivers.
> > >
> > > In DPDK 21.11, the gpudev driver class was introduced,
> > > without this out-of-tree compatibility.
> > >
> > > It is fixed by exporting gpudev_driver.h as part of the driver SDK.
> > >
> > > Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library")
> > > Cc: stable@dpdk.org
> > >
> > > Reported-by: David Marchand <david.marchand@redhat.com>
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > LGTM, thanks.
>
> Applied
Forgot to send the v2 merged with this addition:
"
As a consequence of exporting this header file,
C++ "extern C" guard must be added.
"
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-19 22:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 8:59 [PATCH] gpudev: export header file for external drivers Thomas Monjalon
2023-03-16 9:23 ` David Marchand
2023-03-19 22:28 ` Thomas Monjalon
2023-03-19 22:43 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).