From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FA06A0C41; Wed, 6 Oct 2021 18:30:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9649C4115F; Wed, 6 Oct 2021 18:30:51 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id EC9EE410EA for <dev@dpdk.org>; Wed, 6 Oct 2021 18:30:49 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 62E075C071B; Wed, 6 Oct 2021 12:30:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 06 Oct 2021 12:30:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= HxJ7+YHVotOQkNelwAi/nLFbLq/nV2E1WkTcbokhDZg=; b=pDD1MgOlc+FzI3kD F8GDZ0TbL6jbFJwc4YdatPP0O+7j5q0iI/Rx7RiN+3oHlqtXc1tDgOY0mnlx5rVK EFj5dVbBBfot7Qr0QJra/2SahfaLOQtbPyDpFmJWco9ju53lT4qB8z6UTa9rNtXx aXAa+FFqGj3HbP18LGVCr4S4ViA0dmWZdl1XMoixPCjeWbejK7bDsJ8O9C3wwkOo HHAKiPAUzibF0+fEyaoymp3OYG0an7zOQTs79u+m48pC3clasaOUhxg5olkB3gJx x+xwsWoXXJgQfjr81wW9BlxAJ0W+efyVol3jHvD706P2pKYBo1pPrJI3Nr0GthQv /0Wfcw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=HxJ7+YHVotOQkNelwAi/nLFbLq/nV2E1WkTcbokhD Zg=; b=gZIQyDA87sR4prEmo44Bhh/O5yMvqutCk4grAH/XNylvJMEkdDVuhX/Wn tUx53zSAV/GSJzETG9rUveTrKXUy2b4v/2wOVxcjL1YOlR+VSh9gF/+PMouABqec 77vsxT7Ms3xtEGqBQ3Jbefv7J0ifb2qko//ZDW2KW92h5zFqapgg6O++e+eNFN8v yjtfuLCItbM/u+OTOZKHc4LBqfyg3ldNc62y6vjPRB7t581GZo8F3b2o6qib3XYV NtcSYmTxLGJrrsMIeRyU9UVy9sJtLKOqX2A6NbbITQDCtMY5Z642K6SPm4eKFJ1n EtYMc+VP9yLEl8xV+I6WkWZFJojcQ== X-ME-Sender: <xms:OM9dYR7IhTkx9OOgXEqeJGDI5HHorzPsHzyVEBN68D3hdbc_eCLlHA> <xme:OM9dYe5EX3fF1VLn_I1yYtLOJoWaszBNGAiDNH0xnfD8kDkZs1G3D6SAz4YtxH_i4 2ow1iIPiFJfnQIW2g> X-ME-Received: <xmr:OM9dYYeFRlILKhEh09uGbgN1ZMw_YvzzDpJOjRSMExnK55SD8nZCQIFd7ff2WmZn3bDkgcr_PTdu-K_xP3FG7U3IL9f6AfQiNErztFb2LEU> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeliedgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:OM9dYaKQVdPQOgDzZg4n_Tu2PCWirpJpQRBOvLmB5_Z0sM2-XolAFw> <xmx:OM9dYVLl--iTailmf_ASTby1a2M0tVG2XEZZZeHoHr1y2oRNvha0rg> <xmx:OM9dYTzsxodPddSSFRKL7w-NX6PTKIJVr-cVSwDWpZfSPioARZwMfA> <xmx:OM9dYV0dslsjhHD99AIj3GXDgjr5km_5kXasCzWqvmMeb8mOPBmc-Q> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Oct 2021 12:30:46 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, Olivier Matz <olivier.matz@6wind.com>, Stephen Hemminger <sthemmin@microsoft.com> Date: Wed, 06 Oct 2021 18:30:43 +0200 Message-ID: <2804183.gA0sqFl6Ob@thomas> In-Reply-To: <20211001163306.76538-2-dmitry.kozliuk@gmail.com> References: <20210915214052.143098-1-dmitry.kozliuk@gmail.com> <20211001163306.76538-1-dmitry.kozliuk@gmail.com> <20211001163306.76538-2-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/2] net: rename Ethernet header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 01/10/2021 18:33, Dmitry Kozlyuk: > Definition of `rte_ether_addr` structure used a workaround allowing DPDK > and Windows SDK headers to be used in the same file, because Windows SDK > defines `s_addr` as a macro. Rename `s_addr` to `src_addr` and `d_addr` > to `dst_addr` to avoid the conflict and remove the workaround. There is a compilation issue for Power: app/test-pmd/macswap.h:32:33: error: =E2=80=98struct rte_ether_hdr=E2=80=99 has no member named =E2=80=98d_addr= =E2=80=99 I think there are more misses: % git grep -lw d_addr examples examples/bond/main.c examples/l3fwd-power/main.c examples/l3fwd/l3fwd_em.h examples/l3fwd/l3fwd_fib.c examples/l3fwd/l3fwd_lpm.c examples/l3fwd/l3fwd_lpm.h examples/performance-thread/l3fwd-thread/main.c