From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DA56A0542; Fri, 2 Sep 2022 07:20:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B185740693; Fri, 2 Sep 2022 07:20:19 +0200 (CEST) Received: from guvercin.ceng.metu.edu.tr (guvercin.ceng.metu.edu.tr [144.122.171.43]) by mails.dpdk.org (Postfix) with ESMTP id 9962B40684; Fri, 2 Sep 2022 07:20:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTP id 1AFE02C5E9; Fri, 2 Sep 2022 08:20:18 +0300 (+03) X-Virus-Scanned: Debian amavisd-new at ceng.metu.edu.tr Received: from guvercin.ceng.metu.edu.tr ([127.0.0.1]) by localhost (guvercin.ceng.metu.edu.tr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wJVMZ8lPOUJw; Fri, 2 Sep 2022 08:20:11 +0300 (+03) Received: from roundcube.ceng.metu.edu.tr (kanarya.ceng.metu.edu.tr [144.122.171.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: e1885458) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTPSA id 5D6CD2C1B6; Fri, 2 Sep 2022 08:20:10 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ceng.metu.edu.tr; s=mail; t=1662096011; bh=2LS2EmFreuursnpFDUNiPNNEHsjsymrkvAy9fWNKuxY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=epC0JdXsNggPUNOgrrY+8IjCOgMlZXF+MKAnXAiip0y9xLmPW6W07Y5azfwTIEXnm 810aBsIE+d/L+NsnHz5/KVlz/nz/7sQ2psnMN+QsYIzQAksyaCN+IBbNhLqjFyjRif /oFIL0BfCPs3CdlZ17G6CCSuq/gMxAwbpJ+am1fk= MIME-Version: 1.0 Date: Fri, 02 Sep 2022 08:20:10 +0300 From: Omer Yamac To: "Hunt, David" Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH v2] examples/distributor: update dynamic configuration In-Reply-To: References: <20220621211346.81545-1-omer.yamac@ceng.metu.edu.tr> <20220628195425.401077-1-omer.yamac@ceng.metu.edu.tr> User-Agent: Roundcube Webmail Message-ID: <280448dcd62dc2fc16f3f6907e52d728@ceng.metu.edu.tr> X-Sender: omer.yamac@ceng.metu.edu.tr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David, I applied the changes as new version (v3), Thank you On 01.09.2022 13:58, Hunt, David wrote: > Hi Ömer, > > On 28/06/2022 20:54, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer > Yamaç) wrote: >> In this patch, >> * It is possible to switch the running mode of the distributor >> using the command line argument. >> * With "-c" parameter, you can run RX and Distributor >> on the same core. >> * Without "-c" parameter, you can run RX and Distributor >> on the different core. >> * Syntax error of the single RX and distributor core is fixed. > > > I believe this particular fix is already merged and back-ported to > stable. No need to include this line in the commit message. > > >> * Consecutive termination of the lcores fixed. >> The termination order was wrong, and you couldn't terminate the >> application while traffic was capturing. The current order is >> RX -> Distributor -> TX -> Workers >> * When "-c" parameter is active, the wasted distributor core is >> also deactivated in the main function. >> >> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core") >> Cc: stable at dpdk.org > > > This is a feature change, not a fix, so I don't believe you need the > "Fixes" line or the "Cc: stable" line. > > >> >> Signed-off-by: Abdullah ?mer Yama? > > > I've tested this with the "-c" option, works well. Traffic coming into > the app is distributed among the core. With -c added to the command > line parameters, I have an extra worker core, as expected. Looks good > to me. > > With the above suggested changes to the commit message: > > Reviewed-by: David Hunt