From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 7B1345398
 for <dev@dpdk.org>; Tue, 15 Mar 2016 21:44:20 +0100 (CET)
Received: by mail-wm0-f48.google.com with SMTP id l68so165540212wml.0
 for <dev@dpdk.org>; Tue, 15 Mar 2016 13:44:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=FXX95yGGptZsJOgANDtWWRtIdYiGTFSHW2rhJg/qkKY=;
 b=0vN9Xg+j6LUYYFwKQzbJidCXuB45RrAHxfj60Ls47HyD3EWzb4DMt+pCa+tmCyMlZO
 ah1KnVajW1jJZMGNdiPFBic0Ygrxk2iw0FT7Jg1qTwM1d/q2QHG9UuON9arE/wPoY3T2
 SD/vJhQ1zPIb5MhPm0lWd8o+jDeuWkUBXA1N1y0VB9IcACjlbwM0ge512876A8p2ntv3
 2yXgjhsDYCMZUNvjkVX43cZBafvidIVUI72yzrtB0oEf3WK82rM63K6tSjVsBi0iA+US
 UZhlWB4Kx2QWNgDxV18X68HREhAN6X4cPjNwQCPxqbzKOMpmLJk9I+DexdW+IcoTq+uC
 rmeQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=FXX95yGGptZsJOgANDtWWRtIdYiGTFSHW2rhJg/qkKY=;
 b=ZT0qOuDBG+3FanKhirkaOn+M157A0hAj8/QiI5g3KgEI4cNendTRCyeohKISAE9bG+
 POla5Ij5bure+U91KauhvXxWk4HXzXRFoW2jA5nIrCznaGMOtZJ5CQcamdVgySqiXMKp
 Ga2uoaoVYMOgy73uMISLrDmvfh1C1T/CeC8jOm6KBtW9vng3mxbxyVyHM3oXMHI+iCiO
 fQOGnZ1M0hrYJvT0lawrO7ulX0L9Yyzspvu3Cp0BmwgFY7Ji2saUjvRZemLwARUdF9gx
 gNcOBGmr+D91o1QjJURgtzyrK7Y57PtU7lhtUogWk0dwM/wHH8l6SBF/LAZTJI+Z8/3O
 CG3Q==
X-Gm-Message-State: AD7BkJIf1qfpcMy3Vfor5GF0kggcx1xenCkZ9uOOfqJm8Mrv/J1j0e4LRgQSnaZEUBqy1X1y
X-Received: by 10.28.217.146 with SMTP id q140mr24810834wmg.85.1458074660363; 
 Tue, 15 Mar 2016 13:44:20 -0700 (PDT)
Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91])
 by smtp.gmail.com with ESMTPSA id n66sm395875wmg.20.2016.03.15.13.44.19
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 15 Mar 2016 13:44:19 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org
Date: Tue, 15 Mar 2016 21:42:54 +0100
Message-ID: <2804669.uFzlJRKE3s@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1457125740-13233-1-git-send-email-johndale@cisco.com>
References: <1456106650-26727-1-git-send-email-johndale@cisco.com>
 <1457125740-13233-1-git-send-email-johndale@cisco.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v6] enic: receive path performance
	improvements
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Mar 2016 20:44:21 -0000

2016-03-04 13:09, John Daley:
> +#ifdef RTE_NEXT_ABI
> +               pkt_err_flags |= PKT_RX_MAC_ERR;
> +#else
> +               pkt_err_flags |= PKT_EXT_RX_PKT_ERROR;
> +#endif
> +       }
> +
> +       /* Check for bad FCS. MAC error isn't quite, but no other choice */
> +       if (!enic_cq_rx_desc_fcs_ok(cqrd)) {
> +#ifdef RTE_NEXT_ABI
> +               pkt_err_flags |= PKT_RX_MAC_ERR;
> +#else
> +               pkt_err_flags |= PKT_EXT_RX_BAD_FCS;
> +#endif

It seems to be a mistake, leading to build failure when NEXT_ABI is disabled.
Will be fixed when rebased on master branch.