From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 023F8FFA for ; Fri, 27 Jan 2017 17:20:02 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id c85so123910294wmi.1 for ; Fri, 27 Jan 2017 08:20:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=5wkTNXMpuXQsR6zdxU9tFO+8QR9wdUojsRHLWUHqcr0=; b=obgUkjISePylrHRUbe+SC9WDZfdZdbssijq/c6xD0M7x25OXatTqSpWBrir+8x+dNS C956uePVC74Pm3We9ZTXV14E6Ge3GGbJHOKGaoOuxs2d2q3Fx1H0EnVNYdYw3XMWfCP7 XJI6Kz8ohG3MWUiA7IQstp5apB+vbSrqQQj7BuowwOD2Ya25TBdRxFitWqi4EPR0186O m3o148oJngwgnyTaY+79ftXMTVsP3bhsnO1/ryNRJpzGoB+LLD9MJA7n2HP+mgNe8mwX kxhn5n12GbbZKzpy+8/37rt650rqtVWWa8AFaCUKvn1Ne2kEqz6dDPmWP6Q4V6/mrjVd il4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=5wkTNXMpuXQsR6zdxU9tFO+8QR9wdUojsRHLWUHqcr0=; b=URVk2TBnpRqBzzwOqimTNp1MbTqcdXk52N2Yzhi6KLCuble2Hz/xCNs6wFJjDspovE T9i8obSOBdvEoTb5c1KxjIotAvGJ77+sBrrqLY/kkj6LlRig3YjDbh5nApydMP1W6VwF gkKboh1ieaoVfSOcK7qenuPH27BhyppPebs+AK3PuWhLokQWaEeuVucmtr1QuRa041AM xE5nVmBbZqJ5KEnAq3UbRHDE6NgftWo5Y4zKCEAVLXYIfA7SgFBbpSzhLStEKgEydMvO yzhmRQka15tr7o0C2dgrpFkLSvKKaeHAYWQDhMYwnSyTc01YFl4ZHjSdLc5o8y4iLXWo 9CAg== X-Gm-Message-State: AIkVDXKGNsrnWrPyHEkePVrqIjCpgbFX/pIJrK4udBeDN1dimUooYkDpFHAv+WpRAHo0wCe6 X-Received: by 10.223.130.204 with SMTP id 70mr7946740wrc.128.1485534002696; Fri, 27 Jan 2017 08:20:02 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id g75sm4608906wme.5.2017.01.27.08.20.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jan 2017 08:20:01 -0800 (PST) Date: Fri, 27 Jan 2017 08:20:01 -0800 (PST) X-Google-Original-Date: Fri, 27 Jan 2017 17:20 +0100 From: Thomas Monjalon To: Zbigniew Bodek Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com Message-ID: <2810758.uGRdNRuYUv@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1484663736-32195-1-git-send-email-zbigniew.bodek@caviumnetworks.com> <2047286.uqzdbYr9PH@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: fix build of assembly files for ARM64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 16:20:03 -0000 2017-01-18 12:31, Zbigniew Bodek: > > On 17.01.2017 23:45, Thomas Monjalon wrote: > > 2017-01-17 15:35, zbigniew.bodek@caviumnetworks.com: > >> -# for now, we don't use as but nasm. > >> -# AS = $(CROSS)as > > > > It looks to be a very very old comment. > > > >> +ifeq ($(CONFIG_RTE_ARCH_X86),y) > >> AS = nasm > > > > There is no asm file in DPDK as far as I know. > > So why would we have a dependency on nasm for x86? > > Yes, there is no such file now. We were to add assembly code but > eventually we decided to put it in a separate library. Nevertheless this > fix should be harmless if there is no ASM file and will behave correctly > if someone will add ASM file in the future. Please remove the ifeq and keep only $(CROSS)as as below. > >> +else > >> +AS = $(CROSS)as > >> +endif > >