DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
Cc: Joshua Washington <joshwash@google.com>, dev@dpdk.org
Subject: Re: [PATCH] net/gve: Fix TX/RX queue setup and stop
Date: Thu, 25 Jul 2024 14:09:38 +0100	[thread overview]
Message-ID: <28107725-0349-47a8-8cc1-8fd720b18746@amd.com> (raw)
In-Reply-To: <CA++LmPWOb-fw9S01kndmxOFg-5nwbeyB-TUdqb8inbJHjgKiBw@mail.gmail.com>

On 7/25/2024 1:51 PM, Tathagat Priyadarshi wrote:
> Hi Ferruh,
> 
> It’s my mistake, there was a coding error in the first email and i did
> send out v2, but it somehow didn't go through and i kept getting failure
> emails, So i fixed and repushed it only to find out later that v2 was
> also updated. So i had to defer the previous PR.
> 

So, this patch and v2 are same, if so lets continue with v2 one, as it
has proper versioning. Can you update patchwork accordingly?


btw, not really matters but PR is "Pull Request" and this is a
terminology mostly related to github based development. In mail list
based development we call it patch, or "patch series"/patchset (if
multiple patches are together).

> I have added Acked by Joshua, since the diff was originally shared with
> him and he was okay with it.
> 

Better to have this publicly, and explicitly so it is recorded.

@Joshua, if you are OK with patch, can you please ack/review?

> Regards,
> TP
> 
> 
> On Thu, 25 Jul 2024 at 18:08, Ferruh Yigit <ferruh.yigit@amd.com
> <mailto:ferruh.yigit@amd.com>> wrote:
> 
>     On 7/24/2024 2:35 PM, Tathagat Priyadarshi wrote:
>     > The PR aims to update the TX/RQ queue setup/stop routines that are
>     > unique to DQO, so that they may be called for instances that use the
>     > DQO RDA format during dev start/stop.
>     >
>     > Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com
>     <mailto:tathagat.dpdk@gmail.com>>
>     > Acked-by: Joshua Washington <joshwash@google.com
>     <mailto:joshwash@google.com>>
>     >
> 
> 
>     Is this v3 ?
> 
>     And I can see Joshua's ack, but I didn't see it explicitly, did you work
>     together in background for this?
> 


  reply	other threads:[~2024-07-25 13:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24  5:58 [PATCH] net/gve: Fix TX/RX queue setup and stop for DQO Tathagat Priyadarshi
2024-07-24  6:56 ` [PATCH v2] net/gve: Fix TX/RX queue setup and stop Tathagat Priyadarshi
2024-07-24 13:35 ` [PATCH] " Tathagat Priyadarshi
2024-07-25 12:38   ` Ferruh Yigit
2024-07-25 12:51     ` Tathagat Priyadarshi
2024-07-25 13:09       ` Ferruh Yigit [this message]
2024-07-25 13:31   ` [PATCH v2] " Tathagat Priyadarshi
2024-07-26 10:37     ` Tathagat Priyadarshi
2024-07-26 11:33       ` Ferruh Yigit
2024-07-29 18:10         ` Joshua Washington
2024-07-30 11:26         ` Ferruh Yigit
2024-07-31  5:26     ` Tathagat Priyadarshi
2024-07-31 13:02       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28107725-0349-47a8-8cc1-8fd720b18746@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=dev@dpdk.org \
    --cc=joshwash@google.com \
    --cc=tathagat.dpdk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).