From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id B75495A6D for ; Thu, 9 Jul 2015 23:28:56 +0200 (CEST) Received: by wgjx7 with SMTP id x7so233847468wgj.2 for ; Thu, 09 Jul 2015 14:28:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zW9s8tW3MB9yAAjnFYdxf9WrYq8efMLtDPbQ27M4l2U=; b=Ixwi4DiIBp4h8vdb0rgeZqXA79zdDuB3JsMt3W+lnLM10IIQv3g0jBNPVjxYHzB0c+ XAeCz3rLGI5M6a2aHE6jyKY1zgAXADLiXsjT8vYGGnANIjm/SYNO1DLVYFxr8g+V/eee uf2g21ZPqA5ManEesWioRGQ2e8k4x9yOG4c9lvQrSO5wSrWPcEIeHDZzu7m74IY+1Vt7 THk4cMdpVD/aJE1qjB09XTP3l4xAsogXoekCnwV7iBYIbhEiZABLmGrF+OftCn3zFVXF pQWMa0hOAw/ehxeGDzPaew2N/Tc1w6Kg+JB1pRIJdeG72Qq6hIRzs6d/hfJwBDV+4p9z 1pwg== X-Gm-Message-State: ALoCoQmbZy9JUEDy3TSyykVxmmHB6qHroJ6f1tV2Pfu0ac9xM98820fuVmfFFvkAa/3R7gvDASpI X-Received: by 10.180.206.147 with SMTP id lo19mr85409182wic.79.1436477336458; Thu, 09 Jul 2015 14:28:56 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id nb9sm10073827wic.10.2015.07.09.14.28.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jul 2015 14:28:54 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Thu, 09 Jul 2015 23:27:47 +0200 Message-ID: <2812093.yvipHqyS69@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150709141545.4f4aa344@urahara> References: <1436465737-16818-1-git-send-email-stephen@networkplumber.org> <1616814.fx6A2joykc@xps13> <20150709141545.4f4aa344@urahara> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 0/4] bnx2x: new poll mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 21:28:57 -0000 2015-07-09 14:15, Stephen Hemminger: > On Thu, 09 Jul 2015 22:41:23 +0200 > Thomas Monjalon wrote: > > > REJECTED > > > > 2015-07-09 11:15, Stephen Hemminger: > > > Changes in this version: > > > - rebase for PCI uio changes > > > - fix version map for 2.1 > > > - add BCM57840 support > > > > You ignore the comments which are done. > > Examples for this series: > > http://dpdk.org/ml/archives/dev/2015-June/019556.html > > http://dpdk.org/ml/archives/dev/2015-July/020714.html > > You rarely reply to comments and you seem laughing when versioning the patches: > > Sorry, it was so long between versions I lost track. > > > > v4 on 05-08: http://dpdk.org/ml/archives/dev/2015-May/017438.html > > v5 on 06-17: http://dpdk.org/ml/archives/dev/2015-June/019490.html > > v3 on 07-08: http://dpdk.org/ml/archives/dev/2015-July/021046.html > > v4 on 08-08: http://dpdk.org/ml/archives/dev/2015-July/021277.html > > > > This series still has some obvious errors. > > I may help to review them if you show that you care about previous comments > > like doxygen errors, correct linker file syntax or even git send-email > > guidelines. > > I will go back and fix doxygen, what is the linker issue? The example I've given shows a keyword "global:" that you missed. > The send-email guidelines issues are unclear?? It's explained in http://dpdk.org/dev#send. Good usage of --subject-prefix, --annotate and --in-reply-to are expected. > QLogic is helping out, there maybe a couple of other changes as well.