DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
Cc: dev@dpdk.org, "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] dev: fix devargs memleak on IPC detach request
Date: Sun, 25 Nov 2018 13:33:23 +0100	[thread overview]
Message-ID: <2812273.Y8qkDiBMIR@xps> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611532EA1E6@SHSMSX103.ccr.corp.intel.com>

23/11/2018 20:17, Zhang, Qi Z:
> From: Stojaczyk, Dariusz
> > Device detach triggered through IPC leaked some memory.
> > It allocated a devargs objects just to use it for parsing the devargs string in order
> > to retrieve the device name. Those devargs weren't passed anywhere and were
> > never freed.
> > 
> > First of all, let's put those devargs on the stack, so they doesn't need to be freed.
> > Then free the additional arguments string as soon as it's allocated, because we
> > won't need it.
> > 
> > Fixes: ac9e4a17370f ("eal: support attach/detach shared device from
> > secondary")
> > Cc: qi.z.zhang@intel.com
> > 
> > Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied, thanks

      reply	other threads:[~2018-11-25 12:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23 14:11 Darek Stojaczyk
2018-11-23 19:17 ` Zhang, Qi Z
2018-11-25 12:33   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2812273.Y8qkDiBMIR@xps \
    --to=thomas@monjalon.net \
    --cc=dariusz.stojaczyk@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).