From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E53B41B478 for ; Sun, 25 Nov 2018 13:33:26 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E99162112B; Sun, 25 Nov 2018 07:33:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 25 Nov 2018 07:33:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=lUddu3rWMdeEK64cs3SBZXYGdrwZ/vrL1p4XRQAyzQ4=; b=Fj0RyBTYTI1M kLCdmU1/eb6unct/G5OJIRR7EJrGgQrRzs/z1K/0/Z51NLWNQu0SW1LTLRzSevHf YBh87ojqCrbmGLIUnzVh9VJYEirfveNfgyss42bMI/9SP4M+EMxQrVK22CiEDd7T CX3DCepUTJ2eesVG/QUrPw6cVEToOT8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=lUddu3rWMdeEK64cs3SBZXYGdrwZ/vrL1p4XRQAyz Q4=; b=l3qw6SAajwJPMhvEwVX+NpEJHKPE/WeKCHXDCpffz0Fw4gvRhNfwsFMZ0 H9132i5npGxPB7b8Y9WQzeL6he6QsFg/HunZEGuAPrIxfKQP82bR1QW44ZuahhSq kKMgf5QD1amUimxXDpIZBEfb1nYzbXBhq1m5XBkbTnY07s9McP1CTDKHQqoxJMIB Re5GPQJeBF5ZFku4zgO9YHPDSwo1t6mgjBm58NkKxxiwXSBgK2eQqG7B8k0CDSZj SkauHKAqstxe1vtYXZ1oa6uvfjVMqIFpk2n2Sx+KzMLaDQXZaELPZCvrVKKokLnV /mTrQmVmAhkMnMiU8uaS+xSU7Ao8Q== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B35FCE4675; Sun, 25 Nov 2018 07:33:24 -0500 (EST) From: Thomas Monjalon To: "Stojaczyk, Dariusz" Cc: dev@dpdk.org, "Zhang, Qi Z" Date: Sun, 25 Nov 2018 13:33:23 +0100 Message-ID: <2812273.Y8qkDiBMIR@xps> In-Reply-To: <039ED4275CED7440929022BC67E70611532EA1E6@SHSMSX103.ccr.corp.intel.com> References: <20181123141107.86553-1-dariusz.stojaczyk@intel.com> <039ED4275CED7440929022BC67E70611532EA1E6@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] dev: fix devargs memleak on IPC detach request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2018 12:33:27 -0000 23/11/2018 20:17, Zhang, Qi Z: > From: Stojaczyk, Dariusz > > Device detach triggered through IPC leaked some memory. > > It allocated a devargs objects just to use it for parsing the devargs string in order > > to retrieve the device name. Those devargs weren't passed anywhere and were > > never freed. > > > > First of all, let's put those devargs on the stack, so they doesn't need to be freed. > > Then free the additional arguments string as soon as it's allocated, because we > > won't need it. > > > > Fixes: ac9e4a17370f ("eal: support attach/detach shared device from > > secondary") > > Cc: qi.z.zhang@intel.com > > > > Signed-off-by: Darek Stojaczyk > > Acked-by: Qi Zhang Applied, thanks