Re: [dpdk-dev] [PATCH v3] vfio: Fix overflow while assigning vfio BAR region offset and size

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-07-13 14:21, Rahul Lakkireddy:
> When using vfio, the probe fails for BAR > 0 after the
> commit-id 90a1633b2 (eal/linux: allow to map BARs with MSI-X tables).
> 
> While debugging further, found that the BAR region offset and size read from
> vfio are u64, but are assigned to uint32_t variables.  This results in the u64
> value getting truncated to 0 and passing wrong offset and size to mmap for
> subsequent BAR regions.
> 
> The fix is to use unsigned long for the offset and size.
> 
> This is based on patch by Alejandro Lucero <alejandro.lucero@netronome.com>
> posted at below:
> 
> http://dpdk.org/ml/archives/dev/2015-June/020201.html
> 
> and updated with diff from below to fix 32-bit compilation:
> 
> http://dpdk.org/ml/archives/dev/2015-July/020963.html
> 
> Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>

Applied, thanks