Re: [dpdk-dev] [PATCH] mem: mark pages as not accessed when returning back to memory pool

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 24-Apr-20 11:42 AM, Li Feng wrote:
> Commit 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA")
> has mapped the initialized memory with PROT_NONE, and when it's unmapped,
> eal_memalloc.c should remmap the anonymous memory with PROT_NONE too.
> 
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
>   lib/librte_eal/linux/eal_memalloc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linux/eal_memalloc.c b/lib/librte_eal/linux/eal_memalloc.c
> index 9d2a6fc6f..64a2b44c1 100644
> --- a/lib/librte_eal/linux/eal_memalloc.c
> +++ b/lib/librte_eal/linux/eal_memalloc.c
> @@ -683,7 +683,7 @@ free_seg(struct rte_memseg *ms, struct hugepage_info *hi,
>   	/* erase page data */
>   	memset(ms->addr, 0, ms->len);
>   
> -	if (mmap(ms->addr, ms->len, PROT_READ,
> +	if (mmap(ms->addr, ms->len, PROT_NONE,
>   			MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0) ==
>   				MAP_FAILED) {
>   		RTE_LOG(DEBUG, EAL, "couldn't unmap page\n");
> 

Fixes: 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA")
Cc: david.marchand@redhat.com
Cc: stable@dpdk.org

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly