From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id B3BBC5A87 for ; Thu, 16 Jul 2015 02:14:24 +0200 (CEST) Received: by wicmv11 with SMTP id mv11so1794616wic.1 for ; Wed, 15 Jul 2015 17:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=F8TCgc4/CRzVMfQ5BtADw4X8zPDXubNpER8KsPDWe5k=; b=N00eNPzHdOQ+3P4k/tL4u/ULVeF4wywDaEMnLqW+3KYRwaHWu6fyvxnHRM+Af3w9OS p2xt5+I1Vo2isgSbtIc6GNG/Q4ZFtrk85Exzrq/Xn3tefPFkgfF0FFzPs2klQERZK5V1 n5DNEOMm+/tHk1Qbvuc3cS426cdgzZbFMT6Q+UA4e8sH51xFf0XJ7BSSzJG44xZ8NlYw dMUKxPJ2LT51skS1VOsrAf+zS8AsYRgHu0bL5AbVFAJZQjgM41cXTypqaTvr+P++5AU6 JvGMFfWezn+Ir06mO0EnrQY2Aps6mFu2+TOpDUfd5L0koT+hr1Hb36PcEowmHRz9ttf5 0zyA== X-Gm-Message-State: ALoCoQlJjXdW6W5hhTWybpiU9jgxofg+OEoy1eLOVyj5LxLZG5amj7sPvmE7+1ViQUBEnpOzd2Dv X-Received: by 10.194.58.167 with SMTP id s7mr13459603wjq.38.1437005664520; Wed, 15 Jul 2015 17:14:24 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id lz10sm10202728wjb.48.2015.07.15.17.14.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2015 17:14:23 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Thu, 16 Jul 2015 02:13:13 +0200 Message-ID: <28177519.UZIomONHXn@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1437004212-31646-1-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mbuf: fix tunnel flags check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 00:14:24 -0000 2015-07-15 23:57, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > A packet is tunnelled if the tunnel type is identified or if it has an inner part. > > > > Fix also a typo in RTE_PTYPE_INNER_L3_MASK. > > > > Fixes: f295a00a2b44 ("mbuf: add definitions of unified packet types") > > > > Signed-off-by: Thomas Monjalon |...] > > /* Check if it is a tunneling packet */ > > -#define RTE_ETH_IS_TUNNEL_PKT(ptype) ((ptype) & RTE_PTYPE_TUNNEL_MASK) > > +#define RTE_ETH_IS_TUNNEL_PKT(ptype) ((ptype) & (RTE_PTYPE_TUNNEL_MASK | \ > > + RTE_PTYPE_INNER_L2_MASK | \ > > + RTE_PTYPE_INNER_L3_MASK | \ > > + RTE_PTYPE_INNER_L4_MASK)) > > Could you help to explain more of why here? > My understanding is that if an inner one can be recognized, there must be a tunnel type there. Not always. It was my comment in mlx4 patch: http://dpdk.org/ml/archives/dev/2015-July/021702.html Currently we can know that mlx4 has detected a tunnel but don't know which one.