From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 35A234415D;
Wed, 5 Jun 2024 12:42:18 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E585F4067B;
Wed, 5 Jun 2024 12:42:17 +0200 (CEST)
Received: from fhigh5-smtp.messagingengine.com
(fhigh5-smtp.messagingengine.com [103.168.172.156])
by mails.dpdk.org (Postfix) with ESMTP id 90F2940289
for <dev@dpdk.org>; Wed, 5 Jun 2024 12:42:16 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.48])
by mailfhigh.nyi.internal (Postfix) with ESMTP id 0CF80114019B;
Wed, 5 Jun 2024 06:42:16 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute7.internal (MEProxy); Wed, 05 Jun 2024 06:42:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to; s=fm1; t=1717584136;
x=1717670536; bh=HBgu8hWQvDOZs8/ahUawAsjYvrNN/T+uP/AiRcXni3c=; b=
NOBvJNyCQhCD9SHDfKPfT55memuyDcgXGBM7lCWzr4LuxBeXtCOh4RJ0mJyeETKB
kbUFC+TAlQw1c17vLkg+uNlRnX5B5X4MhBh1Zwsul7jU9sQNYIfNtcEljBZjcm5J
6V27LKm6tX+0SNr0zKHLQqkG3seGx0LGAO8jR9f1Z3/U378QM3LayvKJCkJtDRIk
+ls19Bhujv5Nt7LcYgkDQkY8ALEjjRFT6GlLAM8pZdSsfYyKJQ64Dfnf1FhlXu20
FcKlXRdw7iEl+KvAxq0NW9810XI+Man8+4GrjJAPsNX8YOPaHcnO1xRzoPU+eti3
WPiJTycJpCVglCJsok696w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717584136; x=
1717670536; bh=HBgu8hWQvDOZs8/ahUawAsjYvrNN/T+uP/AiRcXni3c=; b=g
mSWn168cWELQ9dEy8pInXglVMkUdDijjf69B/L59d8vETDvVIGvSBMED5fjYpJac
yB1LRKx3pmdampzRv02eVh8I6d7RFv4oHunUSK4UeZWhMtuR4mpNK0vHbB8JSEUk
6JfG3eS+q0q3ZkBKa681eBl4jO8lgQbpgZa+YlNdkRrw2PFWFrIO5bt7C0vBHyny
bjE3Y32XBA1V0Pp1iOj5ASgRS9XL0ZEJkTfmEhxTKrcmnfFDCmmxl8j0QIg/p/ND
a1GvY3zrtHdpsgMYggiI8WBoyLWfXOmeSZkJQ0L1Iju86bZI0fSeyNH8Ze6eK7YD
2je5yV1MPItgEGo2N001w==
X-ME-Sender: <xms:B0FgZqdY_KteigMIkm29lUnMWQm6x0XLzNgAg4UzNHmIAbQETfBIxQ>
<xme:B0FgZkPlAcZJr7JV5CRaF2nVfhwl0JEM11AZYkXSB-zPurkxCFUGkVHBQg3gISw93
3D8qfi1YhBoPrIQ1g>
X-ME-Received: <xmr:B0FgZrgn7W1lXnFmb0WteB_Iu5UUKBgoBZYHQZbubtIH5Fc_Ad_eUUjKcz7OwXy2Dl4uLfheeavs2xJZ3s3K3gmk-Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeliedgfeduucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeek
gfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:B0FgZn-lLFIMGSwiZIALxw-qOMfH5RDyt0dHHIN5hB2gDn-yQeYoSg>
<xmx:B0FgZmtVCgnLCq2G-Sn3_OSmxCQ_9n2zKFIgV2uRaWmT_U-kSV3wuQ>
<xmx:B0FgZuEcrysVs7wqP40RMIaQ_IfFN_THxrgUq8ufjVY-SE8LQ3yEbQ>
<xmx:B0FgZlMDix3cILOE30J6jDaatO5T-68q6G0_v5rccLJJbqM6arAOOQ>
<xmx:CEFgZqg13Roh7nBNlor0Aq7SIA4N0MpNK-qp1F-5-2-jZ_JFU2__CC_I>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
5 Jun 2024 06:42:14 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Rongwei Liu <rongweil@nvidia.com>
Cc: dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com,
suanmingm@nvidia.com
Subject: Re: [PATCH v6 2/4] net: add new union into VXLAN header
Date: Wed, 05 Jun 2024 12:42:13 +0200
Message-ID: <2818222.B0Pyx7erxp@thomas>
In-Reply-To: <20240605102136.117614-3-rongweil@nvidia.com>
References: <6203165.YiXZdWvhHV@thomas>
<20240605102136.117614-1-rongweil@nvidia.com>
<20240605102136.117614-3-rongweil@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
05/06/2024 12:21, Rongwei Liu:
> Add "uint8_t last_rsvd" as union with origin rsvd1.
You should explain why: for matching what we have in testpmd.
I think it should be squashed with the next patch.
> - uint8_t rsvd1; /**< Reserved. */
> + union {
> + uint8_t rsvd1; /**< Reserved. */
> + uint8_t last_rsvd; /**< Reserved. */
> + };